Skip to content

Target only net7.0 during source-build - Port of #75168 to main - #77052

Merged
MichaelSimons merged 2 commits into
dotnet:mainfrom
crummel:portNetTfmFix
Oct 26, 2022
Merged

Target only net7.0 during source-build - Port of #75168 to main#77052
MichaelSimons merged 2 commits into
dotnet:mainfrom
crummel:portNetTfmFix

Conversation

@crummel

@crummelcrummel commented Oct 14, 2022

Copy link
Copy Markdown
Contributor

Port of #75168 to main. These changes are also needed to support building main in source build.

  • Target net7.0 in additional projects

  • Update compatibility suppressions

  • Only target net7.0 for source-build

  • Disable package validation for source-build

  • Revert compatibility suppression changes

  • Use NetCoreAppCurrent instead of hardcoding net7.0

  • Revert mono Apple TFM change

  • Remove unnecessary LangVersion

@lbussell@crummel
Target only net7.0 during source-build
fbdfced
Port of dotnet#75168 to main.
* Target net7.0 in additional projects
* Update compatibility suppressions
* Only target net7.0 for source-build
* Disable package validation for source-build
* Revert compatibility suppression changes
* Use NetCoreAppCurrent instead of hardcoding net7.0
* Revert mono Apple TFM change
* Remove unnecessary LangVersion
@ghostghost assigned crummelOct 14, 2022
@ghost

ghost commented Oct 14, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Port of #75168 to main. These changes are also needed to support building main in source build.

  • Target net7.0 in additional projects

  • Update compatibility suppressions

  • Only target net7.0 for source-build

  • Disable package validation for source-build

  • Revert compatibility suppression changes

  • Use NetCoreAppCurrent instead of hardcoding net7.0

  • Revert mono Apple TFM change

  • Remove unnecessary LangVersion

Author:crummel
Assignees:-
Labels:

area-Infrastructure-libraries

Milestone:-

@carlossanlop

carlossanlop commented Oct 14, 2022

Copy link
Copy Markdown
Contributor

Unlike the release/7.0 change, this commit isn't here:

Remove unnecessary LangVersion

Does that line not exist in main?

@lbussell

lbussell commented Oct 14, 2022

Copy link
Copy Markdown
Member

Unlike the release/7.0 change, this commit isn't here:

Remove unnecessary LangVersion

Does that line not exist in main?

Correct, looks like it is already removed: https://github.com/dotnet/runtime/blob/main/src/libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj#L8

ViktorHofer
ViktorHofer reviewed Oct 14, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.RegularExpressions/tools/GenerateRegexCasingTable.csproj Outdated
@build-analysisbuild-analysisBot mentioned this pull request Oct 14, 2022
Closed
ViktorHofer
ViktorHofer reviewed Oct 15, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.RegularExpressions/tools/GenerateRegexCasingTable.csproj Outdated
@crummelcrummel mentioned this pull request Oct 18, 2022
Merged
This was referenced Oct 19, 2022
Closed
Closed
@crummel

crummel commented Oct 21, 2022

Copy link
Copy Markdown
ContributorAuthor

@ViktorHofer anything else that needs to happen before this is merged? Thanks!

@MichaelSimons
MichaelSimons merged commit 57740e2 into dotnet:mainOct 26, 2022
@ghostghost locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes
@lbusselllbusselllbussell approved these changes
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop
+1 more reviewer
@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@crummelcrummel

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@crummel@carlossanlop@lbussell@ViktorHofer@kasperk81@MichaelSimons@smasher164