Modify __int64 definition in PAL to match the OS definition by janvorli · Pull Request #77056 · dotnet/runtime

janvorli · 2022-10-14T19:03:23Z

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers.

The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

The changes I had to make in runtime were due to the fact that size_t and ssize_t are not defined as __int64 anymore due to the change and many places relied on the fact those matched.

The StressLog tools were defining couple of types including size_t on its own, which collided with the new definitions. I've fixed it by including the stdint.h instead of defining the types manually.

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

jkotas · 2022-10-14T19:40:19Z

cc @AaronRobinsonMSFT This contributes to Win32 PAL elimination.

jkotas

LGTM

shushanhf · 2022-10-19T09:44:01Z

 // they must be either signed or unsigned) and we want to be able to use
 // __int64 as though it were intrinsic

-#ifdef HOST_64BIT


There is an error after deleting this on LoongArch64.
In file included from /home/qiao/work_qiao/runtime/src/coreclr/debug/di/platformspecific.cpp:37: /home/qiao/work_qiao/runtime/src/coreclr/debug/di/loongarch64/cordbregisterset.cpp:272:18: error: cannot initialize a variable of type 'ULONG64 *' (aka 'unsigned long long *') with an rvalue of type 'SIZE_T *' (aka 'unsigned long *') ULONG64* pSrc = &m_rd->A0; ^ ~~~~~~~~~ 1 error generated.

@jkotas
Why define the ULONG64 as unsigned long long ?
While define SIZE_T as unsigned long ?

@jkotas Why define the ULONG64 as unsigned long long ? While define SIZE_T as unsigned long ?
Thanks
I had noted #77268

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?
Yes, it's ok for LA64 now.
Thanks.

…7056) * Modify __int64 definition in PAL to match the OS definition This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names. * Fix coreclr tests build * Fix comment on #endif in jit.h * Reflect PR feedback * Fix jit source formatting * Fix FreeBSD build

janvorli · 2022-10-14T19:03:23Z

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers.

The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

The changes I had to make in runtime were due to the fact that size_t and ssize_t are not defined as __int64 anymore due to the change and many places relied on the fact those matched.

The StressLog tools were defining couple of types including size_t on its own, which collided with the new definitions. I've fixed it by including the stdint.h instead of defining the types manually.

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

jkotas · 2022-10-14T19:40:19Z

cc @AaronRobinsonMSFT This contributes to Win32 PAL elimination.

jkotas

LGTM

shushanhf · 2022-10-19T09:44:01Z

 // they must be either signed or unsigned) and we want to be able to use
 // __int64 as though it were intrinsic

-#ifdef HOST_64BIT


There is an error after deleting this on LoongArch64.
In file included from /home/qiao/work_qiao/runtime/src/coreclr/debug/di/platformspecific.cpp:37: /home/qiao/work_qiao/runtime/src/coreclr/debug/di/loongarch64/cordbregisterset.cpp:272:18: error: cannot initialize a variable of type 'ULONG64 *' (aka 'unsigned long long *') with an rvalue of type 'SIZE_T *' (aka 'unsigned long *') ULONG64* pSrc = &m_rd->A0; ^ ~~~~~~~~~ 1 error generated.

@jkotas
Why define the ULONG64 as unsigned long long ?
While define SIZE_T as unsigned long ?

@jkotas Why define the ULONG64 as unsigned long long ? While define SIZE_T as unsigned long ?
Thanks
I had noted #77268

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?
Yes, it's ok for LA64 now.
Thanks.

…7056) * Modify __int64 definition in PAL to match the OS definition This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names. * Fix coreclr tests build * Fix comment on #endif in jit.h * Reflect PR feedback * Fix jit source formatting * Fix FreeBSD build

janvorli · 2022-10-14T19:03:23Z

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers.

The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

The changes I had to make in runtime were due to the fact that size_t and ssize_t are not defined as __int64 anymore due to the change and many places relied on the fact those matched.

The StressLog tools were defining couple of types including size_t on its own, which collided with the new definitions. I've fixed it by including the stdint.h instead of defining the types manually.

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

jkotas · 2022-10-14T19:40:19Z

cc @AaronRobinsonMSFT This contributes to Win32 PAL elimination.

jkotas

LGTM

shushanhf · 2022-10-19T09:44:01Z

 // they must be either signed or unsigned) and we want to be able to use
 // __int64 as though it were intrinsic

-#ifdef HOST_64BIT


There is an error after deleting this on LoongArch64.
In file included from /home/qiao/work_qiao/runtime/src/coreclr/debug/di/platformspecific.cpp:37: /home/qiao/work_qiao/runtime/src/coreclr/debug/di/loongarch64/cordbregisterset.cpp:272:18: error: cannot initialize a variable of type 'ULONG64 *' (aka 'unsigned long long *') with an rvalue of type 'SIZE_T *' (aka 'unsigned long *') ULONG64* pSrc = &m_rd->A0; ^ ~~~~~~~~~ 1 error generated.

@jkotas
Why define the ULONG64 as unsigned long long ?
While define SIZE_T as unsigned long ?

@jkotas Why define the ULONG64 as unsigned long long ? While define SIZE_T as unsigned long ?
Thanks
I had noted #77268

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?
Yes, it's ok for LA64 now.
Thanks.

…7056) * Modify __int64 definition in PAL to match the OS definition This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names. * Fix coreclr tests build * Fix comment on #endif in jit.h * Reflect PR feedback * Fix jit source formatting * Fix FreeBSD build

janvorli · 2022-10-14T19:03:23Z

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers.

The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

The changes I had to make in runtime were due to the fact that size_t and ssize_t are not defined as __int64 anymore due to the change and many places relied on the fact those matched.

The StressLog tools were defining couple of types including size_t on its own, which collided with the new definitions. I've fixed it by including the stdint.h instead of defining the types manually.

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

jkotas · 2022-10-14T19:40:19Z

cc @AaronRobinsonMSFT This contributes to Win32 PAL elimination.

jkotas

LGTM

shushanhf · 2022-10-19T09:44:01Z

 // they must be either signed or unsigned) and we want to be able to use
 // __int64 as though it were intrinsic

-#ifdef HOST_64BIT


There is an error after deleting this on LoongArch64.
In file included from /home/qiao/work_qiao/runtime/src/coreclr/debug/di/platformspecific.cpp:37: /home/qiao/work_qiao/runtime/src/coreclr/debug/di/loongarch64/cordbregisterset.cpp:272:18: error: cannot initialize a variable of type 'ULONG64 *' (aka 'unsigned long long *') with an rvalue of type 'SIZE_T *' (aka 'unsigned long *') ULONG64* pSrc = &m_rd->A0; ^ ~~~~~~~~~ 1 error generated.

@jkotas
Why define the ULONG64 as unsigned long long ?
While define SIZE_T as unsigned long ?

@jkotas Why define the ULONG64 as unsigned long long ? While define SIZE_T as unsigned long ?
Thanks
I had noted #77268

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?
Yes, it's ok for LA64 now.
Thanks.

…7056) * Modify __int64 definition in PAL to match the OS definition This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names. * Fix coreclr tests build * Fix comment on #endif in jit.h * Reflect PR feedback * Fix jit source formatting * Fix FreeBSD build

janvorli · 2022-10-14T19:03:23Z

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers.

The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

The changes I had to make in runtime were due to the fact that size_t and ssize_t are not defined as __int64 anymore due to the change and many places relied on the fact those matched.

The StressLog tools were defining couple of types including size_t on its own, which collided with the new definitions. I've fixed it by including the stdint.h instead of defining the types manually.

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

jkotas · 2022-10-14T19:40:19Z

cc @AaronRobinsonMSFT This contributes to Win32 PAL elimination.

jkotas

LGTM

shushanhf · 2022-10-19T09:44:01Z

 // they must be either signed or unsigned) and we want to be able to use
 // __int64 as though it were intrinsic

-#ifdef HOST_64BIT


There is an error after deleting this on LoongArch64.
In file included from /home/qiao/work_qiao/runtime/src/coreclr/debug/di/platformspecific.cpp:37: /home/qiao/work_qiao/runtime/src/coreclr/debug/di/loongarch64/cordbregisterset.cpp:272:18: error: cannot initialize a variable of type 'ULONG64 *' (aka 'unsigned long long *') with an rvalue of type 'SIZE_T *' (aka 'unsigned long *') ULONG64* pSrc = &m_rd->A0; ^ ~~~~~~~~~ 1 error generated.

@jkotas
Why define the ULONG64 as unsigned long long ?
While define SIZE_T as unsigned long ?

@jkotas Why define the ULONG64 as unsigned long long ? While define SIZE_T as unsigned long ?
Thanks
I had noted #77268

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?
Yes, it's ok for LA64 now.
Thanks.

…7056) * Modify __int64 definition in PAL to match the OS definition This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names. * Fix coreclr tests build * Fix comment on #endif in jit.h * Reflect PR feedback * Fix jit source formatting * Fix FreeBSD build

janvorli · 2022-10-14T19:03:23Z

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers.

The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

The changes I had to make in runtime were due to the fact that size_t and ssize_t are not defined as __int64 anymore due to the change and many places relied on the fact those matched.

The StressLog tools were defining couple of types including size_t on its own, which collided with the new definitions. I've fixed it by including the stdint.h instead of defining the types manually.

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

jkotas · 2022-10-14T19:40:19Z

cc @AaronRobinsonMSFT This contributes to Win32 PAL elimination.

jkotas

LGTM

shushanhf · 2022-10-19T09:44:01Z

 // they must be either signed or unsigned) and we want to be able to use
 // __int64 as though it were intrinsic

-#ifdef HOST_64BIT


There is an error after deleting this on LoongArch64.
In file included from /home/qiao/work_qiao/runtime/src/coreclr/debug/di/platformspecific.cpp:37: /home/qiao/work_qiao/runtime/src/coreclr/debug/di/loongarch64/cordbregisterset.cpp:272:18: error: cannot initialize a variable of type 'ULONG64 *' (aka 'unsigned long long *') with an rvalue of type 'SIZE_T *' (aka 'unsigned long *') ULONG64* pSrc = &m_rd->A0; ^ ~~~~~~~~~ 1 error generated.

@jkotas
Why define the ULONG64 as unsigned long long ?
While define SIZE_T as unsigned long ?

@jkotas Why define the ULONG64 as unsigned long long ? While define SIZE_T as unsigned long ?
Thanks
I had noted #77268

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?
Yes, it's ok for LA64 now.
Thanks.

…7056) * Modify __int64 definition in PAL to match the OS definition This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names. * Fix coreclr tests build * Fix comment on #endif in jit.h * Reflect PR feedback * Fix jit source formatting * Fix FreeBSD build

janvorli · 2022-10-14T19:03:23Z

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers.

The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

The changes I had to make in runtime were due to the fact that size_t and ssize_t are not defined as __int64 anymore due to the change and many places relied on the fact those matched.

The StressLog tools were defining couple of types including size_t on its own, which collided with the new definitions. I've fixed it by including the stdint.h instead of defining the types manually.

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

jkotas · 2022-10-14T19:40:19Z

cc @AaronRobinsonMSFT This contributes to Win32 PAL elimination.

jkotas

LGTM

shushanhf · 2022-10-19T09:44:01Z

 // they must be either signed or unsigned) and we want to be able to use
 // __int64 as though it were intrinsic

-#ifdef HOST_64BIT


There is an error after deleting this on LoongArch64.
In file included from /home/qiao/work_qiao/runtime/src/coreclr/debug/di/platformspecific.cpp:37: /home/qiao/work_qiao/runtime/src/coreclr/debug/di/loongarch64/cordbregisterset.cpp:272:18: error: cannot initialize a variable of type 'ULONG64 *' (aka 'unsigned long long *') with an rvalue of type 'SIZE_T *' (aka 'unsigned long *') ULONG64* pSrc = &m_rd->A0; ^ ~~~~~~~~~ 1 error generated.

@jkotas
Why define the ULONG64 as unsigned long long ?
While define SIZE_T as unsigned long ?

@jkotas Why define the ULONG64 as unsigned long long ? While define SIZE_T as unsigned long ?
Thanks
I had noted #77268

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?
Yes, it's ok for LA64 now.
Thanks.

…7056) * Modify __int64 definition in PAL to match the OS definition This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names. * Fix coreclr tests build * Fix comment on #endif in jit.h * Reflect PR feedback * Fix jit source formatting * Fix FreeBSD build

janvorli · 2022-10-14T19:03:23Z

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers.

The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

The changes I had to make in runtime were due to the fact that size_t and ssize_t are not defined as __int64 anymore due to the change and many places relied on the fact those matched.

The StressLog tools were defining couple of types including size_t on its own, which collided with the new definitions. I've fixed it by including the stdint.h instead of defining the types manually.

This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names.

jkotas · 2022-10-14T19:40:19Z

cc @AaronRobinsonMSFT This contributes to Win32 PAL elimination.

jkotas

LGTM

shushanhf · 2022-10-19T09:44:01Z

 // they must be either signed or unsigned) and we want to be able to use
 // __int64 as though it were intrinsic

-#ifdef HOST_64BIT


There is an error after deleting this on LoongArch64.
In file included from /home/qiao/work_qiao/runtime/src/coreclr/debug/di/platformspecific.cpp:37: /home/qiao/work_qiao/runtime/src/coreclr/debug/di/loongarch64/cordbregisterset.cpp:272:18: error: cannot initialize a variable of type 'ULONG64 *' (aka 'unsigned long long *') with an rvalue of type 'SIZE_T *' (aka 'unsigned long *') ULONG64* pSrc = &m_rd->A0; ^ ~~~~~~~~~ 1 error generated.

@jkotas
Why define the ULONG64 as unsigned long long ?
While define SIZE_T as unsigned long ?

@jkotas Why define the ULONG64 as unsigned long long ? While define SIZE_T as unsigned long ?
Thanks
I had noted #77268

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?

this has been special cased to MacOS only in this PR: #77268, so guessing that should solve your issue?
Yes, it's ok for LA64 now.
Thanks.

…7056) * Modify __int64 definition in PAL to match the OS definition This change modifies the definition of __int64 and thus of many other types defined on the basis of it to match the OS definitions. This ensures that we can use these types in interfaces between code in coreclr and various PALs that are compiled against OS headers. The key issue was that we were defining __int64 for 64 bit OSes as long while Unix defines it as long long. The size of those types is the same on Unix, but they are different and result in different mangling of C++ names. * Fix coreclr tests build * Fix comment on #endif in jit.h * Reflect PR feedback * Fix jit source formatting * Fix FreeBSD build

janvorli added the area-PAL-coreclr only for closed issues label Oct 14, 2022

janvorli added this to the 8.0.0 milestone Oct 14, 2022

janvorli requested review from cshung, jakobbotsch, jkotas and mangod9 October 14, 2022 19:03

janvorli self-assigned this Oct 14, 2022

jkotas reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/debug/createdump/crashinfounix.cpp Outdated

janvorli added 2 commits October 14, 2022 13:30

Fix coreclr tests build
92d2787

Fix comment on #endif in jit.h
4bada87

AaronRobinsonMSFT reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/inc/check.inl
Comment threadsrc/coreclr/pal/inc/pal_mstypes.h

janvorli added 3 commits October 14, 2022 15:01

Reflect PR feedback
ddafbc2

Fix jit source formatting
6d13629

Fix FreeBSD build
cc99180

build-analysisBot mentioned this pull request Oct 15, 2022
Assertion failed: (*card_word)==0 in DynamicGenerics tests #76801
Closed

jkotas approved these changes Oct 18, 2022
View reviewed changes

jkotas merged commit fda2fee into dotnet:mainOct 18, 2022

shushanhf reviewed Oct 19, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Nov 20, 2022

janvorli added the area-PAL-coreclr only for closed issues label Oct 14, 2022

janvorli added this to the 8.0.0 milestone Oct 14, 2022

janvorli requested review from cshung, jakobbotsch, jkotas and mangod9 October 14, 2022 19:03

janvorli self-assigned this Oct 14, 2022

jkotas reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/debug/createdump/crashinfounix.cpp Outdated

janvorli added 2 commits October 14, 2022 13:30

Fix coreclr tests build
92d2787

Fix comment on #endif in jit.h
4bada87

AaronRobinsonMSFT reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/inc/check.inl
Comment threadsrc/coreclr/pal/inc/pal_mstypes.h

janvorli added 3 commits October 14, 2022 15:01

Reflect PR feedback
ddafbc2

Fix jit source formatting
6d13629

Fix FreeBSD build
cc99180

build-analysisBot mentioned this pull request Oct 15, 2022
Assertion failed: (*card_word)==0 in DynamicGenerics tests #76801
Closed

jkotas approved these changes Oct 18, 2022
View reviewed changes

jkotas merged commit fda2fee into dotnet:mainOct 18, 2022

shushanhf reviewed Oct 19, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Nov 20, 2022

janvorli added the area-PAL-coreclr only for closed issues label Oct 14, 2022

janvorli added this to the 8.0.0 milestone Oct 14, 2022

janvorli requested review from cshung, jakobbotsch, jkotas and mangod9 October 14, 2022 19:03

janvorli self-assigned this Oct 14, 2022

jkotas reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/debug/createdump/crashinfounix.cpp Outdated

janvorli added 2 commits October 14, 2022 13:30

Fix coreclr tests build
92d2787

Fix comment on #endif in jit.h
4bada87

AaronRobinsonMSFT reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/inc/check.inl
Comment threadsrc/coreclr/pal/inc/pal_mstypes.h

janvorli added 3 commits October 14, 2022 15:01

Reflect PR feedback
ddafbc2

Fix jit source formatting
6d13629

Fix FreeBSD build
cc99180

build-analysisBot mentioned this pull request Oct 15, 2022
Assertion failed: (*card_word)==0 in DynamicGenerics tests #76801
Closed

jkotas approved these changes Oct 18, 2022
View reviewed changes

jkotas merged commit fda2fee into dotnet:mainOct 18, 2022

shushanhf reviewed Oct 19, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Nov 20, 2022

janvorli added the area-PAL-coreclr only for closed issues label Oct 14, 2022

janvorli added this to the 8.0.0 milestone Oct 14, 2022

janvorli requested review from cshung, jakobbotsch, jkotas and mangod9 October 14, 2022 19:03

janvorli self-assigned this Oct 14, 2022

jkotas reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/debug/createdump/crashinfounix.cpp Outdated

janvorli added 2 commits October 14, 2022 13:30

Fix coreclr tests build
92d2787

Fix comment on #endif in jit.h
4bada87

AaronRobinsonMSFT reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/inc/check.inl
Comment threadsrc/coreclr/pal/inc/pal_mstypes.h

janvorli added 3 commits October 14, 2022 15:01

Reflect PR feedback
ddafbc2

Fix jit source formatting
6d13629

Fix FreeBSD build
cc99180

build-analysisBot mentioned this pull request Oct 15, 2022
Assertion failed: (*card_word)==0 in DynamicGenerics tests #76801
Closed

jkotas approved these changes Oct 18, 2022
View reviewed changes

jkotas merged commit fda2fee into dotnet:mainOct 18, 2022

shushanhf reviewed Oct 19, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Nov 20, 2022

janvorli added the area-PAL-coreclr only for closed issues label Oct 14, 2022

janvorli added this to the 8.0.0 milestone Oct 14, 2022

janvorli requested review from cshung, jakobbotsch, jkotas and mangod9 October 14, 2022 19:03

janvorli self-assigned this Oct 14, 2022

jkotas reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/debug/createdump/crashinfounix.cpp Outdated

janvorli added 2 commits October 14, 2022 13:30

Fix coreclr tests build
92d2787

Fix comment on #endif in jit.h
4bada87

AaronRobinsonMSFT reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/inc/check.inl
Comment threadsrc/coreclr/pal/inc/pal_mstypes.h

janvorli added 3 commits October 14, 2022 15:01

Reflect PR feedback
ddafbc2

Fix jit source formatting
6d13629

Fix FreeBSD build
cc99180

build-analysisBot mentioned this pull request Oct 15, 2022
Assertion failed: (*card_word)==0 in DynamicGenerics tests #76801
Closed

jkotas approved these changes Oct 18, 2022
View reviewed changes

jkotas merged commit fda2fee into dotnet:mainOct 18, 2022

shushanhf reviewed Oct 19, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Nov 20, 2022

janvorli added the area-PAL-coreclr only for closed issues label Oct 14, 2022

janvorli added this to the 8.0.0 milestone Oct 14, 2022

janvorli requested review from cshung, jakobbotsch, jkotas and mangod9 October 14, 2022 19:03

janvorli self-assigned this Oct 14, 2022

jkotas reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/debug/createdump/crashinfounix.cpp Outdated

janvorli added 2 commits October 14, 2022 13:30

Fix coreclr tests build
92d2787

Fix comment on #endif in jit.h
4bada87

AaronRobinsonMSFT reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/inc/check.inl
Comment threadsrc/coreclr/pal/inc/pal_mstypes.h

janvorli added 3 commits October 14, 2022 15:01

Reflect PR feedback
ddafbc2

Fix jit source formatting
6d13629

Fix FreeBSD build
cc99180

build-analysisBot mentioned this pull request Oct 15, 2022
Assertion failed: (*card_word)==0 in DynamicGenerics tests #76801
Closed

jkotas approved these changes Oct 18, 2022
View reviewed changes

jkotas merged commit fda2fee into dotnet:mainOct 18, 2022

shushanhf reviewed Oct 19, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Nov 20, 2022

janvorli added the area-PAL-coreclr only for closed issues label Oct 14, 2022

janvorli added this to the 8.0.0 milestone Oct 14, 2022

janvorli requested review from cshung, jakobbotsch, jkotas and mangod9 October 14, 2022 19:03

janvorli self-assigned this Oct 14, 2022

jkotas reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/debug/createdump/crashinfounix.cpp Outdated

janvorli added 2 commits October 14, 2022 13:30

Fix coreclr tests build
92d2787

Fix comment on #endif in jit.h
4bada87

AaronRobinsonMSFT reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/inc/check.inl
Comment threadsrc/coreclr/pal/inc/pal_mstypes.h

janvorli added 3 commits October 14, 2022 15:01

Reflect PR feedback
ddafbc2

Fix jit source formatting
6d13629

Fix FreeBSD build
cc99180

build-analysisBot mentioned this pull request Oct 15, 2022
Assertion failed: (*card_word)==0 in DynamicGenerics tests #76801
Closed

jkotas approved these changes Oct 18, 2022
View reviewed changes

jkotas merged commit fda2fee into dotnet:mainOct 18, 2022

shushanhf reviewed Oct 19, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Nov 20, 2022

janvorli added the area-PAL-coreclr only for closed issues label Oct 14, 2022

janvorli added this to the 8.0.0 milestone Oct 14, 2022

janvorli requested review from cshung, jakobbotsch, jkotas and mangod9 October 14, 2022 19:03

janvorli self-assigned this Oct 14, 2022

jkotas reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/debug/createdump/crashinfounix.cpp Outdated

janvorli added 2 commits October 14, 2022 13:30

Fix coreclr tests build
92d2787

Fix comment on #endif in jit.h
4bada87

AaronRobinsonMSFT reviewed Oct 14, 2022
View reviewed changes

Comment threadsrc/coreclr/inc/check.inl
Comment threadsrc/coreclr/pal/inc/pal_mstypes.h

janvorli added 3 commits October 14, 2022 15:01

Reflect PR feedback
ddafbc2

Fix jit source formatting
6d13629

Fix FreeBSD build
cc99180

build-analysisBot mentioned this pull request Oct 15, 2022
Assertion failed: (*card_word)==0 in DynamicGenerics tests #76801
Closed

jkotas approved these changes Oct 18, 2022
View reviewed changes

jkotas merged commit fda2fee into dotnet:mainOct 18, 2022

shushanhf reviewed Oct 19, 2022
View reviewed changes

ghost locked as resolved and limited conversation to collaborators Nov 20, 2022

Uh oh!

Conversation

janvorli commented Oct 14, 2022

Uh oh!

Uh oh!

jkotas commented Oct 14, 2022

Uh oh!

Uh oh!

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

shushanhfOct 19, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shushanhfOct 21, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

janvorli commented Oct 14, 2022

Uh oh!

Uh oh!

jkotas commented Oct 14, 2022

Uh oh!

Uh oh!

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

shushanhfOct 19, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shushanhfOct 21, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

janvorli commented Oct 14, 2022

Uh oh!

Uh oh!

jkotas commented Oct 14, 2022

Uh oh!

Uh oh!

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

shushanhfOct 19, 2022•
edited
Loading

shushanhfOct 21, 2022•
edited
Loading

shushanhfOct 19, 2022•
edited
Loading

shushanhfOct 21, 2022•
edited
Loading

shushanhfOct 19, 2022•
edited
Loading

shushanhfOct 21, 2022•
edited
Loading

shushanhfOct 19, 2022•
edited
Loading

shushanhfOct 21, 2022•
edited
Loading