Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] [mono][ppc64le] Fix wrong implementation of OP_CHECK_THIS - #77269
Merged
Conversation
vargaz
approved these changes
Oct 21, 2022
carlossanlop
commented
Nov 2, 2022
Contributor
CI failure is coming from WASM and unrelated, and has just been fixed, so no re-run needed: #76939 Approved by Tactics, signed off by area owner. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #76990 to release/7.0
/cc @lambdageek@Sapana-Khemkar
Customer Impact
Fixes a crash for customers running .NET on the PowerPC architecture in code that calls CoreLib methods that call
SpanHelpers.IndexOfValueType.In OP_CHECK_THIS access single byte only instead of double word.
This fixes crashes observed in runtime-portable/runtime during source build with rc1 on ppc64le. All these crashes were segmentation faults in SpanHelpers.IndexOfValueType.
Similar issue has been observed on s390 platform as well. Issue was opened https://github.com/dotnet/runtime/issues/76915and fixed by #76916
Testing
Manual testing
Risk
Low. The change is in the PPC-specific part of the mono JIT, and does not affect mobile, WASM or CoreCLR platforms.