Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] [ppc64le] Fixed FSharp crash issue - #77270
Merged
Merged
Conversation
vargaz
approved these changes
Oct 20, 2022
carlossanlop
commented
Nov 3, 2022
Contributor
Approved by Tactics. Signed off by code reviewer. No OOB package authoring changes needed for this change. CI failures are unrelated:
Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #77201 to release/7.0
/cc @lambdageek@alhad-deshpande
Customer Impact
Fixes a crash for customers running F# code on the PowerPC platform.
This PR fixes the issue #76917. The problem was that r12 after emit_memcpy was re-computed using the wrong value of r31 (frame pointer). Hence moved the save_lmf restoration block after computation of r12.
Testing
Manual testing
Risk
Low. The code is in the PPC part of the runtime and does not affect mobile, WASM or any CoreCLR platforms.