Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Revert "Override ReadAsync and WriteAsync methods on ConsoleStream." - #77382
Merged
Merged
Conversation
ghost
commented
Oct 24, 2022
Tagging subscribers to this area: @dotnet/area-system-console Issue DetailsBackport of #77360 to release/7.0 /cc @stephentoub Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
eerhardt
approved these changes
Oct 24, 2022
carlossanlop
commented
Nov 3, 2022
Contributor
Approved by Tactics, signed off by code reviewer, CI is green. No OOB package authoring changes needed for System.Console. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #77360 to release/7.0
/cc @stephentoub
Customer Impact
Calls to Console.In.ReadAsync / Console.Out.WriteAsync block rather than completing asynchronously.
Testing
CI
Risk
Minimal. This simply reverts a relatively late change that added some overrides in .NET 7