[wasm] browser profiler - #77449

Merged
lewing merged 6 commits into
dotnet:mainfrom
pavelsavara:wasm_browser_profiller
Nov 1, 2022
Merged

[wasm] browser profiler#77449
lewing merged 6 commits into
dotnet:mainfrom
pavelsavara:wasm_browser_profiller

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Oct 25, 2022•
edited
Loading

Copy link
Copy Markdown
Member

reporting both interpreter, AOT and some Javascript calls directly to chrome dev tools via performance.measure()

Chrome
image

FireFox
image

Profiler

  • mono profiler infrastructure allows to register multiple profiler plugins. This an implementation of one of them.
  • is implemented in src\mono\mono\profiler\browser.c only for WASM platform
  • it registers method enter/leave events.
  • There is no filter for the methods, so it would set flags and trigger for all managed methods.
  • it calls out into browser profiler via performance.measureAPI
  • interp is always calling the profiler callback, when installed
  • AOT compiler will emit icall to profiler for each flagged method
    • this means that profiler is running as part of JIT process in the AOT compiler.
  • JavaScript code of startup and interop methods are annotated

Usage

<PropertyGroup>
<WasmProfilers>browser;</WasmProfilers>
</PropertyGroup>

And

await dotnet
.withConfig({
browserProfilerOptions: {}
})
.run()

And start profiling in browser dev tools

Notes

  • alternatively we could implement plugin into EventPipe, which is itself mono profiler plugin. This solution is simpler.
  • when enabled: simple wasm to js call per event, method name building on first call to a method
  • no runtime overhead when not enabled in user project. Just some bytes for the new code in wasm.

Future work

  • enable method filtering by name, namespace, ...
  • max depth
  • start and end time
  • start and end method
  • report GC events and class loading and config to enable/disable it

Changes

  • new profiler browser.c
  • JS startup annotation
  • new static module libmono-profiler-browser.a it is always linked into dotnet.wasm in both Debug and Release configurations
  • profiler statically linked into AOT compiler on WASM target
  • updated advanced sample to enable profiler
  • cache for method names on JS side
  • fix for MonoAOTCompiler build task to pass --profiler argument to AOT compiler

Contributes to #76316

@pavelsavarapavelsavara added this to the 8.0.0 milestone Oct 25, 2022
@pavelsavarapavelsavara self-assigned this Oct 25, 2022
@ghost

ghost commented Oct 25, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:pavelsavara
Assignees:pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone:8.0.0

pavelsavara
pavelsavara commented Oct 25, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/CMakeLists.txt Outdated
@pavelsavara

This comment was marked as resolved.

Sign in to view
@jakobbotsch

This comment was marked as resolved.

Sign in to view
@pavelsavarapavelsavara changed the title [wasm] browser profiller[wasm] browser profilerOct 25, 2022
This was referenced Oct 25, 2022
Closed
Closed
@pavelsavara
pavelsavaraforce-pushed the wasm_browser_profiller branch from 16b5ee6 to 1df3637CompareOctober 25, 2022 22:15
@pavelsavarapavelsavara mentioned this pull request Oct 26, 2022
Closed
@pavelsavara
pavelsavara marked this pull request as ready for review October 26, 2022 16:39
radical
radical reviewed Oct 26, 2022
View reviewed changes

@radicalradical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incomplete review, just sharing some comments.

Comment threadsrc/mono/mono/metadata/profiler.c
Comment threadsrc/mono/mono/metadata/profiler.c Outdated
Comment threadsrc/mono/mono/profiler/browser.c Outdated
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets
This was referenced Oct 26, 2022
Closed
Closed
lambdageek
lambdageek reviewed Nov 1, 2022
View reviewed changes

@lambdageeklambdageek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except there seems to be some copy/paste errors in the invoke-cs methods

Comment threadsrc/mono/wasm/runtime/invoke-js.ts
Comment threadsrc/mono/wasm/runtime/invoke-cs.ts
vargaz
vargaz reviewed Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets
vargaz
vargaz reviewed Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c Outdated
vargaz
vargaz reviewed Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c Outdated
vargaz
vargaz reviewed Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/browser.h Outdated
vargaz
vargaz reviewed Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/wasm.proj
@lewing
lewing merged commit 0e24ea7 into dotnet:mainNov 1, 2022
radical added a commit to radical/runtime that referenced this pull request Nov 1, 2022
@radical
Revert "[wasm] browser profiler (dotnet#77449)"
2289b5b
This reverts commit 0e24ea7.
This breaks with v8 10.9.130 with:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
It works fine with older versions like `10.7.193` (current stable).
radical added a commit that referenced this pull request Nov 2, 2022
@radical
Revert "[wasm] browser profiler (#77449)" (#77759)
d3a3eda
This reverts commit 0e24ea7.
It broke all the perf pipeline wasm builds. It happens with v8 `10.9.130`:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
- It works fine with older versions like `10.7.193` (current stable).
- It wasn't caught in the CI checks because those are using an older version of v8.
@pavelsavarapavelsavara mentioned this pull request Nov 2, 2022
Merged
@radekdoulikradekdoulik mentioned this pull request Nov 2, 2022
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 1, 2022
@pavelsavara
pavelsavara deleted the wasm_browser_profiller branch September 2, 2024 15:29
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing approved these changes
@lambdageeklambdageeklambdageek approved these changes
@directhexdirecthexAwaiting requested review from directhex
@marafmarafAwaiting requested review from marafmaraf is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar
@vargazvargazAwaiting requested review from vargaz
@radicalradicalAwaiting requested review from radical

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@pavelsavara@jakobbotsch@radical@lewing@vargaz@lambdageek
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[wasm] browser profiler - #77449
Merged
lewing merged 6 commits into
dotnet:mainfrom 
pavelsavara:wasm_browser_profiller
Nov 1, 2022
Merged
[wasm] browser profiler#77449
lewing merged 6 commits into
dotnet:mainfrom 
pavelsavara:wasm_browser_profiller
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Oct 25, 2022•

edited

Loading

Copy link


Copy Markdown

Member
reporting both interpreter, AOT and some Javascript calls directly to chrome dev tools via performance.measure()
Chrome
image
FireFox
image
Profiler
  • mono profiler infrastructure allows to register multiple profiler plugins. This an implementation of one of them.
  • is implemented in src\mono\mono\profiler\browser.c only for WASM platform
  • it registers method enter/leave events.
  • There is no filter for the methods, so it would set flags and trigger for all managed methods.
  • it calls out into browser profiler via performance.measureAPI
  • interp is always calling the profiler callback, when installed
  • AOT compiler will emit icall to profiler for each flagged method

    • this means that profiler is running as part of JIT process in the AOT compiler.
  • JavaScript code of startup and interop methods are annotated
Usage
<PropertyGroup>
<WasmProfilers>browser;</WasmProfilers>
</PropertyGroup>

And
await dotnet
.withConfig({
browserProfilerOptions: {}
})
.run()

And start profiling in browser dev tools
Notes
  • alternatively we could implement plugin into EventPipe, which is itself mono profiler plugin. This solution is simpler.
  • when enabled: simple wasm to js call per event, method name building on first call to a method
  • no runtime overhead when not enabled in user project. Just some bytes for the new code in wasm.
Future work
  • enable method filtering by name, namespace, ...
  • max depth
  • start and end time
  • start and end method
  • report GC events and class loading and config to enable/disable it
Changes
  • new profiler browser.c
  • JS startup annotation
  • new static module libmono-profiler-browser.a it is always linked into dotnet.wasm in both Debug and Release configurations
  • profiler statically linked into AOT compiler on WASM target
  • updated advanced sample to enable profiler
  • cache for method names on JS side
  • fix for MonoAOTCompiler build task to pass --profiler argument to AOT compiler
Contributes to #76316
@pavelsavarapavelsavara
added this to the 8.0.0 milestone
Oct 25, 2022
@pavelsavarapavelsavara
self-assigned this
Oct 25, 2022
@ghost
ghost
commented
Oct 25, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:pavelsavara
Assignees:pavelsavara
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:8.0.0
pavelsavara
pavelsavara
commented
Oct 25, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/CMakeLists.txt
Outdated

@pavelsavara

This comment was marked as resolved.

Sign in to view
@jakobbotsch

This comment was marked as resolved.

Sign in to view
@pavelsavarapavelsavara
changed the title
[wasm] browser profiller[wasm] browser profilerOct 25, 2022

This was referenced Oct 25, 2022

Closed


Closed

@pavelsavara
pavelsavaraforce-pushed
the
wasm_browser_profiller
branch
from
16b5ee6 to
1df3637CompareOctober 25, 2022 22:15
@pavelsavarapavelsavara
mentioned this pull request
Oct 26, 2022
 Closed

@pavelsavara
pavelsavara
marked this pull request as ready for review
October 26, 2022 16:39
radical
radical
reviewed
Oct 26, 2022
View reviewed changes
@radicalradical
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incomplete review, just sharing some comments.
Comment threadsrc/mono/mono/metadata/profiler.c
Comment threadsrc/mono/mono/metadata/profiler.c
Outdated

Comment threadsrc/mono/mono/profiler/browser.c
Outdated

Comment threadsrc/mono/wasm/build/WasmApp.Native.targets

This was referenced Oct 26, 2022

Closed


Closed

lambdageek
lambdageek
reviewed
Nov 1, 2022
View reviewed changes
@lambdageeklambdageek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except there seems to be some copy/paste errors in the invoke-cs methods
Comment threadsrc/mono/wasm/runtime/invoke-js.ts
Comment threadsrc/mono/wasm/runtime/invoke-cs.ts
vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets
vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/browser.h
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/wasm.proj
@lewing
lewing
merged commit 0e24ea7
into
dotnet:mainNov 1, 2022
radical added a commit
to radical/runtime
that referenced
this pull request
Nov 1, 2022
@radical
Revert "[wasm] browser profiler (dotnet#77449)"
2289b5b
This reverts commit 0e24ea7.
This breaks with v8 10.9.130 with:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
It works fine with older versions like `10.7.193` (current stable).
radical added a commit
that referenced
this pull request
Nov 2, 2022
@radical
Revert "[wasm] browser profiler (#77449)" (#77759)
d3a3eda
This reverts commit 0e24ea7.
It broke all the perf pipeline wasm builds. It happens with v8 `10.9.130`:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
- It works fine with older versions like `10.7.193` (current stable).
- It wasn't caught in the CI checks because those are using an older version of v8.
@pavelsavarapavelsavara
mentioned this pull request
Nov 2, 2022
 Merged

@radekdoulikradekdoulik
mentioned this pull request
Nov 2, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 1, 2022
@pavelsavara
pavelsavara
deleted the

wasm_browser_profiller

branch
September 2, 2024 15:29
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@lambdageeklambdageeklambdageek approved these changes
@directhexdirecthexAwaiting requested review from directhex
@marafmarafAwaiting requested review from marafmaraf is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar
@vargazvargazAwaiting requested review from vargaz
@radicalradicalAwaiting requested review from radical

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@pavelsavara@jakobbotsch@radical@lewing@vargaz@lambdageek

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[wasm] browser profiler - #77449
Merged
lewing merged 6 commits into
dotnet:mainfrom 
pavelsavara:wasm_browser_profiller
Nov 1, 2022
Merged
[wasm] browser profiler#77449
lewing merged 6 commits into
dotnet:mainfrom 
pavelsavara:wasm_browser_profiller
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Oct 25, 2022•

edited

Loading

Copy link


Copy Markdown

Member
reporting both interpreter, AOT and some Javascript calls directly to chrome dev tools via performance.measure()
Chrome
image
FireFox
image
Profiler
  • mono profiler infrastructure allows to register multiple profiler plugins. This an implementation of one of them.
  • is implemented in src\mono\mono\profiler\browser.c only for WASM platform
  • it registers method enter/leave events.
  • There is no filter for the methods, so it would set flags and trigger for all managed methods.
  • it calls out into browser profiler via performance.measureAPI
  • interp is always calling the profiler callback, when installed
  • AOT compiler will emit icall to profiler for each flagged method

    • this means that profiler is running as part of JIT process in the AOT compiler.
  • JavaScript code of startup and interop methods are annotated
Usage
<PropertyGroup>
<WasmProfilers>browser;</WasmProfilers>
</PropertyGroup>

And
await dotnet
.withConfig({
browserProfilerOptions: {}
})
.run()

And start profiling in browser dev tools
Notes
  • alternatively we could implement plugin into EventPipe, which is itself mono profiler plugin. This solution is simpler.
  • when enabled: simple wasm to js call per event, method name building on first call to a method
  • no runtime overhead when not enabled in user project. Just some bytes for the new code in wasm.
Future work
  • enable method filtering by name, namespace, ...
  • max depth
  • start and end time
  • start and end method
  • report GC events and class loading and config to enable/disable it
Changes
  • new profiler browser.c
  • JS startup annotation
  • new static module libmono-profiler-browser.a it is always linked into dotnet.wasm in both Debug and Release configurations
  • profiler statically linked into AOT compiler on WASM target
  • updated advanced sample to enable profiler
  • cache for method names on JS side
  • fix for MonoAOTCompiler build task to pass --profiler argument to AOT compiler
Contributes to #76316
@pavelsavarapavelsavara
added this to the 8.0.0 milestone
Oct 25, 2022
@pavelsavarapavelsavara
self-assigned this
Oct 25, 2022
@ghost
ghost
commented
Oct 25, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:pavelsavara
Assignees:pavelsavara
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:8.0.0
pavelsavara
pavelsavara
commented
Oct 25, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/CMakeLists.txt
Outdated

@pavelsavara

This comment was marked as resolved.

Sign in to view
@jakobbotsch

This comment was marked as resolved.

Sign in to view
@pavelsavarapavelsavara
changed the title
[wasm] browser profiller[wasm] browser profilerOct 25, 2022

This was referenced Oct 25, 2022

Closed


Closed

@pavelsavara
pavelsavaraforce-pushed
the
wasm_browser_profiller
branch
from
16b5ee6 to
1df3637CompareOctober 25, 2022 22:15
@pavelsavarapavelsavara
mentioned this pull request
Oct 26, 2022
 Closed

@pavelsavara
pavelsavara
marked this pull request as ready for review
October 26, 2022 16:39
radical
radical
reviewed
Oct 26, 2022
View reviewed changes
@radicalradical
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incomplete review, just sharing some comments.
Comment threadsrc/mono/mono/metadata/profiler.c
Comment threadsrc/mono/mono/metadata/profiler.c
Outdated

Comment threadsrc/mono/mono/profiler/browser.c
Outdated

Comment threadsrc/mono/wasm/build/WasmApp.Native.targets

This was referenced Oct 26, 2022

Closed


Closed

lambdageek
lambdageek
reviewed
Nov 1, 2022
View reviewed changes
@lambdageeklambdageek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except there seems to be some copy/paste errors in the invoke-cs methods
Comment threadsrc/mono/wasm/runtime/invoke-js.ts
Comment threadsrc/mono/wasm/runtime/invoke-cs.ts
vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets
vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/browser.h
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/wasm.proj
@lewing
lewing
merged commit 0e24ea7
into
dotnet:mainNov 1, 2022
radical added a commit
to radical/runtime
that referenced
this pull request
Nov 1, 2022
@radical
Revert "[wasm] browser profiler (dotnet#77449)"
2289b5b
This reverts commit 0e24ea7.
This breaks with v8 10.9.130 with:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
It works fine with older versions like `10.7.193` (current stable).
radical added a commit
that referenced
this pull request
Nov 2, 2022
@radical
Revert "[wasm] browser profiler (#77449)" (#77759)
d3a3eda
This reverts commit 0e24ea7.
It broke all the perf pipeline wasm builds. It happens with v8 `10.9.130`:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
- It works fine with older versions like `10.7.193` (current stable).
- It wasn't caught in the CI checks because those are using an older version of v8.
@pavelsavarapavelsavara
mentioned this pull request
Nov 2, 2022
 Merged

@radekdoulikradekdoulik
mentioned this pull request
Nov 2, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 1, 2022
@pavelsavara
pavelsavara
deleted the

wasm_browser_profiller

branch
September 2, 2024 15:29
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@lambdageeklambdageeklambdageek approved these changes
@directhexdirecthexAwaiting requested review from directhex
@marafmarafAwaiting requested review from marafmaraf is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar
@vargazvargazAwaiting requested review from vargaz
@radicalradicalAwaiting requested review from radical

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@pavelsavara@jakobbotsch@radical@lewing@vargaz@lambdageek

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[wasm] browser profiler - #77449
Merged
lewing merged 6 commits into
dotnet:mainfrom 
pavelsavara:wasm_browser_profiller
Nov 1, 2022
Merged
[wasm] browser profiler#77449
lewing merged 6 commits into
dotnet:mainfrom 
pavelsavara:wasm_browser_profiller
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Oct 25, 2022•

edited

Loading

Copy link


Copy Markdown

Member
reporting both interpreter, AOT and some Javascript calls directly to chrome dev tools via performance.measure()
Chrome
image
FireFox
image
Profiler
  • mono profiler infrastructure allows to register multiple profiler plugins. This an implementation of one of them.
  • is implemented in src\mono\mono\profiler\browser.c only for WASM platform
  • it registers method enter/leave events.
  • There is no filter for the methods, so it would set flags and trigger for all managed methods.
  • it calls out into browser profiler via performance.measureAPI
  • interp is always calling the profiler callback, when installed
  • AOT compiler will emit icall to profiler for each flagged method

    • this means that profiler is running as part of JIT process in the AOT compiler.
  • JavaScript code of startup and interop methods are annotated
Usage
<PropertyGroup>
<WasmProfilers>browser;</WasmProfilers>
</PropertyGroup>

And
await dotnet
.withConfig({
browserProfilerOptions: {}
})
.run()

And start profiling in browser dev tools
Notes
  • alternatively we could implement plugin into EventPipe, which is itself mono profiler plugin. This solution is simpler.
  • when enabled: simple wasm to js call per event, method name building on first call to a method
  • no runtime overhead when not enabled in user project. Just some bytes for the new code in wasm.
Future work
  • enable method filtering by name, namespace, ...
  • max depth
  • start and end time
  • start and end method
  • report GC events and class loading and config to enable/disable it
Changes
  • new profiler browser.c
  • JS startup annotation
  • new static module libmono-profiler-browser.a it is always linked into dotnet.wasm in both Debug and Release configurations
  • profiler statically linked into AOT compiler on WASM target
  • updated advanced sample to enable profiler
  • cache for method names on JS side
  • fix for MonoAOTCompiler build task to pass --profiler argument to AOT compiler
Contributes to #76316
@pavelsavarapavelsavara
added this to the 8.0.0 milestone
Oct 25, 2022
@pavelsavarapavelsavara
self-assigned this
Oct 25, 2022
@ghost
ghost
commented
Oct 25, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:pavelsavara
Assignees:pavelsavara
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:8.0.0
pavelsavara
pavelsavara
commented
Oct 25, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/CMakeLists.txt
Outdated

@pavelsavara

This comment was marked as resolved.

Sign in to view
@jakobbotsch

This comment was marked as resolved.

Sign in to view
@pavelsavarapavelsavara
changed the title
[wasm] browser profiller[wasm] browser profilerOct 25, 2022

This was referenced Oct 25, 2022

Closed


Closed

@pavelsavara
pavelsavaraforce-pushed
the
wasm_browser_profiller
branch
from
16b5ee6 to
1df3637CompareOctober 25, 2022 22:15
@pavelsavarapavelsavara
mentioned this pull request
Oct 26, 2022
 Closed

@pavelsavara
pavelsavara
marked this pull request as ready for review
October 26, 2022 16:39
radical
radical
reviewed
Oct 26, 2022
View reviewed changes
@radicalradical
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incomplete review, just sharing some comments.
Comment threadsrc/mono/mono/metadata/profiler.c
Comment threadsrc/mono/mono/metadata/profiler.c
Outdated

Comment threadsrc/mono/mono/profiler/browser.c
Outdated

Comment threadsrc/mono/wasm/build/WasmApp.Native.targets

This was referenced Oct 26, 2022

Closed


Closed

lambdageek
lambdageek
reviewed
Nov 1, 2022
View reviewed changes
@lambdageeklambdageek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except there seems to be some copy/paste errors in the invoke-cs methods
Comment threadsrc/mono/wasm/runtime/invoke-js.ts
Comment threadsrc/mono/wasm/runtime/invoke-cs.ts
vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets
vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/browser.h
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/wasm.proj
@lewing
lewing
merged commit 0e24ea7
into
dotnet:mainNov 1, 2022
radical added a commit
to radical/runtime
that referenced
this pull request
Nov 1, 2022
@radical
Revert "[wasm] browser profiler (dotnet#77449)"
2289b5b
This reverts commit 0e24ea7.
This breaks with v8 10.9.130 with:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
It works fine with older versions like `10.7.193` (current stable).
radical added a commit
that referenced
this pull request
Nov 2, 2022
@radical
Revert "[wasm] browser profiler (#77449)" (#77759)
d3a3eda
This reverts commit 0e24ea7.
It broke all the perf pipeline wasm builds. It happens with v8 `10.9.130`:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
- It works fine with older versions like `10.7.193` (current stable).
- It wasn't caught in the CI checks because those are using an older version of v8.
@pavelsavarapavelsavara
mentioned this pull request
Nov 2, 2022
 Merged

@radekdoulikradekdoulik
mentioned this pull request
Nov 2, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 1, 2022
@pavelsavara
pavelsavara
deleted the

wasm_browser_profiller

branch
September 2, 2024 15:29
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@lambdageeklambdageeklambdageek approved these changes
@directhexdirecthexAwaiting requested review from directhex
@marafmarafAwaiting requested review from marafmaraf is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar
@vargazvargazAwaiting requested review from vargaz
@radicalradicalAwaiting requested review from radical

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@pavelsavara@jakobbotsch@radical@lewing@vargaz@lambdageek

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[wasm] browser profiler - #77449
Merged
lewing merged 6 commits into
dotnet:mainfrom 
pavelsavara:wasm_browser_profiller
Nov 1, 2022
Merged
[wasm] browser profiler#77449
lewing merged 6 commits into
dotnet:mainfrom 
pavelsavara:wasm_browser_profiller
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Oct 25, 2022•

edited

Loading

Copy link


Copy Markdown

Member
reporting both interpreter, AOT and some Javascript calls directly to chrome dev tools via performance.measure()
Chrome
image
FireFox
image
Profiler
  • mono profiler infrastructure allows to register multiple profiler plugins. This an implementation of one of them.
  • is implemented in src\mono\mono\profiler\browser.c only for WASM platform
  • it registers method enter/leave events.
  • There is no filter for the methods, so it would set flags and trigger for all managed methods.
  • it calls out into browser profiler via performance.measureAPI
  • interp is always calling the profiler callback, when installed
  • AOT compiler will emit icall to profiler for each flagged method

    • this means that profiler is running as part of JIT process in the AOT compiler.
  • JavaScript code of startup and interop methods are annotated
Usage
<PropertyGroup>
<WasmProfilers>browser;</WasmProfilers>
</PropertyGroup>

And
await dotnet
.withConfig({
browserProfilerOptions: {}
})
.run()

And start profiling in browser dev tools
Notes
  • alternatively we could implement plugin into EventPipe, which is itself mono profiler plugin. This solution is simpler.
  • when enabled: simple wasm to js call per event, method name building on first call to a method
  • no runtime overhead when not enabled in user project. Just some bytes for the new code in wasm.
Future work
  • enable method filtering by name, namespace, ...
  • max depth
  • start and end time
  • start and end method
  • report GC events and class loading and config to enable/disable it
Changes
  • new profiler browser.c
  • JS startup annotation
  • new static module libmono-profiler-browser.a it is always linked into dotnet.wasm in both Debug and Release configurations
  • profiler statically linked into AOT compiler on WASM target
  • updated advanced sample to enable profiler
  • cache for method names on JS side
  • fix for MonoAOTCompiler build task to pass --profiler argument to AOT compiler
Contributes to #76316
@pavelsavarapavelsavara
added this to the 8.0.0 milestone
Oct 25, 2022
@pavelsavarapavelsavara
self-assigned this
Oct 25, 2022
@ghost
ghost
commented
Oct 25, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:pavelsavara
Assignees:pavelsavara
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:8.0.0
pavelsavara
pavelsavara
commented
Oct 25, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/CMakeLists.txt
Outdated

@pavelsavara

This comment was marked as resolved.

Sign in to view
@jakobbotsch

This comment was marked as resolved.

Sign in to view
@pavelsavarapavelsavara
changed the title
[wasm] browser profiller[wasm] browser profilerOct 25, 2022

This was referenced Oct 25, 2022

Closed


Closed

@pavelsavara
pavelsavaraforce-pushed
the
wasm_browser_profiller
branch
from
16b5ee6 to
1df3637CompareOctober 25, 2022 22:15
@pavelsavarapavelsavara
mentioned this pull request
Oct 26, 2022
 Closed

@pavelsavara
pavelsavara
marked this pull request as ready for review
October 26, 2022 16:39
radical
radical
reviewed
Oct 26, 2022
View reviewed changes
@radicalradical
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incomplete review, just sharing some comments.
Comment threadsrc/mono/mono/metadata/profiler.c
Comment threadsrc/mono/mono/metadata/profiler.c
Outdated

Comment threadsrc/mono/mono/profiler/browser.c
Outdated

Comment threadsrc/mono/wasm/build/WasmApp.Native.targets

This was referenced Oct 26, 2022

Closed


Closed

lambdageek
lambdageek
reviewed
Nov 1, 2022
View reviewed changes
@lambdageeklambdageek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except there seems to be some copy/paste errors in the invoke-cs methods
Comment threadsrc/mono/wasm/runtime/invoke-js.ts
Comment threadsrc/mono/wasm/runtime/invoke-cs.ts
vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets
vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/browser.h
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/wasm.proj
@lewing
lewing
merged commit 0e24ea7
into
dotnet:mainNov 1, 2022
radical added a commit
to radical/runtime
that referenced
this pull request
Nov 1, 2022
@radical
Revert "[wasm] browser profiler (dotnet#77449)"
2289b5b
This reverts commit 0e24ea7.
This breaks with v8 10.9.130 with:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
It works fine with older versions like `10.7.193` (current stable).
radical added a commit
that referenced
this pull request
Nov 2, 2022
@radical
Revert "[wasm] browser profiler (#77449)" (#77759)
d3a3eda
This reverts commit 0e24ea7.
It broke all the perf pipeline wasm builds. It happens with v8 `10.9.130`:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
- It works fine with older versions like `10.7.193` (current stable).
- It wasn't caught in the CI checks because those are using an older version of v8.
@pavelsavarapavelsavara
mentioned this pull request
Nov 2, 2022
 Merged

@radekdoulikradekdoulik
mentioned this pull request
Nov 2, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 1, 2022
@pavelsavara
pavelsavara
deleted the

wasm_browser_profiller

branch
September 2, 2024 15:29
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@lambdageeklambdageeklambdageek approved these changes
@directhexdirecthexAwaiting requested review from directhex
@marafmarafAwaiting requested review from marafmaraf is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar
@vargazvargazAwaiting requested review from vargaz
@radicalradicalAwaiting requested review from radical

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@pavelsavara@jakobbotsch@radical@lewing@vargaz@lambdageek

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[wasm] browser profiler - #77449
Merged
lewing merged 6 commits into
dotnet:mainfrom 
pavelsavara:wasm_browser_profiller
Nov 1, 2022
Merged
[wasm] browser profiler#77449
lewing merged 6 commits into
dotnet:mainfrom 
pavelsavara:wasm_browser_profiller
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Oct 25, 2022•

edited

Loading

Copy link


Copy Markdown

Member
reporting both interpreter, AOT and some Javascript calls directly to chrome dev tools via performance.measure()
Chrome
image
FireFox
image
Profiler
  • mono profiler infrastructure allows to register multiple profiler plugins. This an implementation of one of them.
  • is implemented in src\mono\mono\profiler\browser.c only for WASM platform
  • it registers method enter/leave events.
  • There is no filter for the methods, so it would set flags and trigger for all managed methods.
  • it calls out into browser profiler via performance.measureAPI
  • interp is always calling the profiler callback, when installed
  • AOT compiler will emit icall to profiler for each flagged method

    • this means that profiler is running as part of JIT process in the AOT compiler.
  • JavaScript code of startup and interop methods are annotated
Usage
<PropertyGroup>
<WasmProfilers>browser;</WasmProfilers>
</PropertyGroup>

And
await dotnet
.withConfig({
browserProfilerOptions: {}
})
.run()

And start profiling in browser dev tools
Notes
  • alternatively we could implement plugin into EventPipe, which is itself mono profiler plugin. This solution is simpler.
  • when enabled: simple wasm to js call per event, method name building on first call to a method
  • no runtime overhead when not enabled in user project. Just some bytes for the new code in wasm.
Future work
  • enable method filtering by name, namespace, ...
  • max depth
  • start and end time
  • start and end method
  • report GC events and class loading and config to enable/disable it
Changes
  • new profiler browser.c
  • JS startup annotation
  • new static module libmono-profiler-browser.a it is always linked into dotnet.wasm in both Debug and Release configurations
  • profiler statically linked into AOT compiler on WASM target
  • updated advanced sample to enable profiler
  • cache for method names on JS side
  • fix for MonoAOTCompiler build task to pass --profiler argument to AOT compiler
Contributes to #76316
@pavelsavarapavelsavara
added this to the 8.0.0 milestone
Oct 25, 2022
@pavelsavarapavelsavara
self-assigned this
Oct 25, 2022
@ghost
ghost
commented
Oct 25, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:pavelsavara
Assignees:pavelsavara
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:8.0.0
pavelsavara
pavelsavara
commented
Oct 25, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/CMakeLists.txt
Outdated

@pavelsavara

This comment was marked as resolved.

Sign in to view
@jakobbotsch

This comment was marked as resolved.

Sign in to view
@pavelsavarapavelsavara
changed the title
[wasm] browser profiller[wasm] browser profilerOct 25, 2022

This was referenced Oct 25, 2022

Closed


Closed

@pavelsavara
pavelsavaraforce-pushed
the
wasm_browser_profiller
branch
from
16b5ee6 to
1df3637CompareOctober 25, 2022 22:15
@pavelsavarapavelsavara
mentioned this pull request
Oct 26, 2022
 Closed

@pavelsavara
pavelsavara
marked this pull request as ready for review
October 26, 2022 16:39
radical
radical
reviewed
Oct 26, 2022
View reviewed changes
@radicalradical
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incomplete review, just sharing some comments.
Comment threadsrc/mono/mono/metadata/profiler.c
Comment threadsrc/mono/mono/metadata/profiler.c
Outdated

Comment threadsrc/mono/mono/profiler/browser.c
Outdated

Comment threadsrc/mono/wasm/build/WasmApp.Native.targets

This was referenced Oct 26, 2022

Closed


Closed

lambdageek
lambdageek
reviewed
Nov 1, 2022
View reviewed changes
@lambdageeklambdageek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except there seems to be some copy/paste errors in the invoke-cs methods
Comment threadsrc/mono/wasm/runtime/invoke-js.ts
Comment threadsrc/mono/wasm/runtime/invoke-cs.ts
vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets
vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/browser.h
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/wasm.proj
@lewing
lewing
merged commit 0e24ea7
into
dotnet:mainNov 1, 2022
radical added a commit
to radical/runtime
that referenced
this pull request
Nov 1, 2022
@radical
Revert "[wasm] browser profiler (dotnet#77449)"
2289b5b
This reverts commit 0e24ea7.
This breaks with v8 10.9.130 with:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
It works fine with older versions like `10.7.193` (current stable).
radical added a commit
that referenced
this pull request
Nov 2, 2022
@radical
Revert "[wasm] browser profiler (#77449)" (#77759)
d3a3eda
This reverts commit 0e24ea7.
It broke all the perf pipeline wasm builds. It happens with v8 `10.9.130`:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
- It works fine with older versions like `10.7.193` (current stable).
- It wasn't caught in the CI checks because those are using an older version of v8.
@pavelsavarapavelsavara
mentioned this pull request
Nov 2, 2022
 Merged

@radekdoulikradekdoulik
mentioned this pull request
Nov 2, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 1, 2022
@pavelsavara
pavelsavara
deleted the

wasm_browser_profiller

branch
September 2, 2024 15:29
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@lambdageeklambdageeklambdageek approved these changes
@directhexdirecthexAwaiting requested review from directhex
@marafmarafAwaiting requested review from marafmaraf is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar
@vargazvargazAwaiting requested review from vargaz
@radicalradicalAwaiting requested review from radical

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@pavelsavara@jakobbotsch@radical@lewing@vargaz@lambdageek

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[wasm] browser profiler - #77449
Merged
lewing merged 6 commits into
dotnet:mainfrom 
pavelsavara:wasm_browser_profiller
Nov 1, 2022
Merged
[wasm] browser profiler#77449
lewing merged 6 commits into
dotnet:mainfrom 
pavelsavara:wasm_browser_profiller
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Oct 25, 2022•

edited

Loading

Copy link


Copy Markdown

Member
reporting both interpreter, AOT and some Javascript calls directly to chrome dev tools via performance.measure()
Chrome
image
FireFox
image
Profiler
  • mono profiler infrastructure allows to register multiple profiler plugins. This an implementation of one of them.
  • is implemented in src\mono\mono\profiler\browser.c only for WASM platform
  • it registers method enter/leave events.
  • There is no filter for the methods, so it would set flags and trigger for all managed methods.
  • it calls out into browser profiler via performance.measureAPI
  • interp is always calling the profiler callback, when installed
  • AOT compiler will emit icall to profiler for each flagged method

    • this means that profiler is running as part of JIT process in the AOT compiler.
  • JavaScript code of startup and interop methods are annotated
Usage
<PropertyGroup>
<WasmProfilers>browser;</WasmProfilers>
</PropertyGroup>

And
await dotnet
.withConfig({
browserProfilerOptions: {}
})
.run()

And start profiling in browser dev tools
Notes
  • alternatively we could implement plugin into EventPipe, which is itself mono profiler plugin. This solution is simpler.
  • when enabled: simple wasm to js call per event, method name building on first call to a method
  • no runtime overhead when not enabled in user project. Just some bytes for the new code in wasm.
Future work
  • enable method filtering by name, namespace, ...
  • max depth
  • start and end time
  • start and end method
  • report GC events and class loading and config to enable/disable it
Changes
  • new profiler browser.c
  • JS startup annotation
  • new static module libmono-profiler-browser.a it is always linked into dotnet.wasm in both Debug and Release configurations
  • profiler statically linked into AOT compiler on WASM target
  • updated advanced sample to enable profiler
  • cache for method names on JS side
  • fix for MonoAOTCompiler build task to pass --profiler argument to AOT compiler
Contributes to #76316
@pavelsavarapavelsavara
added this to the 8.0.0 milestone
Oct 25, 2022
@pavelsavarapavelsavara
self-assigned this
Oct 25, 2022
@ghost
ghost
commented
Oct 25, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:pavelsavara
Assignees:pavelsavara
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:8.0.0
pavelsavara
pavelsavara
commented
Oct 25, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/CMakeLists.txt
Outdated

@pavelsavara

This comment was marked as resolved.

Sign in to view
@jakobbotsch

This comment was marked as resolved.

Sign in to view
@pavelsavarapavelsavara
changed the title
[wasm] browser profiller[wasm] browser profilerOct 25, 2022

This was referenced Oct 25, 2022

Closed


Closed

@pavelsavara
pavelsavaraforce-pushed
the
wasm_browser_profiller
branch
from
16b5ee6 to
1df3637CompareOctober 25, 2022 22:15
@pavelsavarapavelsavara
mentioned this pull request
Oct 26, 2022
 Closed

@pavelsavara
pavelsavara
marked this pull request as ready for review
October 26, 2022 16:39
radical
radical
reviewed
Oct 26, 2022
View reviewed changes
@radicalradical
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incomplete review, just sharing some comments.
Comment threadsrc/mono/mono/metadata/profiler.c
Comment threadsrc/mono/mono/metadata/profiler.c
Outdated

Comment threadsrc/mono/mono/profiler/browser.c
Outdated

Comment threadsrc/mono/wasm/build/WasmApp.Native.targets

This was referenced Oct 26, 2022

Closed


Closed

lambdageek
lambdageek
reviewed
Nov 1, 2022
View reviewed changes
@lambdageeklambdageek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except there seems to be some copy/paste errors in the invoke-cs methods
Comment threadsrc/mono/wasm/runtime/invoke-js.ts
Comment threadsrc/mono/wasm/runtime/invoke-cs.ts
vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets
vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/browser.h
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/wasm.proj
@lewing
lewing
merged commit 0e24ea7
into
dotnet:mainNov 1, 2022
radical added a commit
to radical/runtime
that referenced
this pull request
Nov 1, 2022
@radical
Revert "[wasm] browser profiler (dotnet#77449)"
2289b5b
This reverts commit 0e24ea7.
This breaks with v8 10.9.130 with:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
It works fine with older versions like `10.7.193` (current stable).
radical added a commit
that referenced
this pull request
Nov 2, 2022
@radical
Revert "[wasm] browser profiler (#77449)" (#77759)
d3a3eda
This reverts commit 0e24ea7.
It broke all the perf pipeline wasm builds. It happens with v8 `10.9.130`:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
- It works fine with older versions like `10.7.193` (current stable).
- It wasn't caught in the CI checks because those are using an older version of v8.
@pavelsavarapavelsavara
mentioned this pull request
Nov 2, 2022
 Merged

@radekdoulikradekdoulik
mentioned this pull request
Nov 2, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 1, 2022
@pavelsavara
pavelsavara
deleted the

wasm_browser_profiller

branch
September 2, 2024 15:29
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@lambdageeklambdageeklambdageek approved these changes
@directhexdirecthexAwaiting requested review from directhex
@marafmarafAwaiting requested review from marafmaraf is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar
@vargazvargazAwaiting requested review from vargaz
@radicalradicalAwaiting requested review from radical

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@pavelsavara@jakobbotsch@radical@lewing@vargaz@lambdageek

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[wasm] browser profiler - #77449
Merged
lewing merged 6 commits into
dotnet:mainfrom 
pavelsavara:wasm_browser_profiller
Nov 1, 2022
Merged
[wasm] browser profiler#77449
lewing merged 6 commits into
dotnet:mainfrom 
pavelsavara:wasm_browser_profiller
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Oct 25, 2022•

edited

Loading

Copy link


Copy Markdown

Member
reporting both interpreter, AOT and some Javascript calls directly to chrome dev tools via performance.measure()
Chrome
image
FireFox
image
Profiler
  • mono profiler infrastructure allows to register multiple profiler plugins. This an implementation of one of them.
  • is implemented in src\mono\mono\profiler\browser.c only for WASM platform
  • it registers method enter/leave events.
  • There is no filter for the methods, so it would set flags and trigger for all managed methods.
  • it calls out into browser profiler via performance.measureAPI
  • interp is always calling the profiler callback, when installed
  • AOT compiler will emit icall to profiler for each flagged method

    • this means that profiler is running as part of JIT process in the AOT compiler.
  • JavaScript code of startup and interop methods are annotated
Usage
<PropertyGroup>
<WasmProfilers>browser;</WasmProfilers>
</PropertyGroup>

And
await dotnet
.withConfig({
browserProfilerOptions: {}
})
.run()

And start profiling in browser dev tools
Notes
  • alternatively we could implement plugin into EventPipe, which is itself mono profiler plugin. This solution is simpler.
  • when enabled: simple wasm to js call per event, method name building on first call to a method
  • no runtime overhead when not enabled in user project. Just some bytes for the new code in wasm.
Future work
  • enable method filtering by name, namespace, ...
  • max depth
  • start and end time
  • start and end method
  • report GC events and class loading and config to enable/disable it
Changes
  • new profiler browser.c
  • JS startup annotation
  • new static module libmono-profiler-browser.a it is always linked into dotnet.wasm in both Debug and Release configurations
  • profiler statically linked into AOT compiler on WASM target
  • updated advanced sample to enable profiler
  • cache for method names on JS side
  • fix for MonoAOTCompiler build task to pass --profiler argument to AOT compiler
Contributes to #76316
@pavelsavarapavelsavara
added this to the 8.0.0 milestone
Oct 25, 2022
@pavelsavarapavelsavara
self-assigned this
Oct 25, 2022
@ghost
ghost
commented
Oct 25, 2022

Copy link


Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:pavelsavara
Assignees:pavelsavara
Labels:
arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone:8.0.0
pavelsavara
pavelsavara
commented
Oct 25, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/CMakeLists.txt
Outdated

@pavelsavara

This comment was marked as resolved.

Sign in to view
@jakobbotsch

This comment was marked as resolved.

Sign in to view
@pavelsavarapavelsavara
changed the title
[wasm] browser profiller[wasm] browser profilerOct 25, 2022

This was referenced Oct 25, 2022

Closed


Closed

@pavelsavara
pavelsavaraforce-pushed
the
wasm_browser_profiller
branch
from
16b5ee6 to
1df3637CompareOctober 25, 2022 22:15
@pavelsavarapavelsavara
mentioned this pull request
Oct 26, 2022
 Closed

@pavelsavara
pavelsavara
marked this pull request as ready for review
October 26, 2022 16:39
radical
radical
reviewed
Oct 26, 2022
View reviewed changes
@radicalradical
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incomplete review, just sharing some comments.
Comment threadsrc/mono/mono/metadata/profiler.c
Comment threadsrc/mono/mono/metadata/profiler.c
Outdated

Comment threadsrc/mono/mono/profiler/browser.c
Outdated

Comment threadsrc/mono/wasm/build/WasmApp.Native.targets

This was referenced Oct 26, 2022

Closed


Closed

lambdageek
lambdageek
reviewed
Nov 1, 2022
View reviewed changes
@lambdageeklambdageek
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except there seems to be some copy/paste errors in the invoke-cs methods
Comment threadsrc/mono/wasm/runtime/invoke-js.ts
Comment threadsrc/mono/wasm/runtime/invoke-cs.ts
vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/build/WasmApp.Native.targets
vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/runtime/driver.c
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/mono/profiler/browser.h
Outdated

vargaz
vargaz
reviewed
Nov 1, 2022
View reviewed changes
Comment threadsrc/mono/wasm/wasm.proj
@lewing
lewing
merged commit 0e24ea7
into
dotnet:mainNov 1, 2022
radical added a commit
to radical/runtime
that referenced
this pull request
Nov 1, 2022
@radical
Revert "[wasm] browser profiler (dotnet#77449)"
2289b5b
This reverts commit 0e24ea7.
This breaks with v8 10.9.130 with:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
It works fine with older versions like `10.7.193` (current stable).
radical added a commit
that referenced
this pull request
Nov 2, 2022
@radical
Revert "[wasm] browser profiler (#77449)" (#77759)
d3a3eda
This reverts commit 0e24ea7.
It broke all the perf pipeline wasm builds. It happens with v8 `10.9.130`:
```
Error: Invalid 'startMark' argument: No numeric 'startTime' field
at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994)
at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874
exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field
```
- It works fine with older versions like `10.7.193` (current stable).
- It wasn't caught in the CI checks because those are using an older version of v8.
@pavelsavarapavelsavara
mentioned this pull request
Nov 2, 2022
 Merged

@radekdoulikradekdoulik
mentioned this pull request
Nov 2, 2022

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Dec 1, 2022
@pavelsavara
pavelsavara
deleted the

wasm_browser_profiller

branch
September 2, 2024 15:29
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes
@lambdageeklambdageeklambdageek approved these changes
@directhexdirecthexAwaiting requested review from directhex
@marafmarafAwaiting requested review from marafmaraf is a code owner
@BrzVladBrzVladAwaiting requested review from BrzVladBrzVlad is a code owner
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar
@vargazvargazAwaiting requested review from vargaz
@radicalradicalAwaiting requested review from radical

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects


None yet


Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@pavelsavara@jakobbotsch@radical@lewing@vargaz@lambdageek