Uh oh!
There was an error while loading. Please reload this page.
Remove the invalid assert - #77462
Merged
Merged
Conversation
ghost
commented
Oct 26, 2022
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsRecently we had the change to enable calling the method
|
maryamariyan
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#77451
Recently we had the change to enable calling the method
CalendarData.GetTwoDigitYearMaxwhen running withICUmode. This method was asserting it is running onNLSmode which is not valid assertion any more. The change here is to remove the wrong assert to avoid firing in the debug builds.