Skip to content

[wasm][debugger] Fixing when trying to call mono functions in a non wasm page - #77496

Merged
thaystg merged 2 commits into
dotnet:mainfrom
thaystg:thays_fix_68402
Oct 28, 2022
Merged

[wasm][debugger] Fixing when trying to call mono functions in a non wasm page#77496
thaystg merged 2 commits into
dotnet:mainfrom
thaystg:thays_fix_68402

Conversation

@thaystg

Copy link
Copy Markdown
Member

I think this will probably fix:

#77013
#68402

After trying a lot to reproduce I realized that on RuntimeReady method, the ClearAllBreakpoints works, but when we try to run the next command on the wasm page, which is the SetProtocolVersion, it's not a wasm page anymore then it throws the exception. In the PR I'm protecting all the messages sent on RuntimeReady, because it's expected an exception there if it's not a wasm page.

@thaystg
thaystg requested a review from radical as a code ownerOctober 26, 2022 16:25
@ghostghost assigned thaystgOct 26, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

I think this will probably fix:

#77013
#68402

After trying a lot to reproduce I realized that on RuntimeReady method, the ClearAllBreakpoints works, but when we try to run the next command on the wasm page, which is the SetProtocolVersion, it's not a wasm page anymore then it throws the exception. In the PR I'm protecting all the messages sent on RuntimeReady, because it's expected an exception there if it's not a wasm page.

Author:thaystg
Assignees:thaystg
Labels:

area-Debugger-mono

Milestone:-

Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
@thaystg

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3331696964

@thaystg
thaystg merged commit 24cb35e into dotnet:mainOct 28, 2022
@ghostghost locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@thaystg@radical