Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Pass TargetRid and SourceBuildNonPortable to the native scripts (backport of #74504) - #77508
Conversation
ghost
commented
Oct 26, 2022
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
commented
Oct 27, 2022
Tagging subscribers to this area: @hoyosjs |
a84dad2 to
2efe605Comparecarlossanlop
commented
Nov 3, 2022
@jkoritzinsky@MichaelSimons I see you approved the |
carlossanlop
commented
Nov 3, 2022
Actually, this is an infra change only. We just need a code review sign off from one or either of you, @jkoritzinsky@MichaelSimons. @ViktorHofer too, if possible. |
ViktorHofer
commented
Nov 3, 2022
@tmds, do you remember if there's also a change required in Arcade for these set of changes? |
ViktorHofer
commented
Nov 3, 2022
Something must be missing here: |
There's a patch somewhere that should be adding the AdditionalRuntimeIdentifier to runtime graph. Maybe it hasn't been backported yet? I think it was an installer level change edit right, I suspect it's this #77510. Now that it's merged, I've rebased. |
2efe605 to
bef1255Compareayakael
commented
Nov 3, 2022
The rebase didn't work, there's some code missing somewhere for RIDs in AdditionalRuntimeIdentifier. I think it was implemented in source-build somewhere, so it might be an installer backport that needs doing. @tmds does this ring any bells? |
tmds
commented
Nov 4, 2022
This line is missing: Line 50 in 794f1af |
bef1255 to
454cb63Compareayakael
commented
Nov 5, 2022
@ViktorHofer With above fix, CI is green. |
ViktorHofer
commented
Nov 7, 2022
@carlossanlop can this be merged into release/6.0 or is the branch closed? |
carlossanlop
commented
Nov 7, 2022
We're on time. Infra change only (tell-mode). Signed off by area owner. No OOB package authoring changes needed. CI green. Ready to merge. |
Backport of #74504
Per @tmds:
Customer impact
Before this patch, additional RIDs would not properly flow down to runtime as
__DistroRidwould ignore previously set variables. This was problematic for source-build application, as every update we would have to update the RID graph, and porting to new distros would require modifyinginit-distro-rid.shto output the correct RID.Testing
Risk
Low, as it is already in
main, and only activates when these options are defined.