Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] source-build: support building runtime using non-portable runtime packages (backport of #75597) - #77509
Conversation
ghost
commented
Oct 26, 2022
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
carlossanlop
commented
Nov 3, 2022
@ViktorHofer I see you approved the |
Uh oh!
There was an error while loading. Please reload this page.
ViktorHofer
left a comment
There was a problem hiding this comment.
Apart from one nit change, LGTM
carlossanlop
commented
Nov 3, 2022
Two tests are failing with a nuget problem. @ViktorHofer@ayakael Is the failure related to this change?
|
f237988 to
58d0516Compareayakael
commented
Nov 4, 2022
I don't see how it could be related given that this change only expresses itself when |
58d0516 to
884c70dCompareghost
commented
Nov 7, 2022
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsBackport of #75597 Per @tmds Customer impactFor distro maintainers, this removes the need for providing portable runtime packages to build non-portable runtime, thus we do not need to build runtime twice. This reduces our build time significantly. Testing
RiskLow, as it is already in
|
ViktorHofer
commented
Nov 8, 2022
@carlossanlop can this change be merged into release/6.0? Is the branch already open? |
Backport of #75597
Per @tmds
Customer impact
For distro maintainers, this removes the need for providing portable runtime packages to build non-portable runtime, thus we do not need to build runtime twice. This reduces our build time significantly.
Testing
Risk
Low, as it is already in
main, and only activates whenDotNetBuildFromSource=true