Uh oh!
There was an error while loading. Please reload this page.
Disable ComInterfaceGenerator.Unit.Tests for NativeAOT - #77522
Conversation
MichalStrehovsky
commented
Oct 26, 2022
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MichalStrehovsky
commented
Oct 27, 2022
I'm also blocking ComInterfaceGenerator.Tests because DNNE doesn't work. Cc @dotnet/interop-contrib - we won't have any NativeAOT coverage for this unless a non-DNNE fallback is added. |
MichalStrehovsky
commented
Oct 27, 2022
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AaronRobinsonMSFT
commented
Oct 27, 2022
I don't understand why DNNE doesn't work in this case. If the test is NativeAOT, DNNE should be able to load an instance of the runtime and carry on. Is understanding why that is failing in NativeAOT the issue? |
MichalStrehovsky
commented
Oct 27, 2022
I didn't debug this but how does dnne find a CoreCLR runtime if there's no runtime loaded in the process? |
AaronRobinsonMSFT
commented
Oct 27, 2022
It uses the normal .NET hosting look up. In this case it uses the dropped |
MichalStrehovsky
commented
Oct 28, 2022
I don't think we have a globally installed .NET runtime when doing NativeAOT testing. Helix machines are unlikely to have it and we don't send anything in the payload either because we're testing NativeAOT. |
AaronRobinsonMSFT
commented
Oct 28, 2022
I see. What we might want to do then NativeAOT these assets instead of using DNNE for the NativeAOT scenario. This way we would get additional testing and since DNNE uses the same export tech as NativeAOT, I think it should just work. |
Fixes#77476.
The project is set up in an odd way and we miss a reference. This happens in a spot that is hard to be proactive about: the missing type is a generic argument and that's annoying to check for because it could lead to recursions that we're not ready to handle - e.g.
class Foo : IComparable<Foo>. We could fix that, but also the detection of broken inputs has its limits.Also, building a test that references Roslyn takes forever and source generator tests are unlikely to find runtime issues so I'm 100% comfortable not running this test ever.
Cc @dotnet/ilc-contrib