Uh oh!
There was an error while loading. Please reload this page.
[Release/7.0] Issue ICorProfiler ModuleLoadFinished callbacks for dynamic modules - #77533
Conversation
ghost
commented
Oct 27, 2022
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsBackport of #77068 to release/7.0 Customer ImpactIn 7.0 we introduced a regression where we do not issue ModuleLoadFinished callbacks for dynamic modules. ModuleLoadFinished is the opportunity for profilers to change metadata/IL in the target assembly. We have a customer reporting this as blocking in #76016 TestingCustomer tested that the scenario is fixed with a private build RiskLow, the fix is targeted and very few lines of code
|
ghost
commented
Oct 27, 2022
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #77068 to release/7.0 Customer ImpactIn 7.0 we introduced a regression where we do not issue ModuleLoadFinished callbacks for dynamic modules. ModuleLoadFinished is the opportunity for profilers to change metadata/IL in the target assembly. We have a customer reporting this as blocking in #76016 TestingCustomer tested that the scenario is fixed with a private build RiskLow, the fix is targeted and very few lines of code
|
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. please get a code review and we will take for consideration in 7.0.x
carlossanlop
commented
Nov 3, 2022
Approved by Tactics. |
Backport of #77068 to release/7.0
Customer Impact
In 7.0 we introduced a regression where we do not issue ModuleLoadFinished callbacks for dynamic modules. ModuleLoadFinished is the opportunity for profilers to change metadata/IL in the target assembly. We have a customer reporting this as blocking in #76016
Testing
Customer tested that the scenario is fixed with a private build
Risk
Low, the fix is targeted and very few lines of code