Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Free LOADERHANDLEDispatchMemberInfo dtor - #77570
Merged
Conversation
This is a regression from NETFX with the introduction of collectable assemblies in .NET Core 3.1 (dotnet/coreclr#20919).
jeffschwMSFT
approved these changes
Oct 27, 2022
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. please get a code review and we will take for consideration in 7.0.x
janvorli
approved these changes
Oct 27, 2022
carlossanlop
commented
Nov 3, 2022
Contributor
Approved by Tactics. Signed off. No OOB package authoring changes needed. |
carlossanlop
commented
Nov 3, 2022
Contributor
CI green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #77554 to release/7.0
/cc @AaronRobinsonMSFT
Customer Impact
This is a customer reported issue - #76350. The leak was introduced in .NET Core 3.1 and has gone unreported since then. This is specifically for the
IReflectscenario, which is mostly related to classIDispatchCOM interop scenarios.Although this impacts previous .NET runtimes, the OP has created a workaround and is not specifically asking for fixes prior to .NET 7.
Testing
Manually validated the user scenario and made the surrounding code easier to reason about. Validation was done using the Visual Studio Diagnostic tools for memory allocations.
Risk
Limited. This is for a relatively uncommon .NET Core scenario. The issue has existed since .NET Core 3.1 without being reported and the fix is scoped to only impact that particular scenario.