Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] [wasm][debugger] Never send messages from our internal protocol extensions to the browser - #77620
Merged
Conversation
ghost
commented
Oct 28, 2022
Tagging subscribers to this area: @thaystg Issue DetailsBackport of #77616 to release/6.0 /cc @thaystg Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
radical
approved these changes
Oct 28, 2022
carlossanlop
commented
Nov 3, 2022
Contributor
@thaystg I see this was approved for 7.0 via email, but I don't see it was approved for 6.0. Can you please confirm it's approved for 6.0 as well? |
thaystg
commented
Nov 3, 2022
MemberAuthor
The CI failures are unrelated. |
carlossanlop
commented
Nov 3, 2022
Contributor
Thanks. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #77616 to release/6.0
/cc @thaystg
Customer Impact
Messages like this are printed in the console:
fail: Microsoft.WebAssembly.Diagnostics.DevToolsProxy[0] sending error response for id: msg-B7CCCEF5694F2EF11713AE7F86743A45:::1017 -> [Result: IsOk: False, IsErr: True, Value: , Error: { "code": -32601, "message": "'DotnetDebugger.setDebuggerProperty' wasn't found" } ]Testing
Manually tested.
Risk
Low risk, In this PR we avoid sending DotnetDebugger.* commands that are our own extension, and unknown to the browser.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.