Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] [hot_reload] implement param reflection - #77734
Merged
Conversation
otherwise the CancellationToken type is trimmed on wasm
remove duplicated code
github-actionsBot
requested review from
lambdageek, marek-safar, thaystg and vargaz
as code ownersNovember 1, 2022 17:48
vargaz
approved these changes
Nov 1, 2022
carlossanlop
commented
Nov 3, 2022
Contributor
Approved by Tactics. Signed off by area owner. No OOB package authoring changes needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #77563 to release/7.0
/cc @lambdageek
Customer Impact
In .NET 7 we enabled mobile and WebAssembly users to use Hot Reload to add new functions to existing classes. In MAUI, this allows users to use XAML Hot Reload and C# Hot Reload together to create new elements and attach new event handlers to them in a running hot reload session. This PR fixes a crash when MAUI called the new added callbacks using reflection.
This PR enables a key scenario.
Testing
New CI tests. Manual verification that the PR addresses the MAUI crashes.
Risk
Low. All the new code is gated on a hot reload change being applied to the runtime. In other words, production apps will not run any of the modified code paths.