Skip to content

[release/7.0] Correct minimum memory size value from 200MB to 20MB - #77787

Merged
carlossanlop merged 1 commit into
release/7.0from
backport/pr-77682-to-release/7.0
Nov 11, 2022
Merged

[release/7.0] Correct minimum memory size value from 200MB to 20MB#77787
carlossanlop merged 1 commit into
release/7.0from
backport/pr-77682-to-release/7.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Backport of #77682 to release/7.0

/cc @akoeplinger@nealef

Customer Impact

Typo caused value to be 200MB instead of 20MB which caused an incorrect calculation of the cgroup minimum memory size. This prevented mono on s390x from observing memory limits when running inside containers.

Testing

CI testing.

Risk

Low.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@carlossanlop

carlossanlop commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

@akoeplinger@vargaz this needs to go through Tactics. Can one of you please fill out the template and send the email to request approval?

@carlossanlop

Copy link
Copy Markdown
Contributor

And when ready, please add the servicing-consider label.

@akoeplingerakoeplinger added this to the 7.0.x milestone Nov 7, 2022
@steveisoksteveisok added the Servicing-consider Issue for next servicing release review label Nov 7, 2022
@rbhandarbhanda modified the milestones: 7.0.x, 7.0.1Nov 10, 2022
@rbhandarbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 10, 2022
@carlossanlop

carlossanlop commented Nov 11, 2022

Copy link
Copy Markdown
Contributor

The re-run came mostly green. The only CI failure seems to be an unrelated nuget download problem with the following error, which I reported to FR, and I was told this is another instance of dotnet/arcade#10885 :

Response status code does not indicate success: 500 (Internal Server Error - Request was blocked due to exceeding usage of resource 'Concurrency' in namespace 'IPAddress'. For more information on why your request was blocked, see the topic "Rate limits" on the Microsoft Web site (https://go.microsoft.com/fwlink/?LinkId=823950). (DevOps Activity ID: F690A076-90B8-4339-B8EA-8E574E74539B)).

Aside from that: Signed off by area owner, approved by Tactics, no need for OOB package authoring changes. Ready to merge. :shipit:

@carlossanlop
carlossanlop merged commit e473891 into release/7.0Nov 11, 2022
@carlossanlop
carlossanlop deleted the backport/pr-77682-to-release/7.0 branch November 11, 2022 00:19
@ghostghost locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-VM-meta-monoServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@carlossanlop@vargaz@steveisok@akoeplinger@rbhanda@nealef