Skip to content

[release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzers - #77831

Merged
carlossanlop merged 10 commits into
release/7.0from
darc-release/7.0-88d4fa90-5b62-4f24-9b34-817e68929c2a
Nov 15, 2022
Merged

[release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzers#77831
carlossanlop merged 10 commits into
release/7.0from
darc-release/7.0-88d4fa90-5b62-4f24-9b34-817e68929c2a

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Nov 3, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime-assets

  • Subscription: 35e57660-6174-46f6-8166-08da7ef6284d
  • Build: 20221103.1
  • Date Produced: November 3, 2022 8:30:46 PM UTC
  • Commit: 0c78106337dbe19ce4dd99140636865cdc99d008
  • Branch: refs/heads/main

From https://github.com/dotnet/roslyn-analyzers

  • Subscription: a8b74935-5a68-4a8e-b089-08da7ef6355d
  • Build: 20221109.1
  • Date Produced: November 9, 2022 9:39:38 AM UTC
  • Commit: 31373ce8529c3d2f6b91e61585872160b0d7d7cd
  • Branch: refs/heads/main

From https://github.com/dotnet/llvm-project

  • Subscription: dc7edec6-2e27-40ef-139c-08da7ef5fa55
  • Build: 20221106.1
  • Date Produced: November 7, 2022 6:28:07 AM UTC
  • Commit: e528bb7104ae6bcd36e81141f899d0229d99c5e5
  • Branch: refs/heads/objwriter/release/7.0

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
03853e7
…ld 20221102.2
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 7.0.0-beta.22531.1 -> To Version 7.0.0-beta.22552.2
@ghostghost added the area-codeflow for labeling automated codeflow label Nov 3, 2022
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslyn-analyzersb…
b9cac87
…uild 20221103.1
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.22551.1 -> To Version 7.0.0-preview1.22553.1
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/runtime-assets[release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzersNov 3, 2022
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/runtime-assetsbui…
cc383d7
…ld 20221103.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
From Version 7.0.0-beta.22531.1 -> To Version 7.0.0-beta.22553.1
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers[release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/runtime-assetsNov 4, 2022
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslyn-analyzersb…
cdc7fdb
…uild 20221103.2
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.22551.1 -> To Version 7.0.0-preview1.22553.2
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/runtime-assets[release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzersNov 4, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers[release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/runtime-assetsNov 5, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/runtime-assets[release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzersNov 5, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers[release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/runtime-assetsNov 6, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/runtime-assets[release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzersNov 6, 2022
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/llvm-projectbuild…
90c92b3
… 20221106.1
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.11.0-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
From Version 1.0.0-alpha.1.22510.4 -> To Version 1.0.0-alpha.1.22556.1
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers[release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-projectNov 7, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-project[release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzersNov 7, 2022
@build-analysisbuild-analysisBot mentioned this pull request Nov 7, 2022
Closed
@carlossanlop

carlossanlop commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

The staging failures are cancelled operations.

But the libraries failures are genuine. @ViktorHofer any idea why they could be happening?

artifacts\bin\testPackages\projects\System.Text.Json\project.csproj(0,0): error NU1102: (NETCORE_ENGINEERING_TELEMETRY=Build) Unable to find package System.Text.Encodings.Web with version (>= 7.0.0)
- Found 1560 version(s) in dotnet7 [ Nearest version: 7.0.0-rtm.22511.4 ]
- Found 68 version(s) in dotnet-public [ Nearest version: 7.0.0-rc.2.22472.3 ]
- Found 1 version(s) in dotnet-eng [ Nearest version: 5.0.0-alpha.1.19618.1 ]
- Found 1 version(s) in dotnet7-transport [ Nearest version: 7.0.0-rc.1.22426.10 ]
- Found 0 version(s) in D:\a\_work\1\s\artifacts\packages\Debug\
- Found 0 version(s) in richnav
- Found 0 version(s) in darc-pub-dotnet-emsdk-6b7d1f4-1
- Found 0 version(s) in darc-pub-dotnet-emsdk-6b7d1f4-2
- Found 0 version(s) in darc-pub-dotnet-emsdk-6b7d1f4-3
- Found 0 version(s) in darc-pub-dotnet-emsdk-6b7d1f4-4
- Found 0 version(s) in darc-pub-dotnet-emsdk-6b7d1f4-5
- Found 0 version(s) in darc-pub-dotnet-emsdk-6b7d1f4
- Found 0 version(s) in dotnet-libraries
- Found 0 version(s) in dotnet-tools

artifacts\bin\testPackages\projects\System.Text.Json\project.csproj(0,0): error NU1102: (NETCORE_ENGINEERING_TELEMETRY=Build) Unable to find package Microsoft.Bcl.AsyncInterfaces with version (>= 7.0.0)
- Found 1562 version(s) in dotnet7 [ Nearest version: 7.0.0-rtm.22511.4 ]
- Found 38 version(s) in dotnet-public [ Nearest version: 7.0.0-rc.2.22472.3 ]
- Found 1 version(s) in dotnet7-transport [ Nearest version: 7.0.0-rc.1.22426.10 ]
- Found 0 version(s) in D:\a\_work\1\s\artifacts\packages\Debug\
- Found 0 version(s) in richnav
- Found 0 version(s) in darc-pub-dotnet-emsdk-6b7d1f4-1
- Found 0 version(s) in darc-pub-dotnet-emsdk-6b7d1f4-2
- Found 0 version(s) in darc-pub-dotnet-emsdk-6b7d1f4-3
- Found 0 version(s) in darc-pub-dotnet-emsdk-6b7d1f4-4
- Found 0 version(s) in darc-pub-dotnet-emsdk-6b7d1f4-5
- Found 0 version(s) in darc-pub-dotnet-emsdk-6b7d1f4
- Found 0 version(s) in dotnet-eng
- Found 0 version(s) in dotnet-libraries
- Found 0 version(s) in dotnet-tools

@ViktorHofer

ViktorHofer commented Nov 7, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Yes, that error is expected. You are trying to build System.Text.Json/7.0.1 which depends on System.Text.Encodings.Web/7.0.0 and Microsoft.Bcl.AsyncInterfaces/7.0.0. As only the System.Text.Json packages gets created but not the dependencies, testPackages fails to resolve them. That's an actual error which tells you that you can't service something for which its dependencies aren't published anywhere yet.

TL;DR: You can't do incremental servicing before all dependencies have been published as part of the release.

@ViktorHofer

ViktorHofer commented Nov 8, 2022

Copy link
Copy Markdown
Member

This should now be unblocked as packages are pushed to nuget.org. If it still fails, verify that the packages are also on the dotnet-public mirror feed.

@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzers[release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-projectNov 8, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-project[release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/runtime-assetsNov 8, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/runtime-assets[release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzersNov 8, 2022
@ViktorHofer

ViktorHofer commented Nov 8, 2022•
edited
Loading

Copy link
Copy Markdown
Member

While looking into this further, I found out that this PR didn't cause that issue. This actually regressed about five days ago when 12a44e9 and 7c2344a were merged in.

That's because the branding PR turned incremental servicing on but the build of the S.T.Json PR that introduced the first 7.0.1 package didn't run on top of the branding changes (because CI wasn't retriggered after the branding change was merged).

We shouldn't see this issue anymore as the 7.0.0 packages are now available on nuget.org.

@carlossanlop can you please update your notes and make sure that we retrigger PRs when an "RTM -> servicing" branding change happens?

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/llvm-projectbuild…
6f9e811
… 20221106.1
runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.11.0-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter
From Version 1.0.0-alpha.1.22510.4 -> To Version 1.0.0-alpha.1.22556.1
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzers[release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-projectNov 9, 2022
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/roslyn-analyzersb…
a658763
…uild 20221109.1
Microsoft.CodeAnalysis.NetAnalyzers
From Version 7.0.0-preview1.22551.1 -> To Version 7.0.0-preview1.22559.1
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-project[release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzersNov 9, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzers[release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-projectNov 10, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-project[release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/runtime-assetsNov 10, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/runtime-assets[release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzersNov 10, 2022
@build-analysisbuild-analysisBot mentioned this pull request Nov 10, 2022
Closed
@build-analysisbuild-analysisBot mentioned this pull request Nov 11, 2022
Closed
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzers[release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-projectNov 11, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-project[release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/runtime-assetsNov 11, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/runtime-assets[release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzersNov 11, 2022
@carlossanlop

carlossanlop commented Nov 11, 2022

Copy link
Copy Markdown
Contributor

Need to close and reopen because of the recent update of runtime-assets that's causing some tests depending on the new packages to fail.

@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzers[release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-projectNov 12, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-project[release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/runtime-assetsNov 12, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/runtime-assets[release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzersNov 12, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzers[release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-projectNov 13, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-project[release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/runtime-assetsNov 13, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/runtime-assets[release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzersNov 13, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzers[release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-projectNov 14, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/runtime-assets dotnet/roslyn-analyzers dotnet/llvm-project[release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/runtime-assetsNov 14, 2022
@dotnet-maestrodotnet-maestroBot changed the title [release/7.0] Update dependencies from dotnet/roslyn-analyzers dotnet/llvm-project dotnet/runtime-assets[release/7.0] Update dependencies from dotnet/llvm-project dotnet/runtime-assets dotnet/roslyn-analyzersNov 14, 2022
@carlossanlop

carlossanlop commented Nov 14, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

The System.Formats.Tar tests failures are weird. They are saying they cannot find the new docker-hello-world.tar file, yet we are consuming a version of runtime-assets that is supposed to include that asset already.

Edit: Found the root cause. Updating the asset folder path should fix it.

carlossanlop
carlossanlop approved these changes Nov 15, 2022
View reviewed changes

@carlossanlopcarlossanlop left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to merge now.
The Tar test failures are gone after the last commit's fix. The new failures are interminttent networking/infra problems, unrelated to the PR. The only test failure that is also known and unrelated is #75018
The llvmaot passed in the last CI run, and the last commit does not affect it.

@carlossanlop
carlossanlop merged commit 16c42a4 into release/7.0Nov 15, 2022
@carlossanlop
carlossanlop deleted the darc-release/7.0-88d4fa90-5b62-4f24-9b34-817e68929c2a branch November 15, 2022 01:19
@ghostghost locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-codeflowfor labeling automated codeflow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlossanlop@ViktorHofer