Uh oh!
There was an error while loading. Please reload this page.
Remove "wprintf" from PAL - #77852
Merged
AaronRobinsonMSFT merged 4 commits intoNov 4, 2022
Merged
Conversation
The last usage was in FormatMessageW, which only used wprintf syntax for messages that used embeded printf format between two "!". We do not use this feature in any of our messages so this code path is technically unused.
_woutput_s was not removed because it is intertwined with the implementation for printf. The linker will just prune the implementation anyways. Remove all wprintf testing from PAL
AaronRobinsonMSFT
commented
Nov 3, 2022
MemberAuthor
am11
approved these changes
Nov 3, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
FormatMessageW errors if embedded formating is used Update PAL tests for FormatMessageW
This was referenced Nov 4, 2022
AaronRobinsonMSFT
commented
Nov 4, 2022
MemberAuthor
Issues are known and properly tagged above. |
radical added a commit
to radical/runtime
that referenced
this pull request
Nov 4, 2022
This completely broke `dotnet-runtime-perf` pipeline for wasm runs. This reverts commit 8036885. Issue: dotnet#77883
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last usage was in
FormatMessageW, whichonly used wprintf syntax for messages that used
embedded printf format between two "!". We do
not use this feature in any of our messages so
this code path is technically unused.
Remove
_snwprintf_sfrom PALRemove
_vsnwprintf_sfrom PAL_woutput_swas not removed because it is intertwinedwith the implementation for printf. The linker will just
prune the implementation anyways.
Remove all wprintf testing from PAL