Uh oh!
There was an error while loading. Please reload this page.
Add System.IO.Hashing ref csproj - #77856
Merged
Merged
Conversation
ghost
commented
Nov 3, 2022
Tagging subscribers to this area: @dotnet/area-system-io |
ghost
commented
Nov 3, 2022
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsFixes #77846
|
vcsjones
commented
Nov 3, 2022
Member
Most (all? I just did a few spot checks) things include the /ref project in the solution file. Should this be added to System.IO.Hashing.sln? |
2 tasks
This was referenced Nov 4, 2022
bartonjs
approved these changes
Nov 4, 2022
Uh oh!
There was an error while loading. Please reload this page.
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks> | ||
| <NoWarn>$(NoWarn);CS0809</NoWarn> |
Member
There was a problem hiding this comment.
nit: add an xml comment to explain why this NoWarn is required.
ViktorHofer
left a comment
Member
There was a problem hiding this comment.
LGTM aside from two comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#77846