Uh oh!
There was an error while loading. Please reload this page.
Fix Configuration with IList and ICollection - #77857
Conversation
ghost
commented
Nov 3, 2022
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
tarekgh
commented
Nov 3, 2022
tarekgh
commented
Nov 3, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tarekgh
commented
Nov 7, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tarekgh
commented
Nov 9, 2022
All failures in CI are not related. merging it. |
tarekgh
commented
Nov 9, 2022
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3430460958 |
@tarekgh backporting to release/7.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix Configuration with IList and ICollection
Applying: Address the feedback
error: sha1 information is lacking or useless (src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Address the feedback
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
@tarekgh an error occurred while backporting to release/7.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
#77725
In .NET 7.0 we had some code refactoring and fixes in configuration. This change had been handling the binding to
ICollction<T>andIList<T>by creating underlyingArray<T>object. It is obvious the returned object is not expandable which means users cannot add more items to that object. This is wrong and regression from previous versions of .NET/Core. The fix here is in case of binding toICollction<T>andIList<T>, we'll createList<T>object instead which is expandable and allow adding more items to such object.#77725 is a good example demonstrating this problem.