') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [main] Update dependencies from dotnet/linker by dotnet-maestro[bot] · Pull Request #78020 · dotnet/runtime · GitHub
Skip to content

[main] Update dependencies from dotnet/linker - #78020

Merged
marek-safar merged 16 commits into
mainfrom
darc-main-15341b8c-e1a3-4642-8792-347f0bee983e
Dec 5, 2022
Merged

[main] Update dependencies from dotnet/linker#78020
marek-safar merged 16 commits into
mainfrom
darc-main-15341b8c-e1a3-4642-8792-347f0bee983e

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/linker

  • Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
  • Build: 20221202.1
  • Date Produced: December 2, 2022 11:01:10 AM UTC
  • Commit: da244b780a1d1755cb7cb389df599fe650726892
  • Branch: refs/heads/main

…107.2
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22557.2
…109.1
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22559.1
…109.2
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22559.2
…110.1
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22560.1
@radical

Copy link
Copy Markdown
Member

wasm build failure with trimming:

ILLink : error IL1012: IL Trimmer has encountered an unexpected error. Please report the issue at https://github.com/dotnet/linker/issues [/__w/1/s/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/System.Text.RegularExpressions.Tests.csproj::TargetFramework=net7.0]
##[error]ILLink(0,0): error IL1012: (NETCORE_ENGINEERING_TELEMETRY=Build) IL Trimmer has encountered an unexpected error. Please report the issue at https://github.com/dotnet/linker/issues
Fatal error in IL Linker
Unhandled exception. System.IndexOutOfRangeException: Index was outside the bounds of the array.
at Mono.Linker.Steps.UnreachableBlocksOptimizer.BodyReducer.RewriteCondition(Int32 index, Instruction instr, Int32 operand)
at Mono.Linker.Steps.UnreachableBlocksOptimizer.BodyReducer.RemoveConditions()
at Mono.Linker.Steps.UnreachableBlocksOptimizer.BodyReducer.RewriteBody()
at Mono.Linker.Steps.UnreachableBlocksOptimizer.ProcessMethod(MethodDefinition method)
at Mono.Linker.Steps.MarkStep.MarkMethodBody(MethodBody body)
at Mono.Linker.Steps.MarkStep.ProcessMethod(MethodDefinition method, DependencyInfo& reason, MessageOrigin& origin)
at Mono.Linker.Steps.MarkStep.ProcessQueue()
at Mono.Linker.Steps.MarkStep.ProcessPrimaryQueue()
at Mono.Linker.Steps.MarkStep.Process()
at Mono.Linker.Steps.MarkStep.Process(LinkContext context)
at Mono.Linker.Pipeline.ProcessStep(LinkContext context, IStep step)
at Mono.Linker.Pipeline.Process(LinkContext context)
at Mono.Linker.Driver.Run(ILogger customLogger)
at Mono.Linker.Driver.Main(String[] args)

@eerhardt@marek-safar

@marek-safar

Copy link
Copy Markdown
Contributor

That's problem caused by my change, looking into it.

…114.1
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22564.1
…117.3
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22567.3
…121.1
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22571.1
…122.1
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22572.1
@marek-safar

Copy link
Copy Markdown
Contributor

The break comes from dotnet/linker#3124

@sbomer is it intentional breaking change? Could you commit the intended fix?

@sbomer

Copy link
Copy Markdown
Member

Yes, I'm making a fix here: dotnet/linker#3131

…123.1
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22573.1
dotnet-maestroBotand others added 2 commits November 25, 2022 13:22
…125.1
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22575.1
@marek-safar

Copy link
Copy Markdown
Contributor

@sbomer I think the change broke the trimming tests (presumably because they are fully rooted now)

…128.3
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22578.3
@sbomer

Copy link
Copy Markdown
Member

I'll take a look. It's also now blocked on #78817. We might want to roll back dotnet/linker#3135 if we want this PR to get unblocked first.

@sbomersbomer mentioned this pull request Nov 29, 2022
…129.3
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22579.3
@akoeplinger

Copy link
Copy Markdown
Member

#78817 is unblocked now, I expect it to go in in the next few hours.

…130.1
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22580.1
…202.1
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22552.1 -> To Version 7.0.100-1.22602.1
@marek-safar
marek-safar merged commit 5f51269 into mainDec 5, 2022
@marek-safar
marek-safar deleted the darc-main-15341b8c-e1a3-4642-8792-347f0bee983e branch December 5, 2022 08:18
@ghostghost locked as resolved and limited conversation to collaborators Jan 4, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflowfor labeling automated codeflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@radical@marek-safar@sbomer@akoeplinger