Linker into runtime diff2#78049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlakollo merged 6 commits into from
Nov 9, 2022
Merged

Linker into runtime diff2 #78049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8d3a70c
Merge and remove common files
Nov 8, 2022
62be15a
Create a variable for the tools folder in runtime
Nov 8, 2022
f28af1b
Refactorings to make test work
Nov 8, 2022
251c773
Enable pipeline
Nov 8, 2022
c82ed89
Fix Markdown lint
Nov 8, 2022
f35a0d2
PR feedback
Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,14 @@

/eng/pipelines/**/*wasm* @radical

# ILLink codeowners
/src/tools/illink/ @marek-safar
/src/tools/illink/src/analyzer/ @radekdoulik
/src/tools/illink/src/ILLink.Tasks/ @sbomer
/src/tools/illink/src/ILLink.RoslynAnalyzer/ @sbomer
/src/tools/illink/src/linker/ @marek-safar @mrvoorhe
/src/tools/illink/test/ @marek-safar @mrvoorhe

# Obsoletions / Custom Diagnostics

/docs/project/list-of-diagnostics.md @jeffhandley
Expand Down
1 change: 1 addition & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@
<MonoProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'mono'))</MonoProjectRoot>
<InstallerProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'installer'))</InstallerProjectRoot>
<WorkloadsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'workloads'))</WorkloadsProjectRoot>
<ToolsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tools'))</ToolsProjectRoot>
<SharedNativeRoot>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'native'))</SharedNativeRoot>
<RepoToolsLocalDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'tools-local'))</RepoToolsLocalDir>
<RepoTasksDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tasks'))</RepoTasksDir>
Expand Down
23 changes: 23 additions & 0 deletions THIRD-PARTY-NOTICES.TXT
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1177,6 +1177,29 @@ LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

License for Jb Evain
---------------------

Copyright (c) 2006 Jb Evain (jbevain@gmail.com)

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

--- Optional exception to the license ---

As an exception, if, as a result of your compiling your source code, portions
Expand Down
27 changes: 27 additions & 0 deletions eng/Subsets.props
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,8 @@
<SubsetName Include="Clr.NativeCoreLib" Description="Run crossgen on System.Private.CoreLib library for CoreCLR." />
<SubsetName Include="Clr.Tools" Description="Managed tools that support CoreCLR development and testing." />
<SubsetName Include="Clr.ToolsTests" OnDemand="true" Description="Unit tests for the clr.tools subset." />
<SubsetName Include="Tools.ILLink" Description="The projects that produce illink and analyzer tools for trimming." />
<SubsetName Include="Tools.ILLinkTests" OnDemand="true" Description="Unit tests for the tools.illink subset." />
<SubsetName Include="Clr.Packages" Description="The projects that produce NuGet packages for the CoreCLR runtime, crossgen, and IL tools." />
<SubsetName Include="LinuxDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" Description="The cross-OS Windows->libc-based Linux DAC. Skipped on x86." />
<SubsetName Include="AlpineDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" OnDemand="true" Description="The cross-OS Windows->musl-libc-based Linux DAC. Skipped on x86" />
Expand DownExpand Up@@ -326,6 +328,31 @@
Test="true" Category="clr" Condition="'$(DotNetBuildFromSource)' != 'true' and '$(NativeAotSupported)' == 'true'"/>
</ItemGroup>

<ItemGroup Condition="$(_subset.Contains('+tools.illink+'))">
<ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\Mono.Linker.csproj" Category="tools" />
<ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.Tasks\ILLink.Tasks.csproj" Category="tools" />
<ProjectToBuild Include="$(ToolsProjectRoot)illink\src\analyzer\analyzer.csproj" Category="tools" />
<ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.RoslynAnalyzer\ILLink.RoslynAnalyzer.csproj" Category="tools" />
<ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\ref\Mono.Linker.csproj" Category="tools" />
<ProjectToBuild Include="$(ToolsProjectRoot)illink\src\tlens\tlens.csproj" Category="tools" />
<ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.CodeFix\ILLink.CodeFixProvider.csproj" Category="tools" />
</ItemGroup>

<ItemGroup Condition="$(_subset.Contains('+tools.illinktests+'))">
<ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests\Mono.Linker.Tests.csproj"
Test="true" Category="tools"/>
<ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases\Mono.Linker.Tests.Cases.csproj"
Test="true" Category="tools"/>
<ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases.Expectations\Mono.Linker.Tests.Cases.Expectations.csproj"
Test="true" Category="tools"/>
<ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.Tasks.Tests\ILLink.Tasks.Tests.csproj"
Test="true" Category="tools"/>
<ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests\ILLink.RoslynAnalyzer.Tests.csproj"
Test="true" Category="tools"/>
<ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests.Generator\ILLink.RoslynAnalyzer.Tests.Generator.csproj"
Test="true" Category="tools"/>
</ItemGroup>

<ItemGroup Condition="$(_subset.Contains('+clr.nativecorelib+'))">
<!-- Build crossgen2 that will be used to compile System.Private.CoreLib library for CoreCLR -->
<ProjectToBuild Condition="'$(TargetArchitecture)' != 'x64' and '$(BuildArchitecture)' == 'x64'" Include="$(CoreClrProjectRoot)tools\aot\crossgen2\crossgen2_crossarch.csproj" Category="clr" />
Expand Down
8 changes: 8 additions & 0 deletions eng/Version.Details.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,14 @@
<Uri>https://github.com/dotnet/command-line-api</Uri>
<Sha>5618b2d243ccdeb5c7e50a298b33b13036b4351b</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Cecil" Version="0.11.4-alpha.22524.1">
<Uri>https://github.com/dotnet/cecil</Uri>
<Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Cecil.Pdb" Version="0.11.4-alpha.22524.1">
<Uri>https://github.com/dotnet/cecil</Uri>
<Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="8.0.0-beta.22554.2">
Expand Down
9 changes: 9 additions & 0 deletions eng/Versions.props
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,9 @@
-->
<MicrosoftCodeAnalysisVersion_LatestVS>4.4.0-2.22423.18</MicrosoftCodeAnalysisVersion_LatestVS>
<MicrosoftCodeAnalysisVersion_LatestVS Condition="'$(DotNetBuildFromSource)' == 'true'">$(MicrosoftCodeAnalysisVersion)</MicrosoftCodeAnalysisVersion_LatestVS>
<!-- Some of the analyzer dependencies used by ILLink project -->
<MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>1.0.1-beta1.21265.1</MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>
<MicrosoftCodeAnalysisBannedApiAnalyzersVersion>3.3.2</MicrosoftCodeAnalysisBannedApiAnalyzersVersion>
</PropertyGroup>
<!--
These packages affect the design-time experience in VS, so we update them at the same cadance as the MicrosoftCodeAnalysisVersion_LatestVS version.
Expand DownExpand Up@@ -207,6 +210,12 @@
<!-- ILLink -->
<MicrosoftNETILLinkTasksVersion>7.0.100-1.22552.1</MicrosoftNETILLinkTasksVersion>
<MicrosoftNETILLinkAnalyzerPackageVersion>$(MicrosoftNETILLinkTasksVersion)</MicrosoftNETILLinkAnalyzerPackageVersion>
<!-- Mono Cecil -->
<MicrosoftDotNetCecilVersion>0.11.4-alpha.22524.1</MicrosoftDotNetCecilVersion>
<MicrosoftDotNetCecilPdbVersion>$(MicrosoftDotNetCecilVersion)</MicrosoftDotNetCecilPdbVersion>
<!-- ILLink dependencies -->
<MicrosoftBuildFrameworkVersion>17.0.0-preview-21267-01</MicrosoftBuildFrameworkVersion>
<MicrosoftBuildUtilitiesCoreVersion>17.0.0-preview-21267-01</MicrosoftBuildUtilitiesCoreVersion>
<!-- ICU -->
<MicrosoftNETCoreRuntimeICUTransportVersion>8.0.0-alpha.1.22553.1</MicrosoftNETCoreRuntimeICUTransportVersion>
<!-- MsQuic -->
Expand Down
8 changes: 8 additions & 0 deletions eng/pipelines/common/evaluate-default-paths.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,7 @@ jobs:
- src/libraries/*
- src/native/libs/*
- src/tests/*
- src/tools/*
- eng/pipelines/installer/*
- eng/pipelines/mono/*
- eng/pipelines/libraries/*
Expand DownExpand Up@@ -80,6 +81,7 @@ jobs:
- src/libraries/*
- src/native/libs/*
- src/tests/*
- src/tools/*
- eng/pipelines/installer/*
- eng/pipelines/coreclr/*
- eng/pipelines/libraries/*
Expand All@@ -96,6 +98,7 @@ jobs:
- src/mono/*
- src/coreclr/*
- src/tests/*
- src/tools/*
- src/native/eventpipe/*
- eng/pipelines/coreclr/*
- eng/pipelines/mono/*
Expand All@@ -107,6 +110,10 @@ jobs:
include:
- src/tests/*

- subset: tools_illink
include:
- src/tools/illink/*

- subset: non_runtimetests
exclude:
- src/tests/*
Expand All@@ -127,6 +134,7 @@ jobs:
- src/mono/*
- src/libraries/*
- src/tests/*
- src/tools/*
- src/native/eventpipe/*
- eng/pipelines/coreclr/*
- eng/pipelines/mono/*
Expand Down
81 changes: 81 additions & 0 deletions eng/pipelines/runtime-tools-tests.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
# The purpose of this pipeline is to run the trimming tests. These tests ensure trimming is
# done correctly and also that our APIs are trimming safe.

trigger:
batch: true
branches:
include:
- release/*.*
paths:
include:
- '*'
exclude:
- '**.md'
- eng/Version.Details.xml
- .devcontainer/*
- .github/*
- docs/*
- LICENSE.TXT
- PATENTS.TXT
- THIRD-PARTY-NOTICES.TXT

schedules:
- cron: "0 7,19 * * *" # run at 7:00 and 19:00 (UTC) which is 23:00 and 11:00 (PST).
displayName: Runtime-tools-tests default schedule
branches:
include:
- main
always: false # run only if there were changes since the last successful scheduled run.

pr:
branches:
include:
- main
- release/*.*
paths:
include:
- '*'
exclude:
- '**.md'
- eng/Version.Details.xml
- .devcontainer/*
- .github/*
- docs/*
- LICENSE.TXT
- PATENTS.TXT
- THIRD-PARTY-NOTICES.TXT

variables:
- template: /eng/pipelines/common/variables.yml

extends:
template: /eng/pipelines/common/templates/single-stage-pipeline-with-resources.yml
parameters:
jobs:

#
# Evaluate paths
#
- ${{ if eq(variables.dependOnEvaluatePaths, true) }}:
- template: /eng/pipelines/common/evaluate-default-paths.yml

#
# Build Release config vertical for Windows, Linux and OSX
#
- template: /eng/pipelines/common/platform-matrix.yml
parameters:
jobTemplate: /eng/pipelines/common/global-build-job.yml
buildConfig: release
platforms:
- windows_x64
- OSX_x64
- Linux_x64
jobParameters:
testGroup: innerloop
timeoutInMinutes: 120
nameSuffix: Runtime_Release
condition:
or(
eq(dependencies.evaluate_paths.outputs['SetPathVars_tools_illink.containsChange.containsChange'], true),
eq(variables['isRollingBuild'], true))
buildArgs: -s tools.illinktests -c $(_BuildConfig)
3 changes: 0 additions & 3 deletions src/tools/illink/.editorconfig
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
# top-most EditorConfig file
root = true

@ViktorHoferViktorHoferNov 8, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to consolidate the code styling in src/tools/illink with the rest of the repo? If yes, can you please open a tracking issue to remove this .editorconfig later?

@tlakollotlakolloNov 8, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the linker repo is archived and no cherry picking is being made the editorconfig will be customized to only contain a small subset of overrides from runtime global config #78050

[*.cs]
indent_style = tab
indent_size = 4
Expand Down
4 changes: 0 additions & 4 deletions src/tools/illink/.gitattributes
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions src/tools/illink/.github/CODEOWNERS
View file
Open in desktop

This file was deleted.

67 changes: 0 additions & 67 deletions src/tools/illink/.github/CONTRIBUTING.md
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions src/tools/illink/.github/move.yml
View file
Open in desktop

This file was deleted.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Linker into runtime diff2#78049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tlakollo
merged 6 commits into

from

Nov 9, 2022
 Merged


Linker into runtime diff2
#78049
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
8d3a70c

Merge and remove common files

Nov 8, 2022
62be15a

Create a variable for the tools folder in runtime

Nov 8, 2022
f28af1b

Refactorings to make test work

Nov 8, 2022
251c773

Enable pipeline

Nov 8, 2022
c82ed89

Fix Markdown lint

Nov 8, 2022
f35a0d2

PR feedback

Nov 9, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 8 additions & 0 deletions
.github/CODEOWNERS

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,14 @@

/eng/pipelines/**/*wasm* @radical

# ILLink codeowners
/src/tools/illink/ @marek-safar
/src/tools/illink/src/analyzer/ @radekdoulik
/src/tools/illink/src/ILLink.Tasks/ @sbomer
/src/tools/illink/src/ILLink.RoslynAnalyzer/ @sbomer
/src/tools/illink/src/linker/ @marek-safar @mrvoorhe
/src/tools/illink/test/ @marek-safar @mrvoorhe

# Obsoletions / Custom Diagnostics

/docs/project/list-of-diagnostics.md @jeffhandley
Expand Down

1 change: 1 addition & 0 deletions
Directory.Build.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@
 <MonoProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'mono'))</MonoProjectRoot>
 <InstallerProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'installer'))</InstallerProjectRoot>
 <WorkloadsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'workloads'))</WorkloadsProjectRoot>
 <ToolsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tools'))</ToolsProjectRoot>
 <SharedNativeRoot>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'native'))</SharedNativeRoot>
 <RepoToolsLocalDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'tools-local'))</RepoToolsLocalDir>
 <RepoTasksDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tasks'))</RepoTasksDir>
Expand Down

23 changes: 23 additions & 0 deletions
THIRD-PARTY-NOTICES.TXT

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1177,6 +1177,29 @@ LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

License for Jb Evain
---------------------

Copyright (c) 2006 Jb Evain (jbevain@gmail.com)

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

--- Optional exception to the license ---

As an exception, if, as a result of your compiling your source code, portions
Expand Down

27 changes: 27 additions & 0 deletions
eng/Subsets.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,8 @@
 <SubsetName Include="Clr.NativeCoreLib" Description="Run crossgen on System.Private.CoreLib library for CoreCLR." />
 <SubsetName Include="Clr.Tools" Description="Managed tools that support CoreCLR development and testing." />
 <SubsetName Include="Clr.ToolsTests" OnDemand="true" Description="Unit tests for the clr.tools subset." />
 <SubsetName Include="Tools.ILLink" Description="The projects that produce illink and analyzer tools for trimming." />
 <SubsetName Include="Tools.ILLinkTests" OnDemand="true" Description="Unit tests for the tools.illink subset." />
 <SubsetName Include="Clr.Packages" Description="The projects that produce NuGet packages for the CoreCLR runtime, crossgen, and IL tools." />
 <SubsetName Include="LinuxDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" Description="The cross-OS Windows->libc-based Linux DAC. Skipped on x86." />
 <SubsetName Include="AlpineDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" OnDemand="true" Description="The cross-OS Windows->musl-libc-based Linux DAC. Skipped on x86" />
Expand DownExpand Up@@ -326,6 +328,31 @@
 Test="true" Category="clr" Condition="'$(DotNetBuildFromSource)' != 'true' and '$(NativeAotSupported)' == 'true'"/>
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+tools.illink+'))">
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\Mono.Linker.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.Tasks\ILLink.Tasks.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\analyzer\analyzer.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.RoslynAnalyzer\ILLink.RoslynAnalyzer.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\ref\Mono.Linker.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\tlens\tlens.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.CodeFix\ILLink.CodeFixProvider.csproj" Category="tools" />
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+tools.illinktests+'))">
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests\Mono.Linker.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases\Mono.Linker.Tests.Cases.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases.Expectations\Mono.Linker.Tests.Cases.Expectations.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.Tasks.Tests\ILLink.Tasks.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests\ILLink.RoslynAnalyzer.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests.Generator\ILLink.RoslynAnalyzer.Tests.Generator.csproj"
 Test="true" Category="tools"/>
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+clr.nativecorelib+'))">
 <!-- Build crossgen2 that will be used to compile System.Private.CoreLib library for CoreCLR -->
 <ProjectToBuild Condition="'$(TargetArchitecture)' != 'x64' and '$(BuildArchitecture)' == 'x64'" Include="$(CoreClrProjectRoot)tools\aot\crossgen2\crossgen2_crossarch.csproj" Category="clr" />
Expand Down

8 changes: 8 additions & 0 deletions
eng/Version.Details.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,14 @@
 <Uri>https://github.com/dotnet/command-line-api</Uri>
 <Sha>5618b2d243ccdeb5c7e50a298b33b13036b4351b</Sha>
 </Dependency>
 <Dependency Name="Microsoft.DotNet.Cecil" Version="0.11.4-alpha.22524.1">
 <Uri>https://github.com/dotnet/cecil</Uri>
 <Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
 </Dependency>
 <Dependency Name="Microsoft.DotNet.Cecil.Pdb" Version="0.11.4-alpha.22524.1">
 <Uri>https://github.com/dotnet/cecil</Uri>
 <Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
 </Dependency>
 </ProductDependencies>
 <ToolsetDependencies>
 <Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="8.0.0-beta.22554.2">
Expand Down

9 changes: 9 additions & 0 deletions
eng/Versions.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,9 @@
 -->
 <MicrosoftCodeAnalysisVersion_LatestVS>4.4.0-2.22423.18</MicrosoftCodeAnalysisVersion_LatestVS>
 <MicrosoftCodeAnalysisVersion_LatestVS Condition="'$(DotNetBuildFromSource)' == 'true'">$(MicrosoftCodeAnalysisVersion)</MicrosoftCodeAnalysisVersion_LatestVS>
 <!-- Some of the analyzer dependencies used by ILLink project -->
 <MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>1.0.1-beta1.21265.1</MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>
 <MicrosoftCodeAnalysisBannedApiAnalyzersVersion>3.3.2</MicrosoftCodeAnalysisBannedApiAnalyzersVersion>
 </PropertyGroup>
 <!--
 These packages affect the design-time experience in VS, so we update them at the same cadance as the MicrosoftCodeAnalysisVersion_LatestVS version.
Expand DownExpand Up@@ -207,6 +210,12 @@
 <!-- ILLink -->
 <MicrosoftNETILLinkTasksVersion>7.0.100-1.22552.1</MicrosoftNETILLinkTasksVersion>
 <MicrosoftNETILLinkAnalyzerPackageVersion>$(MicrosoftNETILLinkTasksVersion)</MicrosoftNETILLinkAnalyzerPackageVersion>
 <!-- Mono Cecil -->
 <MicrosoftDotNetCecilVersion>0.11.4-alpha.22524.1</MicrosoftDotNetCecilVersion>
 <MicrosoftDotNetCecilPdbVersion>$(MicrosoftDotNetCecilVersion)</MicrosoftDotNetCecilPdbVersion>
 <!-- ILLink dependencies -->
 <MicrosoftBuildFrameworkVersion>17.0.0-preview-21267-01</MicrosoftBuildFrameworkVersion>
 <MicrosoftBuildUtilitiesCoreVersion>17.0.0-preview-21267-01</MicrosoftBuildUtilitiesCoreVersion>
 <!-- ICU -->
 <MicrosoftNETCoreRuntimeICUTransportVersion>8.0.0-alpha.1.22553.1</MicrosoftNETCoreRuntimeICUTransportVersion>
 <!-- MsQuic -->
Expand Down

8 changes: 8 additions & 0 deletions
eng/pipelines/common/evaluate-default-paths.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,7 @@ jobs:
 - src/libraries/*
 - src/native/libs/*
 - src/tests/*
 - src/tools/*
 - eng/pipelines/installer/*
 - eng/pipelines/mono/*
 - eng/pipelines/libraries/*
Expand DownExpand Up@@ -80,6 +81,7 @@ jobs:
 - src/libraries/*
 - src/native/libs/*
 - src/tests/*
 - src/tools/*
 - eng/pipelines/installer/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/libraries/*
Expand All@@ -96,6 +98,7 @@ jobs:
 - src/mono/*
 - src/coreclr/*
 - src/tests/*
 - src/tools/*
 - src/native/eventpipe/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/mono/*
Expand All@@ -107,6 +110,10 @@ jobs:
 include:
 - src/tests/*

 - subset: tools_illink
 include:
 - src/tools/illink/*

 - subset: non_runtimetests
 exclude:
 - src/tests/*
Expand All@@ -127,6 +134,7 @@ jobs:
 - src/mono/*
 - src/libraries/*
 - src/tests/*
 - src/tools/*
 - src/native/eventpipe/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/mono/*
Expand Down

81 changes: 81 additions & 0 deletions
eng/pipelines/runtime-tools-tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
# The purpose of this pipeline is to run the trimming tests. These tests ensure trimming is
# done correctly and also that our APIs are trimming safe.

trigger:
 batch: true
 branches:
 include:
 - release/*.*
 paths:
 include:
 - '*'
 exclude:
 - '**.md'
 - eng/Version.Details.xml
 - .devcontainer/*
 - .github/*
 - docs/*
 - LICENSE.TXT
 - PATENTS.TXT
 - THIRD-PARTY-NOTICES.TXT

schedules:
 - cron: "0 7,19 * * *" # run at 7:00 and 19:00 (UTC) which is 23:00 and 11:00 (PST).
 displayName: Runtime-tools-tests default schedule
 branches:
 include:
 - main
 always: false # run only if there were changes since the last successful scheduled run.

pr:
 branches:
 include:
 - main
 - release/*.*
 paths:
 include:
 - '*'
 exclude:
 - '**.md'
 - eng/Version.Details.xml
 - .devcontainer/*
 - .github/*
 - docs/*
 - LICENSE.TXT
 - PATENTS.TXT
 - THIRD-PARTY-NOTICES.TXT

variables:
 - template: /eng/pipelines/common/variables.yml

extends:
 template: /eng/pipelines/common/templates/single-stage-pipeline-with-resources.yml
 parameters:
 jobs:

 #
 # Evaluate paths
 #
 - ${{ if eq(variables.dependOnEvaluatePaths, true) }}:
 - template: /eng/pipelines/common/evaluate-default-paths.yml

 #
 # Build Release config vertical for Windows, Linux and OSX
 #
 - template: /eng/pipelines/common/platform-matrix.yml
 parameters:
 jobTemplate: /eng/pipelines/common/global-build-job.yml
 buildConfig: release
 platforms:
 - windows_x64
 - OSX_x64
 - Linux_x64
 jobParameters:
 testGroup: innerloop
 timeoutInMinutes: 120
 nameSuffix: Runtime_Release
 condition:
 or(
 eq(dependencies.evaluate_paths.outputs['SetPathVars_tools_illink.containsChange.containsChange'], true),
 eq(variables['isRollingBuild'], true))
 buildArgs: -s tools.illinktests -c $(_BuildConfig)

3 changes: 0 additions & 3 deletions
src/tools/illink/.editorconfig

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
# top-most EditorConfig file
root = true

@ViktorHoferViktorHoferNov 8, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to consolidate the code styling in src/tools/illink with the rest of the repo? If yes, can you please open a tracking issue to remove this .editorconfig later?
@tlakollotlakolloNov 8, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the linker repo is archived and no cherry picking is being made the editorconfig will be customized to only contain a small subset of overrides from runtime global config #78050
[*.cs]
indent_style = tab
indent_size = 4
Expand Down

4 changes: 0 additions & 4 deletions
src/tools/illink/.gitattributes

View file


Open in desktop


This file was deleted.


12 changes: 0 additions & 12 deletions
src/tools/illink/.github/CODEOWNERS

View file


Open in desktop


This file was deleted.


67 changes: 0 additions & 67 deletions
src/tools/illink/.github/CONTRIBUTING.md

View file


Open in desktop


This file was deleted.


26 changes: 0 additions & 26 deletions
src/tools/illink/.github/move.yml

View file


Open in desktop


This file was deleted.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Linker into runtime diff2#78049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tlakollo
merged 6 commits into

from

Nov 9, 2022
 Merged


Linker into runtime diff2
#78049
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
8d3a70c

Merge and remove common files

Nov 8, 2022
62be15a

Create a variable for the tools folder in runtime

Nov 8, 2022
f28af1b

Refactorings to make test work

Nov 8, 2022
251c773

Enable pipeline

Nov 8, 2022
c82ed89

Fix Markdown lint

Nov 8, 2022
f35a0d2

PR feedback

Nov 9, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 8 additions & 0 deletions
.github/CODEOWNERS

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,14 @@

/eng/pipelines/**/*wasm* @radical

# ILLink codeowners
/src/tools/illink/ @marek-safar
/src/tools/illink/src/analyzer/ @radekdoulik
/src/tools/illink/src/ILLink.Tasks/ @sbomer
/src/tools/illink/src/ILLink.RoslynAnalyzer/ @sbomer
/src/tools/illink/src/linker/ @marek-safar @mrvoorhe
/src/tools/illink/test/ @marek-safar @mrvoorhe

# Obsoletions / Custom Diagnostics

/docs/project/list-of-diagnostics.md @jeffhandley
Expand Down

1 change: 1 addition & 0 deletions
Directory.Build.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@
 <MonoProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'mono'))</MonoProjectRoot>
 <InstallerProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'installer'))</InstallerProjectRoot>
 <WorkloadsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'workloads'))</WorkloadsProjectRoot>
 <ToolsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tools'))</ToolsProjectRoot>
 <SharedNativeRoot>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'native'))</SharedNativeRoot>
 <RepoToolsLocalDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'tools-local'))</RepoToolsLocalDir>
 <RepoTasksDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tasks'))</RepoTasksDir>
Expand Down

23 changes: 23 additions & 0 deletions
THIRD-PARTY-NOTICES.TXT

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1177,6 +1177,29 @@ LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

License for Jb Evain
---------------------

Copyright (c) 2006 Jb Evain (jbevain@gmail.com)

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

--- Optional exception to the license ---

As an exception, if, as a result of your compiling your source code, portions
Expand Down

27 changes: 27 additions & 0 deletions
eng/Subsets.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,8 @@
 <SubsetName Include="Clr.NativeCoreLib" Description="Run crossgen on System.Private.CoreLib library for CoreCLR." />
 <SubsetName Include="Clr.Tools" Description="Managed tools that support CoreCLR development and testing." />
 <SubsetName Include="Clr.ToolsTests" OnDemand="true" Description="Unit tests for the clr.tools subset." />
 <SubsetName Include="Tools.ILLink" Description="The projects that produce illink and analyzer tools for trimming." />
 <SubsetName Include="Tools.ILLinkTests" OnDemand="true" Description="Unit tests for the tools.illink subset." />
 <SubsetName Include="Clr.Packages" Description="The projects that produce NuGet packages for the CoreCLR runtime, crossgen, and IL tools." />
 <SubsetName Include="LinuxDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" Description="The cross-OS Windows->libc-based Linux DAC. Skipped on x86." />
 <SubsetName Include="AlpineDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" OnDemand="true" Description="The cross-OS Windows->musl-libc-based Linux DAC. Skipped on x86" />
Expand DownExpand Up@@ -326,6 +328,31 @@
 Test="true" Category="clr" Condition="'$(DotNetBuildFromSource)' != 'true' and '$(NativeAotSupported)' == 'true'"/>
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+tools.illink+'))">
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\Mono.Linker.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.Tasks\ILLink.Tasks.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\analyzer\analyzer.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.RoslynAnalyzer\ILLink.RoslynAnalyzer.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\ref\Mono.Linker.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\tlens\tlens.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.CodeFix\ILLink.CodeFixProvider.csproj" Category="tools" />
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+tools.illinktests+'))">
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests\Mono.Linker.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases\Mono.Linker.Tests.Cases.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases.Expectations\Mono.Linker.Tests.Cases.Expectations.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.Tasks.Tests\ILLink.Tasks.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests\ILLink.RoslynAnalyzer.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests.Generator\ILLink.RoslynAnalyzer.Tests.Generator.csproj"
 Test="true" Category="tools"/>
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+clr.nativecorelib+'))">
 <!-- Build crossgen2 that will be used to compile System.Private.CoreLib library for CoreCLR -->
 <ProjectToBuild Condition="'$(TargetArchitecture)' != 'x64' and '$(BuildArchitecture)' == 'x64'" Include="$(CoreClrProjectRoot)tools\aot\crossgen2\crossgen2_crossarch.csproj" Category="clr" />
Expand Down

8 changes: 8 additions & 0 deletions
eng/Version.Details.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,14 @@
 <Uri>https://github.com/dotnet/command-line-api</Uri>
 <Sha>5618b2d243ccdeb5c7e50a298b33b13036b4351b</Sha>
 </Dependency>
 <Dependency Name="Microsoft.DotNet.Cecil" Version="0.11.4-alpha.22524.1">
 <Uri>https://github.com/dotnet/cecil</Uri>
 <Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
 </Dependency>
 <Dependency Name="Microsoft.DotNet.Cecil.Pdb" Version="0.11.4-alpha.22524.1">
 <Uri>https://github.com/dotnet/cecil</Uri>
 <Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
 </Dependency>
 </ProductDependencies>
 <ToolsetDependencies>
 <Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="8.0.0-beta.22554.2">
Expand Down

9 changes: 9 additions & 0 deletions
eng/Versions.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,9 @@
 -->
 <MicrosoftCodeAnalysisVersion_LatestVS>4.4.0-2.22423.18</MicrosoftCodeAnalysisVersion_LatestVS>
 <MicrosoftCodeAnalysisVersion_LatestVS Condition="'$(DotNetBuildFromSource)' == 'true'">$(MicrosoftCodeAnalysisVersion)</MicrosoftCodeAnalysisVersion_LatestVS>
 <!-- Some of the analyzer dependencies used by ILLink project -->
 <MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>1.0.1-beta1.21265.1</MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>
 <MicrosoftCodeAnalysisBannedApiAnalyzersVersion>3.3.2</MicrosoftCodeAnalysisBannedApiAnalyzersVersion>
 </PropertyGroup>
 <!--
 These packages affect the design-time experience in VS, so we update them at the same cadance as the MicrosoftCodeAnalysisVersion_LatestVS version.
Expand DownExpand Up@@ -207,6 +210,12 @@
 <!-- ILLink -->
 <MicrosoftNETILLinkTasksVersion>7.0.100-1.22552.1</MicrosoftNETILLinkTasksVersion>
 <MicrosoftNETILLinkAnalyzerPackageVersion>$(MicrosoftNETILLinkTasksVersion)</MicrosoftNETILLinkAnalyzerPackageVersion>
 <!-- Mono Cecil -->
 <MicrosoftDotNetCecilVersion>0.11.4-alpha.22524.1</MicrosoftDotNetCecilVersion>
 <MicrosoftDotNetCecilPdbVersion>$(MicrosoftDotNetCecilVersion)</MicrosoftDotNetCecilPdbVersion>
 <!-- ILLink dependencies -->
 <MicrosoftBuildFrameworkVersion>17.0.0-preview-21267-01</MicrosoftBuildFrameworkVersion>
 <MicrosoftBuildUtilitiesCoreVersion>17.0.0-preview-21267-01</MicrosoftBuildUtilitiesCoreVersion>
 <!-- ICU -->
 <MicrosoftNETCoreRuntimeICUTransportVersion>8.0.0-alpha.1.22553.1</MicrosoftNETCoreRuntimeICUTransportVersion>
 <!-- MsQuic -->
Expand Down

8 changes: 8 additions & 0 deletions
eng/pipelines/common/evaluate-default-paths.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,7 @@ jobs:
 - src/libraries/*
 - src/native/libs/*
 - src/tests/*
 - src/tools/*
 - eng/pipelines/installer/*
 - eng/pipelines/mono/*
 - eng/pipelines/libraries/*
Expand DownExpand Up@@ -80,6 +81,7 @@ jobs:
 - src/libraries/*
 - src/native/libs/*
 - src/tests/*
 - src/tools/*
 - eng/pipelines/installer/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/libraries/*
Expand All@@ -96,6 +98,7 @@ jobs:
 - src/mono/*
 - src/coreclr/*
 - src/tests/*
 - src/tools/*
 - src/native/eventpipe/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/mono/*
Expand All@@ -107,6 +110,10 @@ jobs:
 include:
 - src/tests/*

 - subset: tools_illink
 include:
 - src/tools/illink/*

 - subset: non_runtimetests
 exclude:
 - src/tests/*
Expand All@@ -127,6 +134,7 @@ jobs:
 - src/mono/*
 - src/libraries/*
 - src/tests/*
 - src/tools/*
 - src/native/eventpipe/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/mono/*
Expand Down

81 changes: 81 additions & 0 deletions
eng/pipelines/runtime-tools-tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
# The purpose of this pipeline is to run the trimming tests. These tests ensure trimming is
# done correctly and also that our APIs are trimming safe.

trigger:
 batch: true
 branches:
 include:
 - release/*.*
 paths:
 include:
 - '*'
 exclude:
 - '**.md'
 - eng/Version.Details.xml
 - .devcontainer/*
 - .github/*
 - docs/*
 - LICENSE.TXT
 - PATENTS.TXT
 - THIRD-PARTY-NOTICES.TXT

schedules:
 - cron: "0 7,19 * * *" # run at 7:00 and 19:00 (UTC) which is 23:00 and 11:00 (PST).
 displayName: Runtime-tools-tests default schedule
 branches:
 include:
 - main
 always: false # run only if there were changes since the last successful scheduled run.

pr:
 branches:
 include:
 - main
 - release/*.*
 paths:
 include:
 - '*'
 exclude:
 - '**.md'
 - eng/Version.Details.xml
 - .devcontainer/*
 - .github/*
 - docs/*
 - LICENSE.TXT
 - PATENTS.TXT
 - THIRD-PARTY-NOTICES.TXT

variables:
 - template: /eng/pipelines/common/variables.yml

extends:
 template: /eng/pipelines/common/templates/single-stage-pipeline-with-resources.yml
 parameters:
 jobs:

 #
 # Evaluate paths
 #
 - ${{ if eq(variables.dependOnEvaluatePaths, true) }}:
 - template: /eng/pipelines/common/evaluate-default-paths.yml

 #
 # Build Release config vertical for Windows, Linux and OSX
 #
 - template: /eng/pipelines/common/platform-matrix.yml
 parameters:
 jobTemplate: /eng/pipelines/common/global-build-job.yml
 buildConfig: release
 platforms:
 - windows_x64
 - OSX_x64
 - Linux_x64
 jobParameters:
 testGroup: innerloop
 timeoutInMinutes: 120
 nameSuffix: Runtime_Release
 condition:
 or(
 eq(dependencies.evaluate_paths.outputs['SetPathVars_tools_illink.containsChange.containsChange'], true),
 eq(variables['isRollingBuild'], true))
 buildArgs: -s tools.illinktests -c $(_BuildConfig)

3 changes: 0 additions & 3 deletions
src/tools/illink/.editorconfig

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
# top-most EditorConfig file
root = true

@ViktorHoferViktorHoferNov 8, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to consolidate the code styling in src/tools/illink with the rest of the repo? If yes, can you please open a tracking issue to remove this .editorconfig later?
@tlakollotlakolloNov 8, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the linker repo is archived and no cherry picking is being made the editorconfig will be customized to only contain a small subset of overrides from runtime global config #78050
[*.cs]
indent_style = tab
indent_size = 4
Expand Down

4 changes: 0 additions & 4 deletions
src/tools/illink/.gitattributes

View file


Open in desktop


This file was deleted.


12 changes: 0 additions & 12 deletions
src/tools/illink/.github/CODEOWNERS

View file


Open in desktop


This file was deleted.


67 changes: 0 additions & 67 deletions
src/tools/illink/.github/CONTRIBUTING.md

View file


Open in desktop


This file was deleted.


26 changes: 0 additions & 26 deletions
src/tools/illink/.github/move.yml

View file


Open in desktop


This file was deleted.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Linker into runtime diff2#78049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tlakollo
merged 6 commits into

from

Nov 9, 2022
 Merged


Linker into runtime diff2
#78049
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
8d3a70c

Merge and remove common files

Nov 8, 2022
62be15a

Create a variable for the tools folder in runtime

Nov 8, 2022
f28af1b

Refactorings to make test work

Nov 8, 2022
251c773

Enable pipeline

Nov 8, 2022
c82ed89

Fix Markdown lint

Nov 8, 2022
f35a0d2

PR feedback

Nov 9, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 8 additions & 0 deletions
.github/CODEOWNERS

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,14 @@

/eng/pipelines/**/*wasm* @radical

# ILLink codeowners
/src/tools/illink/ @marek-safar
/src/tools/illink/src/analyzer/ @radekdoulik
/src/tools/illink/src/ILLink.Tasks/ @sbomer
/src/tools/illink/src/ILLink.RoslynAnalyzer/ @sbomer
/src/tools/illink/src/linker/ @marek-safar @mrvoorhe
/src/tools/illink/test/ @marek-safar @mrvoorhe

# Obsoletions / Custom Diagnostics

/docs/project/list-of-diagnostics.md @jeffhandley
Expand Down

1 change: 1 addition & 0 deletions
Directory.Build.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@
 <MonoProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'mono'))</MonoProjectRoot>
 <InstallerProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'installer'))</InstallerProjectRoot>
 <WorkloadsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'workloads'))</WorkloadsProjectRoot>
 <ToolsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tools'))</ToolsProjectRoot>
 <SharedNativeRoot>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'native'))</SharedNativeRoot>
 <RepoToolsLocalDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'tools-local'))</RepoToolsLocalDir>
 <RepoTasksDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tasks'))</RepoTasksDir>
Expand Down

23 changes: 23 additions & 0 deletions
THIRD-PARTY-NOTICES.TXT

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1177,6 +1177,29 @@ LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

License for Jb Evain
---------------------

Copyright (c) 2006 Jb Evain (jbevain@gmail.com)

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

--- Optional exception to the license ---

As an exception, if, as a result of your compiling your source code, portions
Expand Down

27 changes: 27 additions & 0 deletions
eng/Subsets.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,8 @@
 <SubsetName Include="Clr.NativeCoreLib" Description="Run crossgen on System.Private.CoreLib library for CoreCLR." />
 <SubsetName Include="Clr.Tools" Description="Managed tools that support CoreCLR development and testing." />
 <SubsetName Include="Clr.ToolsTests" OnDemand="true" Description="Unit tests for the clr.tools subset." />
 <SubsetName Include="Tools.ILLink" Description="The projects that produce illink and analyzer tools for trimming." />
 <SubsetName Include="Tools.ILLinkTests" OnDemand="true" Description="Unit tests for the tools.illink subset." />
 <SubsetName Include="Clr.Packages" Description="The projects that produce NuGet packages for the CoreCLR runtime, crossgen, and IL tools." />
 <SubsetName Include="LinuxDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" Description="The cross-OS Windows->libc-based Linux DAC. Skipped on x86." />
 <SubsetName Include="AlpineDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" OnDemand="true" Description="The cross-OS Windows->musl-libc-based Linux DAC. Skipped on x86" />
Expand DownExpand Up@@ -326,6 +328,31 @@
 Test="true" Category="clr" Condition="'$(DotNetBuildFromSource)' != 'true' and '$(NativeAotSupported)' == 'true'"/>
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+tools.illink+'))">
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\Mono.Linker.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.Tasks\ILLink.Tasks.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\analyzer\analyzer.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.RoslynAnalyzer\ILLink.RoslynAnalyzer.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\ref\Mono.Linker.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\tlens\tlens.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.CodeFix\ILLink.CodeFixProvider.csproj" Category="tools" />
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+tools.illinktests+'))">
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests\Mono.Linker.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases\Mono.Linker.Tests.Cases.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases.Expectations\Mono.Linker.Tests.Cases.Expectations.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.Tasks.Tests\ILLink.Tasks.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests\ILLink.RoslynAnalyzer.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests.Generator\ILLink.RoslynAnalyzer.Tests.Generator.csproj"
 Test="true" Category="tools"/>
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+clr.nativecorelib+'))">
 <!-- Build crossgen2 that will be used to compile System.Private.CoreLib library for CoreCLR -->
 <ProjectToBuild Condition="'$(TargetArchitecture)' != 'x64' and '$(BuildArchitecture)' == 'x64'" Include="$(CoreClrProjectRoot)tools\aot\crossgen2\crossgen2_crossarch.csproj" Category="clr" />
Expand Down

8 changes: 8 additions & 0 deletions
eng/Version.Details.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,14 @@
 <Uri>https://github.com/dotnet/command-line-api</Uri>
 <Sha>5618b2d243ccdeb5c7e50a298b33b13036b4351b</Sha>
 </Dependency>
 <Dependency Name="Microsoft.DotNet.Cecil" Version="0.11.4-alpha.22524.1">
 <Uri>https://github.com/dotnet/cecil</Uri>
 <Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
 </Dependency>
 <Dependency Name="Microsoft.DotNet.Cecil.Pdb" Version="0.11.4-alpha.22524.1">
 <Uri>https://github.com/dotnet/cecil</Uri>
 <Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
 </Dependency>
 </ProductDependencies>
 <ToolsetDependencies>
 <Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="8.0.0-beta.22554.2">
Expand Down

9 changes: 9 additions & 0 deletions
eng/Versions.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,9 @@
 -->
 <MicrosoftCodeAnalysisVersion_LatestVS>4.4.0-2.22423.18</MicrosoftCodeAnalysisVersion_LatestVS>
 <MicrosoftCodeAnalysisVersion_LatestVS Condition="'$(DotNetBuildFromSource)' == 'true'">$(MicrosoftCodeAnalysisVersion)</MicrosoftCodeAnalysisVersion_LatestVS>
 <!-- Some of the analyzer dependencies used by ILLink project -->
 <MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>1.0.1-beta1.21265.1</MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>
 <MicrosoftCodeAnalysisBannedApiAnalyzersVersion>3.3.2</MicrosoftCodeAnalysisBannedApiAnalyzersVersion>
 </PropertyGroup>
 <!--
 These packages affect the design-time experience in VS, so we update them at the same cadance as the MicrosoftCodeAnalysisVersion_LatestVS version.
Expand DownExpand Up@@ -207,6 +210,12 @@
 <!-- ILLink -->
 <MicrosoftNETILLinkTasksVersion>7.0.100-1.22552.1</MicrosoftNETILLinkTasksVersion>
 <MicrosoftNETILLinkAnalyzerPackageVersion>$(MicrosoftNETILLinkTasksVersion)</MicrosoftNETILLinkAnalyzerPackageVersion>
 <!-- Mono Cecil -->
 <MicrosoftDotNetCecilVersion>0.11.4-alpha.22524.1</MicrosoftDotNetCecilVersion>
 <MicrosoftDotNetCecilPdbVersion>$(MicrosoftDotNetCecilVersion)</MicrosoftDotNetCecilPdbVersion>
 <!-- ILLink dependencies -->
 <MicrosoftBuildFrameworkVersion>17.0.0-preview-21267-01</MicrosoftBuildFrameworkVersion>
 <MicrosoftBuildUtilitiesCoreVersion>17.0.0-preview-21267-01</MicrosoftBuildUtilitiesCoreVersion>
 <!-- ICU -->
 <MicrosoftNETCoreRuntimeICUTransportVersion>8.0.0-alpha.1.22553.1</MicrosoftNETCoreRuntimeICUTransportVersion>
 <!-- MsQuic -->
Expand Down

8 changes: 8 additions & 0 deletions
eng/pipelines/common/evaluate-default-paths.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,7 @@ jobs:
 - src/libraries/*
 - src/native/libs/*
 - src/tests/*
 - src/tools/*
 - eng/pipelines/installer/*
 - eng/pipelines/mono/*
 - eng/pipelines/libraries/*
Expand DownExpand Up@@ -80,6 +81,7 @@ jobs:
 - src/libraries/*
 - src/native/libs/*
 - src/tests/*
 - src/tools/*
 - eng/pipelines/installer/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/libraries/*
Expand All@@ -96,6 +98,7 @@ jobs:
 - src/mono/*
 - src/coreclr/*
 - src/tests/*
 - src/tools/*
 - src/native/eventpipe/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/mono/*
Expand All@@ -107,6 +110,10 @@ jobs:
 include:
 - src/tests/*

 - subset: tools_illink
 include:
 - src/tools/illink/*

 - subset: non_runtimetests
 exclude:
 - src/tests/*
Expand All@@ -127,6 +134,7 @@ jobs:
 - src/mono/*
 - src/libraries/*
 - src/tests/*
 - src/tools/*
 - src/native/eventpipe/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/mono/*
Expand Down

81 changes: 81 additions & 0 deletions
eng/pipelines/runtime-tools-tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
# The purpose of this pipeline is to run the trimming tests. These tests ensure trimming is
# done correctly and also that our APIs are trimming safe.

trigger:
 batch: true
 branches:
 include:
 - release/*.*
 paths:
 include:
 - '*'
 exclude:
 - '**.md'
 - eng/Version.Details.xml
 - .devcontainer/*
 - .github/*
 - docs/*
 - LICENSE.TXT
 - PATENTS.TXT
 - THIRD-PARTY-NOTICES.TXT

schedules:
 - cron: "0 7,19 * * *" # run at 7:00 and 19:00 (UTC) which is 23:00 and 11:00 (PST).
 displayName: Runtime-tools-tests default schedule
 branches:
 include:
 - main
 always: false # run only if there were changes since the last successful scheduled run.

pr:
 branches:
 include:
 - main
 - release/*.*
 paths:
 include:
 - '*'
 exclude:
 - '**.md'
 - eng/Version.Details.xml
 - .devcontainer/*
 - .github/*
 - docs/*
 - LICENSE.TXT
 - PATENTS.TXT
 - THIRD-PARTY-NOTICES.TXT

variables:
 - template: /eng/pipelines/common/variables.yml

extends:
 template: /eng/pipelines/common/templates/single-stage-pipeline-with-resources.yml
 parameters:
 jobs:

 #
 # Evaluate paths
 #
 - ${{ if eq(variables.dependOnEvaluatePaths, true) }}:
 - template: /eng/pipelines/common/evaluate-default-paths.yml

 #
 # Build Release config vertical for Windows, Linux and OSX
 #
 - template: /eng/pipelines/common/platform-matrix.yml
 parameters:
 jobTemplate: /eng/pipelines/common/global-build-job.yml
 buildConfig: release
 platforms:
 - windows_x64
 - OSX_x64
 - Linux_x64
 jobParameters:
 testGroup: innerloop
 timeoutInMinutes: 120
 nameSuffix: Runtime_Release
 condition:
 or(
 eq(dependencies.evaluate_paths.outputs['SetPathVars_tools_illink.containsChange.containsChange'], true),
 eq(variables['isRollingBuild'], true))
 buildArgs: -s tools.illinktests -c $(_BuildConfig)

3 changes: 0 additions & 3 deletions
src/tools/illink/.editorconfig

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
# top-most EditorConfig file
root = true

@ViktorHoferViktorHoferNov 8, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to consolidate the code styling in src/tools/illink with the rest of the repo? If yes, can you please open a tracking issue to remove this .editorconfig later?
@tlakollotlakolloNov 8, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the linker repo is archived and no cherry picking is being made the editorconfig will be customized to only contain a small subset of overrides from runtime global config #78050
[*.cs]
indent_style = tab
indent_size = 4
Expand Down

4 changes: 0 additions & 4 deletions
src/tools/illink/.gitattributes

View file


Open in desktop


This file was deleted.


12 changes: 0 additions & 12 deletions
src/tools/illink/.github/CODEOWNERS

View file


Open in desktop


This file was deleted.


67 changes: 0 additions & 67 deletions
src/tools/illink/.github/CONTRIBUTING.md

View file


Open in desktop


This file was deleted.


26 changes: 0 additions & 26 deletions
src/tools/illink/.github/move.yml

View file


Open in desktop


This file was deleted.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Linker into runtime diff2#78049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tlakollo
merged 6 commits into

from

Nov 9, 2022
 Merged


Linker into runtime diff2
#78049
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
8d3a70c

Merge and remove common files

Nov 8, 2022
62be15a

Create a variable for the tools folder in runtime

Nov 8, 2022
f28af1b

Refactorings to make test work

Nov 8, 2022
251c773

Enable pipeline

Nov 8, 2022
c82ed89

Fix Markdown lint

Nov 8, 2022
f35a0d2

PR feedback

Nov 9, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 8 additions & 0 deletions
.github/CODEOWNERS

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,14 @@

/eng/pipelines/**/*wasm* @radical

# ILLink codeowners
/src/tools/illink/ @marek-safar
/src/tools/illink/src/analyzer/ @radekdoulik
/src/tools/illink/src/ILLink.Tasks/ @sbomer
/src/tools/illink/src/ILLink.RoslynAnalyzer/ @sbomer
/src/tools/illink/src/linker/ @marek-safar @mrvoorhe
/src/tools/illink/test/ @marek-safar @mrvoorhe

# Obsoletions / Custom Diagnostics

/docs/project/list-of-diagnostics.md @jeffhandley
Expand Down

1 change: 1 addition & 0 deletions
Directory.Build.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@
 <MonoProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'mono'))</MonoProjectRoot>
 <InstallerProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'installer'))</InstallerProjectRoot>
 <WorkloadsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'workloads'))</WorkloadsProjectRoot>
 <ToolsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tools'))</ToolsProjectRoot>
 <SharedNativeRoot>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'native'))</SharedNativeRoot>
 <RepoToolsLocalDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'tools-local'))</RepoToolsLocalDir>
 <RepoTasksDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tasks'))</RepoTasksDir>
Expand Down

23 changes: 23 additions & 0 deletions
THIRD-PARTY-NOTICES.TXT

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1177,6 +1177,29 @@ LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

License for Jb Evain
---------------------

Copyright (c) 2006 Jb Evain (jbevain@gmail.com)

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

--- Optional exception to the license ---

As an exception, if, as a result of your compiling your source code, portions
Expand Down

27 changes: 27 additions & 0 deletions
eng/Subsets.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,8 @@
 <SubsetName Include="Clr.NativeCoreLib" Description="Run crossgen on System.Private.CoreLib library for CoreCLR." />
 <SubsetName Include="Clr.Tools" Description="Managed tools that support CoreCLR development and testing." />
 <SubsetName Include="Clr.ToolsTests" OnDemand="true" Description="Unit tests for the clr.tools subset." />
 <SubsetName Include="Tools.ILLink" Description="The projects that produce illink and analyzer tools for trimming." />
 <SubsetName Include="Tools.ILLinkTests" OnDemand="true" Description="Unit tests for the tools.illink subset." />
 <SubsetName Include="Clr.Packages" Description="The projects that produce NuGet packages for the CoreCLR runtime, crossgen, and IL tools." />
 <SubsetName Include="LinuxDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" Description="The cross-OS Windows->libc-based Linux DAC. Skipped on x86." />
 <SubsetName Include="AlpineDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" OnDemand="true" Description="The cross-OS Windows->musl-libc-based Linux DAC. Skipped on x86" />
Expand DownExpand Up@@ -326,6 +328,31 @@
 Test="true" Category="clr" Condition="'$(DotNetBuildFromSource)' != 'true' and '$(NativeAotSupported)' == 'true'"/>
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+tools.illink+'))">
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\Mono.Linker.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.Tasks\ILLink.Tasks.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\analyzer\analyzer.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.RoslynAnalyzer\ILLink.RoslynAnalyzer.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\ref\Mono.Linker.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\tlens\tlens.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.CodeFix\ILLink.CodeFixProvider.csproj" Category="tools" />
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+tools.illinktests+'))">
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests\Mono.Linker.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases\Mono.Linker.Tests.Cases.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases.Expectations\Mono.Linker.Tests.Cases.Expectations.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.Tasks.Tests\ILLink.Tasks.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests\ILLink.RoslynAnalyzer.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests.Generator\ILLink.RoslynAnalyzer.Tests.Generator.csproj"
 Test="true" Category="tools"/>
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+clr.nativecorelib+'))">
 <!-- Build crossgen2 that will be used to compile System.Private.CoreLib library for CoreCLR -->
 <ProjectToBuild Condition="'$(TargetArchitecture)' != 'x64' and '$(BuildArchitecture)' == 'x64'" Include="$(CoreClrProjectRoot)tools\aot\crossgen2\crossgen2_crossarch.csproj" Category="clr" />
Expand Down

8 changes: 8 additions & 0 deletions
eng/Version.Details.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,14 @@
 <Uri>https://github.com/dotnet/command-line-api</Uri>
 <Sha>5618b2d243ccdeb5c7e50a298b33b13036b4351b</Sha>
 </Dependency>
 <Dependency Name="Microsoft.DotNet.Cecil" Version="0.11.4-alpha.22524.1">
 <Uri>https://github.com/dotnet/cecil</Uri>
 <Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
 </Dependency>
 <Dependency Name="Microsoft.DotNet.Cecil.Pdb" Version="0.11.4-alpha.22524.1">
 <Uri>https://github.com/dotnet/cecil</Uri>
 <Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
 </Dependency>
 </ProductDependencies>
 <ToolsetDependencies>
 <Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="8.0.0-beta.22554.2">
Expand Down

9 changes: 9 additions & 0 deletions
eng/Versions.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,9 @@
 -->
 <MicrosoftCodeAnalysisVersion_LatestVS>4.4.0-2.22423.18</MicrosoftCodeAnalysisVersion_LatestVS>
 <MicrosoftCodeAnalysisVersion_LatestVS Condition="'$(DotNetBuildFromSource)' == 'true'">$(MicrosoftCodeAnalysisVersion)</MicrosoftCodeAnalysisVersion_LatestVS>
 <!-- Some of the analyzer dependencies used by ILLink project -->
 <MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>1.0.1-beta1.21265.1</MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>
 <MicrosoftCodeAnalysisBannedApiAnalyzersVersion>3.3.2</MicrosoftCodeAnalysisBannedApiAnalyzersVersion>
 </PropertyGroup>
 <!--
 These packages affect the design-time experience in VS, so we update them at the same cadance as the MicrosoftCodeAnalysisVersion_LatestVS version.
Expand DownExpand Up@@ -207,6 +210,12 @@
 <!-- ILLink -->
 <MicrosoftNETILLinkTasksVersion>7.0.100-1.22552.1</MicrosoftNETILLinkTasksVersion>
 <MicrosoftNETILLinkAnalyzerPackageVersion>$(MicrosoftNETILLinkTasksVersion)</MicrosoftNETILLinkAnalyzerPackageVersion>
 <!-- Mono Cecil -->
 <MicrosoftDotNetCecilVersion>0.11.4-alpha.22524.1</MicrosoftDotNetCecilVersion>
 <MicrosoftDotNetCecilPdbVersion>$(MicrosoftDotNetCecilVersion)</MicrosoftDotNetCecilPdbVersion>
 <!-- ILLink dependencies -->
 <MicrosoftBuildFrameworkVersion>17.0.0-preview-21267-01</MicrosoftBuildFrameworkVersion>
 <MicrosoftBuildUtilitiesCoreVersion>17.0.0-preview-21267-01</MicrosoftBuildUtilitiesCoreVersion>
 <!-- ICU -->
 <MicrosoftNETCoreRuntimeICUTransportVersion>8.0.0-alpha.1.22553.1</MicrosoftNETCoreRuntimeICUTransportVersion>
 <!-- MsQuic -->
Expand Down

8 changes: 8 additions & 0 deletions
eng/pipelines/common/evaluate-default-paths.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,7 @@ jobs:
 - src/libraries/*
 - src/native/libs/*
 - src/tests/*
 - src/tools/*
 - eng/pipelines/installer/*
 - eng/pipelines/mono/*
 - eng/pipelines/libraries/*
Expand DownExpand Up@@ -80,6 +81,7 @@ jobs:
 - src/libraries/*
 - src/native/libs/*
 - src/tests/*
 - src/tools/*
 - eng/pipelines/installer/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/libraries/*
Expand All@@ -96,6 +98,7 @@ jobs:
 - src/mono/*
 - src/coreclr/*
 - src/tests/*
 - src/tools/*
 - src/native/eventpipe/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/mono/*
Expand All@@ -107,6 +110,10 @@ jobs:
 include:
 - src/tests/*

 - subset: tools_illink
 include:
 - src/tools/illink/*

 - subset: non_runtimetests
 exclude:
 - src/tests/*
Expand All@@ -127,6 +134,7 @@ jobs:
 - src/mono/*
 - src/libraries/*
 - src/tests/*
 - src/tools/*
 - src/native/eventpipe/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/mono/*
Expand Down

81 changes: 81 additions & 0 deletions
eng/pipelines/runtime-tools-tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
# The purpose of this pipeline is to run the trimming tests. These tests ensure trimming is
# done correctly and also that our APIs are trimming safe.

trigger:
 batch: true
 branches:
 include:
 - release/*.*
 paths:
 include:
 - '*'
 exclude:
 - '**.md'
 - eng/Version.Details.xml
 - .devcontainer/*
 - .github/*
 - docs/*
 - LICENSE.TXT
 - PATENTS.TXT
 - THIRD-PARTY-NOTICES.TXT

schedules:
 - cron: "0 7,19 * * *" # run at 7:00 and 19:00 (UTC) which is 23:00 and 11:00 (PST).
 displayName: Runtime-tools-tests default schedule
 branches:
 include:
 - main
 always: false # run only if there were changes since the last successful scheduled run.

pr:
 branches:
 include:
 - main
 - release/*.*
 paths:
 include:
 - '*'
 exclude:
 - '**.md'
 - eng/Version.Details.xml
 - .devcontainer/*
 - .github/*
 - docs/*
 - LICENSE.TXT
 - PATENTS.TXT
 - THIRD-PARTY-NOTICES.TXT

variables:
 - template: /eng/pipelines/common/variables.yml

extends:
 template: /eng/pipelines/common/templates/single-stage-pipeline-with-resources.yml
 parameters:
 jobs:

 #
 # Evaluate paths
 #
 - ${{ if eq(variables.dependOnEvaluatePaths, true) }}:
 - template: /eng/pipelines/common/evaluate-default-paths.yml

 #
 # Build Release config vertical for Windows, Linux and OSX
 #
 - template: /eng/pipelines/common/platform-matrix.yml
 parameters:
 jobTemplate: /eng/pipelines/common/global-build-job.yml
 buildConfig: release
 platforms:
 - windows_x64
 - OSX_x64
 - Linux_x64
 jobParameters:
 testGroup: innerloop
 timeoutInMinutes: 120
 nameSuffix: Runtime_Release
 condition:
 or(
 eq(dependencies.evaluate_paths.outputs['SetPathVars_tools_illink.containsChange.containsChange'], true),
 eq(variables['isRollingBuild'], true))
 buildArgs: -s tools.illinktests -c $(_BuildConfig)

3 changes: 0 additions & 3 deletions
src/tools/illink/.editorconfig

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
# top-most EditorConfig file
root = true

@ViktorHoferViktorHoferNov 8, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to consolidate the code styling in src/tools/illink with the rest of the repo? If yes, can you please open a tracking issue to remove this .editorconfig later?
@tlakollotlakolloNov 8, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the linker repo is archived and no cherry picking is being made the editorconfig will be customized to only contain a small subset of overrides from runtime global config #78050
[*.cs]
indent_style = tab
indent_size = 4
Expand Down

4 changes: 0 additions & 4 deletions
src/tools/illink/.gitattributes

View file


Open in desktop


This file was deleted.


12 changes: 0 additions & 12 deletions
src/tools/illink/.github/CODEOWNERS

View file


Open in desktop


This file was deleted.


67 changes: 0 additions & 67 deletions
src/tools/illink/.github/CONTRIBUTING.md

View file


Open in desktop


This file was deleted.


26 changes: 0 additions & 26 deletions
src/tools/illink/.github/move.yml

View file


Open in desktop


This file was deleted.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Linker into runtime diff2#78049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tlakollo
merged 6 commits into

from

Nov 9, 2022
 Merged


Linker into runtime diff2
#78049
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
8d3a70c

Merge and remove common files

Nov 8, 2022
62be15a

Create a variable for the tools folder in runtime

Nov 8, 2022
f28af1b

Refactorings to make test work

Nov 8, 2022
251c773

Enable pipeline

Nov 8, 2022
c82ed89

Fix Markdown lint

Nov 8, 2022
f35a0d2

PR feedback

Nov 9, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 8 additions & 0 deletions
.github/CODEOWNERS

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,14 @@

/eng/pipelines/**/*wasm* @radical

# ILLink codeowners
/src/tools/illink/ @marek-safar
/src/tools/illink/src/analyzer/ @radekdoulik
/src/tools/illink/src/ILLink.Tasks/ @sbomer
/src/tools/illink/src/ILLink.RoslynAnalyzer/ @sbomer
/src/tools/illink/src/linker/ @marek-safar @mrvoorhe
/src/tools/illink/test/ @marek-safar @mrvoorhe

# Obsoletions / Custom Diagnostics

/docs/project/list-of-diagnostics.md @jeffhandley
Expand Down

1 change: 1 addition & 0 deletions
Directory.Build.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@
 <MonoProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'mono'))</MonoProjectRoot>
 <InstallerProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'installer'))</InstallerProjectRoot>
 <WorkloadsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'workloads'))</WorkloadsProjectRoot>
 <ToolsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tools'))</ToolsProjectRoot>
 <SharedNativeRoot>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'native'))</SharedNativeRoot>
 <RepoToolsLocalDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'tools-local'))</RepoToolsLocalDir>
 <RepoTasksDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tasks'))</RepoTasksDir>
Expand Down

23 changes: 23 additions & 0 deletions
THIRD-PARTY-NOTICES.TXT

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1177,6 +1177,29 @@ LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

License for Jb Evain
---------------------

Copyright (c) 2006 Jb Evain (jbevain@gmail.com)

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

--- Optional exception to the license ---

As an exception, if, as a result of your compiling your source code, portions
Expand Down

27 changes: 27 additions & 0 deletions
eng/Subsets.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,8 @@
 <SubsetName Include="Clr.NativeCoreLib" Description="Run crossgen on System.Private.CoreLib library for CoreCLR." />
 <SubsetName Include="Clr.Tools" Description="Managed tools that support CoreCLR development and testing." />
 <SubsetName Include="Clr.ToolsTests" OnDemand="true" Description="Unit tests for the clr.tools subset." />
 <SubsetName Include="Tools.ILLink" Description="The projects that produce illink and analyzer tools for trimming." />
 <SubsetName Include="Tools.ILLinkTests" OnDemand="true" Description="Unit tests for the tools.illink subset." />
 <SubsetName Include="Clr.Packages" Description="The projects that produce NuGet packages for the CoreCLR runtime, crossgen, and IL tools." />
 <SubsetName Include="LinuxDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" Description="The cross-OS Windows->libc-based Linux DAC. Skipped on x86." />
 <SubsetName Include="AlpineDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" OnDemand="true" Description="The cross-OS Windows->musl-libc-based Linux DAC. Skipped on x86" />
Expand DownExpand Up@@ -326,6 +328,31 @@
 Test="true" Category="clr" Condition="'$(DotNetBuildFromSource)' != 'true' and '$(NativeAotSupported)' == 'true'"/>
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+tools.illink+'))">
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\Mono.Linker.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.Tasks\ILLink.Tasks.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\analyzer\analyzer.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.RoslynAnalyzer\ILLink.RoslynAnalyzer.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\ref\Mono.Linker.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\tlens\tlens.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.CodeFix\ILLink.CodeFixProvider.csproj" Category="tools" />
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+tools.illinktests+'))">
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests\Mono.Linker.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases\Mono.Linker.Tests.Cases.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases.Expectations\Mono.Linker.Tests.Cases.Expectations.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.Tasks.Tests\ILLink.Tasks.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests\ILLink.RoslynAnalyzer.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests.Generator\ILLink.RoslynAnalyzer.Tests.Generator.csproj"
 Test="true" Category="tools"/>
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+clr.nativecorelib+'))">
 <!-- Build crossgen2 that will be used to compile System.Private.CoreLib library for CoreCLR -->
 <ProjectToBuild Condition="'$(TargetArchitecture)' != 'x64' and '$(BuildArchitecture)' == 'x64'" Include="$(CoreClrProjectRoot)tools\aot\crossgen2\crossgen2_crossarch.csproj" Category="clr" />
Expand Down

8 changes: 8 additions & 0 deletions
eng/Version.Details.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,14 @@
 <Uri>https://github.com/dotnet/command-line-api</Uri>
 <Sha>5618b2d243ccdeb5c7e50a298b33b13036b4351b</Sha>
 </Dependency>
 <Dependency Name="Microsoft.DotNet.Cecil" Version="0.11.4-alpha.22524.1">
 <Uri>https://github.com/dotnet/cecil</Uri>
 <Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
 </Dependency>
 <Dependency Name="Microsoft.DotNet.Cecil.Pdb" Version="0.11.4-alpha.22524.1">
 <Uri>https://github.com/dotnet/cecil</Uri>
 <Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
 </Dependency>
 </ProductDependencies>
 <ToolsetDependencies>
 <Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="8.0.0-beta.22554.2">
Expand Down

9 changes: 9 additions & 0 deletions
eng/Versions.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,9 @@
 -->
 <MicrosoftCodeAnalysisVersion_LatestVS>4.4.0-2.22423.18</MicrosoftCodeAnalysisVersion_LatestVS>
 <MicrosoftCodeAnalysisVersion_LatestVS Condition="'$(DotNetBuildFromSource)' == 'true'">$(MicrosoftCodeAnalysisVersion)</MicrosoftCodeAnalysisVersion_LatestVS>
 <!-- Some of the analyzer dependencies used by ILLink project -->
 <MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>1.0.1-beta1.21265.1</MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>
 <MicrosoftCodeAnalysisBannedApiAnalyzersVersion>3.3.2</MicrosoftCodeAnalysisBannedApiAnalyzersVersion>
 </PropertyGroup>
 <!--
 These packages affect the design-time experience in VS, so we update them at the same cadance as the MicrosoftCodeAnalysisVersion_LatestVS version.
Expand DownExpand Up@@ -207,6 +210,12 @@
 <!-- ILLink -->
 <MicrosoftNETILLinkTasksVersion>7.0.100-1.22552.1</MicrosoftNETILLinkTasksVersion>
 <MicrosoftNETILLinkAnalyzerPackageVersion>$(MicrosoftNETILLinkTasksVersion)</MicrosoftNETILLinkAnalyzerPackageVersion>
 <!-- Mono Cecil -->
 <MicrosoftDotNetCecilVersion>0.11.4-alpha.22524.1</MicrosoftDotNetCecilVersion>
 <MicrosoftDotNetCecilPdbVersion>$(MicrosoftDotNetCecilVersion)</MicrosoftDotNetCecilPdbVersion>
 <!-- ILLink dependencies -->
 <MicrosoftBuildFrameworkVersion>17.0.0-preview-21267-01</MicrosoftBuildFrameworkVersion>
 <MicrosoftBuildUtilitiesCoreVersion>17.0.0-preview-21267-01</MicrosoftBuildUtilitiesCoreVersion>
 <!-- ICU -->
 <MicrosoftNETCoreRuntimeICUTransportVersion>8.0.0-alpha.1.22553.1</MicrosoftNETCoreRuntimeICUTransportVersion>
 <!-- MsQuic -->
Expand Down

8 changes: 8 additions & 0 deletions
eng/pipelines/common/evaluate-default-paths.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,7 @@ jobs:
 - src/libraries/*
 - src/native/libs/*
 - src/tests/*
 - src/tools/*
 - eng/pipelines/installer/*
 - eng/pipelines/mono/*
 - eng/pipelines/libraries/*
Expand DownExpand Up@@ -80,6 +81,7 @@ jobs:
 - src/libraries/*
 - src/native/libs/*
 - src/tests/*
 - src/tools/*
 - eng/pipelines/installer/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/libraries/*
Expand All@@ -96,6 +98,7 @@ jobs:
 - src/mono/*
 - src/coreclr/*
 - src/tests/*
 - src/tools/*
 - src/native/eventpipe/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/mono/*
Expand All@@ -107,6 +110,10 @@ jobs:
 include:
 - src/tests/*

 - subset: tools_illink
 include:
 - src/tools/illink/*

 - subset: non_runtimetests
 exclude:
 - src/tests/*
Expand All@@ -127,6 +134,7 @@ jobs:
 - src/mono/*
 - src/libraries/*
 - src/tests/*
 - src/tools/*
 - src/native/eventpipe/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/mono/*
Expand Down

81 changes: 81 additions & 0 deletions
eng/pipelines/runtime-tools-tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
# The purpose of this pipeline is to run the trimming tests. These tests ensure trimming is
# done correctly and also that our APIs are trimming safe.

trigger:
 batch: true
 branches:
 include:
 - release/*.*
 paths:
 include:
 - '*'
 exclude:
 - '**.md'
 - eng/Version.Details.xml
 - .devcontainer/*
 - .github/*
 - docs/*
 - LICENSE.TXT
 - PATENTS.TXT
 - THIRD-PARTY-NOTICES.TXT

schedules:
 - cron: "0 7,19 * * *" # run at 7:00 and 19:00 (UTC) which is 23:00 and 11:00 (PST).
 displayName: Runtime-tools-tests default schedule
 branches:
 include:
 - main
 always: false # run only if there were changes since the last successful scheduled run.

pr:
 branches:
 include:
 - main
 - release/*.*
 paths:
 include:
 - '*'
 exclude:
 - '**.md'
 - eng/Version.Details.xml
 - .devcontainer/*
 - .github/*
 - docs/*
 - LICENSE.TXT
 - PATENTS.TXT
 - THIRD-PARTY-NOTICES.TXT

variables:
 - template: /eng/pipelines/common/variables.yml

extends:
 template: /eng/pipelines/common/templates/single-stage-pipeline-with-resources.yml
 parameters:
 jobs:

 #
 # Evaluate paths
 #
 - ${{ if eq(variables.dependOnEvaluatePaths, true) }}:
 - template: /eng/pipelines/common/evaluate-default-paths.yml

 #
 # Build Release config vertical for Windows, Linux and OSX
 #
 - template: /eng/pipelines/common/platform-matrix.yml
 parameters:
 jobTemplate: /eng/pipelines/common/global-build-job.yml
 buildConfig: release
 platforms:
 - windows_x64
 - OSX_x64
 - Linux_x64
 jobParameters:
 testGroup: innerloop
 timeoutInMinutes: 120
 nameSuffix: Runtime_Release
 condition:
 or(
 eq(dependencies.evaluate_paths.outputs['SetPathVars_tools_illink.containsChange.containsChange'], true),
 eq(variables['isRollingBuild'], true))
 buildArgs: -s tools.illinktests -c $(_BuildConfig)

3 changes: 0 additions & 3 deletions
src/tools/illink/.editorconfig

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
# top-most EditorConfig file
root = true

@ViktorHoferViktorHoferNov 8, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to consolidate the code styling in src/tools/illink with the rest of the repo? If yes, can you please open a tracking issue to remove this .editorconfig later?
@tlakollotlakolloNov 8, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the linker repo is archived and no cherry picking is being made the editorconfig will be customized to only contain a small subset of overrides from runtime global config #78050
[*.cs]
indent_style = tab
indent_size = 4
Expand Down

4 changes: 0 additions & 4 deletions
src/tools/illink/.gitattributes

View file


Open in desktop


This file was deleted.


12 changes: 0 additions & 12 deletions
src/tools/illink/.github/CODEOWNERS

View file


Open in desktop


This file was deleted.


67 changes: 0 additions & 67 deletions
src/tools/illink/.github/CONTRIBUTING.md

View file


Open in desktop


This file was deleted.


26 changes: 0 additions & 26 deletions
src/tools/illink/.github/move.yml

View file


Open in desktop


This file was deleted.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Linker into runtime diff2#78049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tlakollo
merged 6 commits into

from

Nov 9, 2022
 Merged


Linker into runtime diff2
#78049
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
8d3a70c

Merge and remove common files

Nov 8, 2022
62be15a

Create a variable for the tools folder in runtime

Nov 8, 2022
f28af1b

Refactorings to make test work

Nov 8, 2022
251c773

Enable pipeline

Nov 8, 2022
c82ed89

Fix Markdown lint

Nov 8, 2022
f35a0d2

PR feedback

Nov 9, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 8 additions & 0 deletions
.github/CODEOWNERS

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,14 @@

/eng/pipelines/**/*wasm* @radical

# ILLink codeowners
/src/tools/illink/ @marek-safar
/src/tools/illink/src/analyzer/ @radekdoulik
/src/tools/illink/src/ILLink.Tasks/ @sbomer
/src/tools/illink/src/ILLink.RoslynAnalyzer/ @sbomer
/src/tools/illink/src/linker/ @marek-safar @mrvoorhe
/src/tools/illink/test/ @marek-safar @mrvoorhe

# Obsoletions / Custom Diagnostics

/docs/project/list-of-diagnostics.md @jeffhandley
Expand Down

1 change: 1 addition & 0 deletions
Directory.Build.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@
 <MonoProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'mono'))</MonoProjectRoot>
 <InstallerProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'installer'))</InstallerProjectRoot>
 <WorkloadsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'workloads'))</WorkloadsProjectRoot>
 <ToolsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tools'))</ToolsProjectRoot>
 <SharedNativeRoot>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'native'))</SharedNativeRoot>
 <RepoToolsLocalDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'tools-local'))</RepoToolsLocalDir>
 <RepoTasksDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tasks'))</RepoTasksDir>
Expand Down

23 changes: 23 additions & 0 deletions
THIRD-PARTY-NOTICES.TXT

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1177,6 +1177,29 @@ LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

License for Jb Evain
---------------------

Copyright (c) 2006 Jb Evain (jbevain@gmail.com)

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

--- Optional exception to the license ---

As an exception, if, as a result of your compiling your source code, portions
Expand Down

27 changes: 27 additions & 0 deletions
eng/Subsets.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,8 @@
 <SubsetName Include="Clr.NativeCoreLib" Description="Run crossgen on System.Private.CoreLib library for CoreCLR." />
 <SubsetName Include="Clr.Tools" Description="Managed tools that support CoreCLR development and testing." />
 <SubsetName Include="Clr.ToolsTests" OnDemand="true" Description="Unit tests for the clr.tools subset." />
 <SubsetName Include="Tools.ILLink" Description="The projects that produce illink and analyzer tools for trimming." />
 <SubsetName Include="Tools.ILLinkTests" OnDemand="true" Description="Unit tests for the tools.illink subset." />
 <SubsetName Include="Clr.Packages" Description="The projects that produce NuGet packages for the CoreCLR runtime, crossgen, and IL tools." />
 <SubsetName Include="LinuxDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" Description="The cross-OS Windows->libc-based Linux DAC. Skipped on x86." />
 <SubsetName Include="AlpineDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" OnDemand="true" Description="The cross-OS Windows->musl-libc-based Linux DAC. Skipped on x86" />
Expand DownExpand Up@@ -326,6 +328,31 @@
 Test="true" Category="clr" Condition="'$(DotNetBuildFromSource)' != 'true' and '$(NativeAotSupported)' == 'true'"/>
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+tools.illink+'))">
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\Mono.Linker.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.Tasks\ILLink.Tasks.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\analyzer\analyzer.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.RoslynAnalyzer\ILLink.RoslynAnalyzer.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\ref\Mono.Linker.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\tlens\tlens.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.CodeFix\ILLink.CodeFixProvider.csproj" Category="tools" />
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+tools.illinktests+'))">
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests\Mono.Linker.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases\Mono.Linker.Tests.Cases.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases.Expectations\Mono.Linker.Tests.Cases.Expectations.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.Tasks.Tests\ILLink.Tasks.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests\ILLink.RoslynAnalyzer.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests.Generator\ILLink.RoslynAnalyzer.Tests.Generator.csproj"
 Test="true" Category="tools"/>
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+clr.nativecorelib+'))">
 <!-- Build crossgen2 that will be used to compile System.Private.CoreLib library for CoreCLR -->
 <ProjectToBuild Condition="'$(TargetArchitecture)' != 'x64' and '$(BuildArchitecture)' == 'x64'" Include="$(CoreClrProjectRoot)tools\aot\crossgen2\crossgen2_crossarch.csproj" Category="clr" />
Expand Down

8 changes: 8 additions & 0 deletions
eng/Version.Details.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,14 @@
 <Uri>https://github.com/dotnet/command-line-api</Uri>
 <Sha>5618b2d243ccdeb5c7e50a298b33b13036b4351b</Sha>
 </Dependency>
 <Dependency Name="Microsoft.DotNet.Cecil" Version="0.11.4-alpha.22524.1">
 <Uri>https://github.com/dotnet/cecil</Uri>
 <Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
 </Dependency>
 <Dependency Name="Microsoft.DotNet.Cecil.Pdb" Version="0.11.4-alpha.22524.1">
 <Uri>https://github.com/dotnet/cecil</Uri>
 <Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
 </Dependency>
 </ProductDependencies>
 <ToolsetDependencies>
 <Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="8.0.0-beta.22554.2">
Expand Down

9 changes: 9 additions & 0 deletions
eng/Versions.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,9 @@
 -->
 <MicrosoftCodeAnalysisVersion_LatestVS>4.4.0-2.22423.18</MicrosoftCodeAnalysisVersion_LatestVS>
 <MicrosoftCodeAnalysisVersion_LatestVS Condition="'$(DotNetBuildFromSource)' == 'true'">$(MicrosoftCodeAnalysisVersion)</MicrosoftCodeAnalysisVersion_LatestVS>
 <!-- Some of the analyzer dependencies used by ILLink project -->
 <MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>1.0.1-beta1.21265.1</MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>
 <MicrosoftCodeAnalysisBannedApiAnalyzersVersion>3.3.2</MicrosoftCodeAnalysisBannedApiAnalyzersVersion>
 </PropertyGroup>
 <!--
 These packages affect the design-time experience in VS, so we update them at the same cadance as the MicrosoftCodeAnalysisVersion_LatestVS version.
Expand DownExpand Up@@ -207,6 +210,12 @@
 <!-- ILLink -->
 <MicrosoftNETILLinkTasksVersion>7.0.100-1.22552.1</MicrosoftNETILLinkTasksVersion>
 <MicrosoftNETILLinkAnalyzerPackageVersion>$(MicrosoftNETILLinkTasksVersion)</MicrosoftNETILLinkAnalyzerPackageVersion>
 <!-- Mono Cecil -->
 <MicrosoftDotNetCecilVersion>0.11.4-alpha.22524.1</MicrosoftDotNetCecilVersion>
 <MicrosoftDotNetCecilPdbVersion>$(MicrosoftDotNetCecilVersion)</MicrosoftDotNetCecilPdbVersion>
 <!-- ILLink dependencies -->
 <MicrosoftBuildFrameworkVersion>17.0.0-preview-21267-01</MicrosoftBuildFrameworkVersion>
 <MicrosoftBuildUtilitiesCoreVersion>17.0.0-preview-21267-01</MicrosoftBuildUtilitiesCoreVersion>
 <!-- ICU -->
 <MicrosoftNETCoreRuntimeICUTransportVersion>8.0.0-alpha.1.22553.1</MicrosoftNETCoreRuntimeICUTransportVersion>
 <!-- MsQuic -->
Expand Down

8 changes: 8 additions & 0 deletions
eng/pipelines/common/evaluate-default-paths.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,7 @@ jobs:
 - src/libraries/*
 - src/native/libs/*
 - src/tests/*
 - src/tools/*
 - eng/pipelines/installer/*
 - eng/pipelines/mono/*
 - eng/pipelines/libraries/*
Expand DownExpand Up@@ -80,6 +81,7 @@ jobs:
 - src/libraries/*
 - src/native/libs/*
 - src/tests/*
 - src/tools/*
 - eng/pipelines/installer/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/libraries/*
Expand All@@ -96,6 +98,7 @@ jobs:
 - src/mono/*
 - src/coreclr/*
 - src/tests/*
 - src/tools/*
 - src/native/eventpipe/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/mono/*
Expand All@@ -107,6 +110,10 @@ jobs:
 include:
 - src/tests/*

 - subset: tools_illink
 include:
 - src/tools/illink/*

 - subset: non_runtimetests
 exclude:
 - src/tests/*
Expand All@@ -127,6 +134,7 @@ jobs:
 - src/mono/*
 - src/libraries/*
 - src/tests/*
 - src/tools/*
 - src/native/eventpipe/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/mono/*
Expand Down

81 changes: 81 additions & 0 deletions
eng/pipelines/runtime-tools-tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
# The purpose of this pipeline is to run the trimming tests. These tests ensure trimming is
# done correctly and also that our APIs are trimming safe.

trigger:
 batch: true
 branches:
 include:
 - release/*.*
 paths:
 include:
 - '*'
 exclude:
 - '**.md'
 - eng/Version.Details.xml
 - .devcontainer/*
 - .github/*
 - docs/*
 - LICENSE.TXT
 - PATENTS.TXT
 - THIRD-PARTY-NOTICES.TXT

schedules:
 - cron: "0 7,19 * * *" # run at 7:00 and 19:00 (UTC) which is 23:00 and 11:00 (PST).
 displayName: Runtime-tools-tests default schedule
 branches:
 include:
 - main
 always: false # run only if there were changes since the last successful scheduled run.

pr:
 branches:
 include:
 - main
 - release/*.*
 paths:
 include:
 - '*'
 exclude:
 - '**.md'
 - eng/Version.Details.xml
 - .devcontainer/*
 - .github/*
 - docs/*
 - LICENSE.TXT
 - PATENTS.TXT
 - THIRD-PARTY-NOTICES.TXT

variables:
 - template: /eng/pipelines/common/variables.yml

extends:
 template: /eng/pipelines/common/templates/single-stage-pipeline-with-resources.yml
 parameters:
 jobs:

 #
 # Evaluate paths
 #
 - ${{ if eq(variables.dependOnEvaluatePaths, true) }}:
 - template: /eng/pipelines/common/evaluate-default-paths.yml

 #
 # Build Release config vertical for Windows, Linux and OSX
 #
 - template: /eng/pipelines/common/platform-matrix.yml
 parameters:
 jobTemplate: /eng/pipelines/common/global-build-job.yml
 buildConfig: release
 platforms:
 - windows_x64
 - OSX_x64
 - Linux_x64
 jobParameters:
 testGroup: innerloop
 timeoutInMinutes: 120
 nameSuffix: Runtime_Release
 condition:
 or(
 eq(dependencies.evaluate_paths.outputs['SetPathVars_tools_illink.containsChange.containsChange'], true),
 eq(variables['isRollingBuild'], true))
 buildArgs: -s tools.illinktests -c $(_BuildConfig)

3 changes: 0 additions & 3 deletions
src/tools/illink/.editorconfig

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
# top-most EditorConfig file
root = true

@ViktorHoferViktorHoferNov 8, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to consolidate the code styling in src/tools/illink with the rest of the repo? If yes, can you please open a tracking issue to remove this .editorconfig later?
@tlakollotlakolloNov 8, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the linker repo is archived and no cherry picking is being made the editorconfig will be customized to only contain a small subset of overrides from runtime global config #78050
[*.cs]
indent_style = tab
indent_size = 4
Expand Down

4 changes: 0 additions & 4 deletions
src/tools/illink/.gitattributes

View file


Open in desktop


This file was deleted.


12 changes: 0 additions & 12 deletions
src/tools/illink/.github/CODEOWNERS

View file


Open in desktop


This file was deleted.


67 changes: 0 additions & 67 deletions
src/tools/illink/.github/CONTRIBUTING.md

View file


Open in desktop


This file was deleted.


26 changes: 0 additions & 26 deletions
src/tools/illink/.github/move.yml

View file


Open in desktop


This file was deleted.

Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Linker into runtime diff2#78049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

tlakollo
merged 6 commits into

from

Nov 9, 2022
 Merged


Linker into runtime diff2
#78049
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
8d3a70c

Merge and remove common files

Nov 8, 2022
62be15a

Create a variable for the tools folder in runtime

Nov 8, 2022
f28af1b

Refactorings to make test work

Nov 8, 2022
251c773

Enable pipeline

Nov 8, 2022
c82ed89

Fix Markdown lint

Nov 8, 2022
f35a0d2

PR feedback

Nov 9, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 8 additions & 0 deletions
.github/CODEOWNERS

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,14 @@

/eng/pipelines/**/*wasm* @radical

# ILLink codeowners
/src/tools/illink/ @marek-safar
/src/tools/illink/src/analyzer/ @radekdoulik
/src/tools/illink/src/ILLink.Tasks/ @sbomer
/src/tools/illink/src/ILLink.RoslynAnalyzer/ @sbomer
/src/tools/illink/src/linker/ @marek-safar @mrvoorhe
/src/tools/illink/test/ @marek-safar @mrvoorhe

# Obsoletions / Custom Diagnostics

/docs/project/list-of-diagnostics.md @jeffhandley
Expand Down

1 change: 1 addition & 0 deletions
Directory.Build.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@
 <MonoProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'mono'))</MonoProjectRoot>
 <InstallerProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'installer'))</InstallerProjectRoot>
 <WorkloadsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'workloads'))</WorkloadsProjectRoot>
 <ToolsProjectRoot>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tools'))</ToolsProjectRoot>
 <SharedNativeRoot>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'src', 'native'))</SharedNativeRoot>
 <RepoToolsLocalDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'tools-local'))</RepoToolsLocalDir>
 <RepoTasksDir>$([MSBuild]::NormalizeDirectory('$(MSBuildThisFileDirectory)', 'src', 'tasks'))</RepoTasksDir>
Expand Down

23 changes: 23 additions & 0 deletions
THIRD-PARTY-NOTICES.TXT

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1177,6 +1177,29 @@ LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

License for Jb Evain
---------------------

Copyright (c) 2006 Jb Evain (jbevain@gmail.com)

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included
in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.

--- Optional exception to the license ---

As an exception, if, as a result of your compiling your source code, portions
Expand Down

27 changes: 27 additions & 0 deletions
eng/Subsets.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -126,6 +126,8 @@
 <SubsetName Include="Clr.NativeCoreLib" Description="Run crossgen on System.Private.CoreLib library for CoreCLR." />
 <SubsetName Include="Clr.Tools" Description="Managed tools that support CoreCLR development and testing." />
 <SubsetName Include="Clr.ToolsTests" OnDemand="true" Description="Unit tests for the clr.tools subset." />
 <SubsetName Include="Tools.ILLink" Description="The projects that produce illink and analyzer tools for trimming." />
 <SubsetName Include="Tools.ILLinkTests" OnDemand="true" Description="Unit tests for the tools.illink subset." />
 <SubsetName Include="Clr.Packages" Description="The projects that produce NuGet packages for the CoreCLR runtime, crossgen, and IL tools." />
 <SubsetName Include="LinuxDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" Description="The cross-OS Windows->libc-based Linux DAC. Skipped on x86." />
 <SubsetName Include="AlpineDac" Condition="$([MSBuild]::IsOsPlatform(Windows))" OnDemand="true" Description="The cross-OS Windows->musl-libc-based Linux DAC. Skipped on x86" />
Expand DownExpand Up@@ -326,6 +328,31 @@
 Test="true" Category="clr" Condition="'$(DotNetBuildFromSource)' != 'true' and '$(NativeAotSupported)' == 'true'"/>
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+tools.illink+'))">
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\Mono.Linker.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.Tasks\ILLink.Tasks.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\analyzer\analyzer.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.RoslynAnalyzer\ILLink.RoslynAnalyzer.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\linker\ref\Mono.Linker.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\tlens\tlens.csproj" Category="tools" />
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\src\ILLink.CodeFix\ILLink.CodeFixProvider.csproj" Category="tools" />
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+tools.illinktests+'))">
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests\Mono.Linker.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases\Mono.Linker.Tests.Cases.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\Mono.Linker.Tests.Cases.Expectations\Mono.Linker.Tests.Cases.Expectations.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.Tasks.Tests\ILLink.Tasks.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests\ILLink.RoslynAnalyzer.Tests.csproj"
 Test="true" Category="tools"/>
 <ProjectToBuild Include="$(ToolsProjectRoot)illink\test\ILLink.RoslynAnalyzer.Tests.Generator\ILLink.RoslynAnalyzer.Tests.Generator.csproj"
 Test="true" Category="tools"/>
 </ItemGroup>

 <ItemGroup Condition="$(_subset.Contains('+clr.nativecorelib+'))">
 <!-- Build crossgen2 that will be used to compile System.Private.CoreLib library for CoreCLR -->
 <ProjectToBuild Condition="'$(TargetArchitecture)' != 'x64' and '$(BuildArchitecture)' == 'x64'" Include="$(CoreClrProjectRoot)tools\aot\crossgen2\crossgen2_crossarch.csproj" Category="clr" />
Expand Down

8 changes: 8 additions & 0 deletions
eng/Version.Details.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,14 @@
 <Uri>https://github.com/dotnet/command-line-api</Uri>
 <Sha>5618b2d243ccdeb5c7e50a298b33b13036b4351b</Sha>
 </Dependency>
 <Dependency Name="Microsoft.DotNet.Cecil" Version="0.11.4-alpha.22524.1">
 <Uri>https://github.com/dotnet/cecil</Uri>
 <Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
 </Dependency>
 <Dependency Name="Microsoft.DotNet.Cecil.Pdb" Version="0.11.4-alpha.22524.1">
 <Uri>https://github.com/dotnet/cecil</Uri>
 <Sha>4a51257b6ac207cb7b0a51b34bfb3eab5d0dfae8</Sha>
 </Dependency>
 </ProductDependencies>
 <ToolsetDependencies>
 <Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="8.0.0-beta.22554.2">
Expand Down

9 changes: 9 additions & 0 deletions
eng/Versions.props

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -67,6 +67,9 @@
 -->
 <MicrosoftCodeAnalysisVersion_LatestVS>4.4.0-2.22423.18</MicrosoftCodeAnalysisVersion_LatestVS>
 <MicrosoftCodeAnalysisVersion_LatestVS Condition="'$(DotNetBuildFromSource)' == 'true'">$(MicrosoftCodeAnalysisVersion)</MicrosoftCodeAnalysisVersion_LatestVS>
 <!-- Some of the analyzer dependencies used by ILLink project -->
 <MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>1.0.1-beta1.21265.1</MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>
 <MicrosoftCodeAnalysisBannedApiAnalyzersVersion>3.3.2</MicrosoftCodeAnalysisBannedApiAnalyzersVersion>
 </PropertyGroup>
 <!--
 These packages affect the design-time experience in VS, so we update them at the same cadance as the MicrosoftCodeAnalysisVersion_LatestVS version.
Expand DownExpand Up@@ -207,6 +210,12 @@
 <!-- ILLink -->
 <MicrosoftNETILLinkTasksVersion>7.0.100-1.22552.1</MicrosoftNETILLinkTasksVersion>
 <MicrosoftNETILLinkAnalyzerPackageVersion>$(MicrosoftNETILLinkTasksVersion)</MicrosoftNETILLinkAnalyzerPackageVersion>
 <!-- Mono Cecil -->
 <MicrosoftDotNetCecilVersion>0.11.4-alpha.22524.1</MicrosoftDotNetCecilVersion>
 <MicrosoftDotNetCecilPdbVersion>$(MicrosoftDotNetCecilVersion)</MicrosoftDotNetCecilPdbVersion>
 <!-- ILLink dependencies -->
 <MicrosoftBuildFrameworkVersion>17.0.0-preview-21267-01</MicrosoftBuildFrameworkVersion>
 <MicrosoftBuildUtilitiesCoreVersion>17.0.0-preview-21267-01</MicrosoftBuildUtilitiesCoreVersion>
 <!-- ICU -->
 <MicrosoftNETCoreRuntimeICUTransportVersion>8.0.0-alpha.1.22553.1</MicrosoftNETCoreRuntimeICUTransportVersion>
 <!-- MsQuic -->
Expand Down

8 changes: 8 additions & 0 deletions
eng/pipelines/common/evaluate-default-paths.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -52,6 +52,7 @@ jobs:
 - src/libraries/*
 - src/native/libs/*
 - src/tests/*
 - src/tools/*
 - eng/pipelines/installer/*
 - eng/pipelines/mono/*
 - eng/pipelines/libraries/*
Expand DownExpand Up@@ -80,6 +81,7 @@ jobs:
 - src/libraries/*
 - src/native/libs/*
 - src/tests/*
 - src/tools/*
 - eng/pipelines/installer/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/libraries/*
Expand All@@ -96,6 +98,7 @@ jobs:
 - src/mono/*
 - src/coreclr/*
 - src/tests/*
 - src/tools/*
 - src/native/eventpipe/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/mono/*
Expand All@@ -107,6 +110,10 @@ jobs:
 include:
 - src/tests/*

 - subset: tools_illink
 include:
 - src/tools/illink/*

 - subset: non_runtimetests
 exclude:
 - src/tests/*
Expand All@@ -127,6 +134,7 @@ jobs:
 - src/mono/*
 - src/libraries/*
 - src/tests/*
 - src/tools/*
 - src/native/eventpipe/*
 - eng/pipelines/coreclr/*
 - eng/pipelines/mono/*
Expand Down

81 changes: 81 additions & 0 deletions
eng/pipelines/runtime-tools-tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
# The purpose of this pipeline is to run the trimming tests. These tests ensure trimming is
# done correctly and also that our APIs are trimming safe.

trigger:
 batch: true
 branches:
 include:
 - release/*.*
 paths:
 include:
 - '*'
 exclude:
 - '**.md'
 - eng/Version.Details.xml
 - .devcontainer/*
 - .github/*
 - docs/*
 - LICENSE.TXT
 - PATENTS.TXT
 - THIRD-PARTY-NOTICES.TXT

schedules:
 - cron: "0 7,19 * * *" # run at 7:00 and 19:00 (UTC) which is 23:00 and 11:00 (PST).
 displayName: Runtime-tools-tests default schedule
 branches:
 include:
 - main
 always: false # run only if there were changes since the last successful scheduled run.

pr:
 branches:
 include:
 - main
 - release/*.*
 paths:
 include:
 - '*'
 exclude:
 - '**.md'
 - eng/Version.Details.xml
 - .devcontainer/*
 - .github/*
 - docs/*
 - LICENSE.TXT
 - PATENTS.TXT
 - THIRD-PARTY-NOTICES.TXT

variables:
 - template: /eng/pipelines/common/variables.yml

extends:
 template: /eng/pipelines/common/templates/single-stage-pipeline-with-resources.yml
 parameters:
 jobs:

 #
 # Evaluate paths
 #
 - ${{ if eq(variables.dependOnEvaluatePaths, true) }}:
 - template: /eng/pipelines/common/evaluate-default-paths.yml

 #
 # Build Release config vertical for Windows, Linux and OSX
 #
 - template: /eng/pipelines/common/platform-matrix.yml
 parameters:
 jobTemplate: /eng/pipelines/common/global-build-job.yml
 buildConfig: release
 platforms:
 - windows_x64
 - OSX_x64
 - Linux_x64
 jobParameters:
 testGroup: innerloop
 timeoutInMinutes: 120
 nameSuffix: Runtime_Release
 condition:
 or(
 eq(dependencies.evaluate_paths.outputs['SetPathVars_tools_illink.containsChange.containsChange'], true),
 eq(variables['isRollingBuild'], true))
 buildArgs: -s tools.illinktests -c $(_BuildConfig)

3 changes: 0 additions & 3 deletions
src/tools/illink/.editorconfig

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
# top-most EditorConfig file
root = true

@ViktorHoferViktorHoferNov 8, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to consolidate the code styling in src/tools/illink with the rest of the repo? If yes, can you please open a tracking issue to remove this .editorconfig later?
@tlakollotlakolloNov 8, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the linker repo is archived and no cherry picking is being made the editorconfig will be customized to only contain a small subset of overrides from runtime global config #78050
[*.cs]
indent_style = tab
indent_size = 4
Expand Down

4 changes: 0 additions & 4 deletions
src/tools/illink/.gitattributes

View file


Open in desktop


This file was deleted.


12 changes: 0 additions & 12 deletions
src/tools/illink/.github/CODEOWNERS

View file


Open in desktop


This file was deleted.


67 changes: 0 additions & 67 deletions
src/tools/illink/.github/CONTRIBUTING.md

View file


Open in desktop


This file was deleted.


26 changes: 0 additions & 26 deletions
src/tools/illink/.github/move.yml

View file


Open in desktop


This file was deleted.

Loading