Uh oh!
There was an error while loading. Please reload this page.
[wasm][debugger] Fix justMyCode behavior - #78066
Merged
Merged
Conversation
thaystg
commented
Nov 11, 2022
MemberAuthor
/backport to release/7.0 |
Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3444998775 |
radical
commented
Nov 14, 2022
Member
Could you please describe the issue being fixed here? |
thaystg
commented
Nov 14, 2022
MemberAuthor
There isn't any issue. Daniel Roth was testing and talked to me on teams about it. |
thaystg
commented
Nov 18, 2022
MemberAuthor
@radical will we merge or do you want any other change? |
radical
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DotnetDebugger.setDebuggerPropertydoes not depend of having a session.It is difficult to test things that uses sessionId as we don't have it on our debugger-tests.
Behavior without this PR: To make JustMyCode work the customer needs to turn off and turn on it after the app is already running, otherwise the default behavior is that JustMyCode is turned off.