Skip to content

Implement abstraction for marshalling direction in the generator APIs - #78196

Merged
jkoritzinsky merged 2 commits into
dotnet:mainfrom
jkoritzinsky:marshal-direction
Nov 19, 2022
Merged

Implement abstraction for marshalling direction in the generator APIs#78196
jkoritzinsky merged 2 commits into
dotnet:mainfrom
jkoritzinsky:marshal-direction

Conversation

@jkoritzinsky

Copy link
Copy Markdown
Member

Use MarshalDirection to provide a nice abstraction for determining whether we're marshalling a parameter/return value/etc from managed to unmanaged or vice versa. This abstraction will be useful when enabling unmanaged->managed stubs as we won't need to go update every marshalling generator to correctly understand what to do.

Also rename some members from "in/out/ref" to use the direction-based names.

Extracted from #77130

…ether we're marshalling a parameter/return value/etc from managed to unmanaged or vice versa. This abstraction will be useful when enabling unmanaged->managed stubs as we won't need to go update every marshalling generator to correctly understand what to do.
Also rename some members from "in/out/ref" to use the direction-based names.
@jkoritzinskyjkoritzinsky added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels Nov 10, 2022
@jkoritzinskyjkoritzinsky added this to the 8.0.0 milestone Nov 10, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Use MarshalDirection to provide a nice abstraction for determining whether we're marshalling a parameter/return value/etc from managed to unmanaged or vice versa. This abstraction will be useful when enabling unmanaged->managed stubs as we won't need to go update every marshalling generator to correctly understand what to do.

Also rename some members from "in/out/ref" to use the direction-based names.

Extracted from #77130

Author:jkoritzinsky
Assignees:-
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone:8.0.0

@jkoritzinsky

Copy link
Copy Markdown
MemberAuthor

All failures are tracked by known issues (#78599), so merging in.

@jkoritzinsky
jkoritzinsky merged commit 6519ec2 into dotnet:mainNov 19, 2022
@jkoritzinsky
jkoritzinsky deleted the marshal-direction branch November 19, 2022 18:04
@ghostghost locked as resolved and limited conversation to collaborators Dec 19, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtime.InteropServicessource-generatorIndicates an issue with a source generator feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jkoritzinsky@elinor-fung