Skip to content

[release/7.0] Ensure ReadBufferState resets any BOM offsets every time the buffer is advanced. - #78235

Merged
carlossanlop merged 3 commits into
release/7.0from
backport/pr-78221-to-release/7.0
Nov 11, 2022
Merged

[release/7.0] Ensure ReadBufferState resets any BOM offsets every time the buffer is advanced.#78235
carlossanlop merged 3 commits into
release/7.0from
backport/pr-78221-to-release/7.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Nov 11, 2022

Copy link
Copy Markdown
Contributor

Backport of #78221 to release/7.0

/cc @eiriktsarpalis

Customer Impact

Addresses an issue reported by a partner team. A change in #70430 regressed BOM handling in async deserialization, which under certain circumstances can result in a small number of bytes being skipped by the reader.

Testing

Added a regression covering the reported issues. Updates the async serialization stress testing harness so that the BOM character is injected in payloads.

Risk

Low. Makes a targeted change to production code addressing the bug in question.

@eiriktsarpalis
eiriktsarpalis self-requested a review November 11, 2022 18:02
@eiriktsarpaliseiriktsarpalis self-assigned this Nov 11, 2022
@eiriktsarpaliseiriktsarpalis added this to the 7.0.x milestone Nov 11, 2022
@eiriktsarpaliseiriktsarpalis added the Servicing-consider Issue for next servicing release review label Nov 11, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #78221 to release/7.0

/cc @eiriktsarpalis

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-System.Text.Json

Milestone:-

@eiriktsarpalis

Copy link
Copy Markdown
Member

Approved by Tactics over email.

@carlossanlop

carlossanlop commented Nov 11, 2022

Copy link
Copy Markdown
Contributor

Approved by Tactics and signed off.
CI failure is known and unrelated: #77988
This change needs OOB package authoring changes but they have already been merged into release/7.0 in a previous fix that also needs to go into 7.0.1:

<IsPackable>true</IsPackable>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<ServicingVersion>1</ServicingVersion>

Ready to merge. :shipit:

@carlossanlop
carlossanlop merged commit 1c341de into release/7.0Nov 11, 2022
@carlossanlop
carlossanlop deleted the backport/pr-78221-to-release/7.0 branch November 11, 2022 22:56
@steveharter
steveharter self-requested a review November 12, 2022 15:38
@ghostghost locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Text.JsonServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@eiriktsarpalis@carlossanlop