Skip to content

[release/7.0] Mono musl support (backport #76500) - #78273

Closed
ayakael wants to merge 1 commit into
dotnet:release/7.0from
ayakael:backport/pr-76500-to-release/7.0
Closed

[release/7.0] Mono musl support (backport #76500)#78273
ayakael wants to merge 1 commit into
dotnet:release/7.0from
ayakael:backport/pr-76500-to-release/7.0

Conversation

@ayakael

@ayakaelayakael commented Nov 12, 2022

Copy link
Copy Markdown
Contributor

Backport of #76500 to release/7.0

/cc: @am11

Customer Impact

Permits building of mono-flavored runtme on mono-based systems like Alpine Linux. Without this patch, build fails on ppc64le and s390x platforms. This would presumably cover all other mono-supported platforms as well.

Testing

  • unit tests in ci
  • source-build build within Alpine environment passes

Risk

Low as most of the modifications only expresses themselves when musl-based system is detected.

@ghostghost added area-Infrastructure-mono community-contribution Indicates that the PR has been added by a community member labels Nov 12, 2022
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #76500 to release/7.0

Customer Impact

Permits building of mono-flavored runtme on mono-based systems like Alpine Linux. Without this patch, build fails on ppc64le and s390x platforms. This would presumably cover all other mono-supported platforms as well.

Testing

  • unit tests in ci
  • source-build build within Alpine environment passes

Risk

Low as most of the modifications only expresses themselves when musl-based system is detected.

Author:ayakael
Assignees:-
Labels:

area-Infrastructure-mono

Milestone:-

@carlossanlop

Copy link
Copy Markdown
Contributor

I see native code changes in this PR, so it might have to go through Tactics. Do we need this in 7.0.1? Today was the deadline for merging backports for the December release.

@ayakael

Copy link
Copy Markdown
ContributorAuthor

I see native code changes in this PR, so it might have to go through Tactics. Do we need this in 7.0.1? Today was the deadline for merging backports for the December release.

There is no rush. On Alpine we use our in-house patching mechanisms.

@akoeplinger

Copy link
Copy Markdown
Member

Let's please focus on #76500 first before creating 6.0/7.0 backports. We can do the backports once the main change is in. Closing this in the meantime, thanks 👍

@am11

am11 commented Nov 16, 2022

Copy link
Copy Markdown
Member

On Alpine we use our in-house patching mechanisms.

This is the right way. Normally we don't backport new platform addition, so there is no need to backport these changes. There was no testing done during the development cycle on these platforms.

@ayakael

Copy link
Copy Markdown
ContributorAuthor

On Alpine we use our in-house patching mechanisms.

This is the right way. Normally we don't backport new platform addition, so there is no need to backport these changes. There was no testing done during the development cycle on these platforms.

Copy that. I backported due to Fedora supporting s390x for .NET 6. If it is not desirable we can keep this closed then.

@ghostghost locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-monocommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ayakael@carlossanlop@akoeplinger@am11