Uh oh!
There was an error while loading. Please reload this page.
Adding check on R2RDump - #78343
Merged
Merged
Conversation
added 5 commits
November 14, 2022 11:55
BrianBohe
commented
Nov 14, 2022
MemberAuthor
Changes on src/tests/Common/CLRTest.CrossGen.targets will impact on pipelines. How can we test the changes on BasicTests and FrameworkTests? |
BrianBohe
commented
Nov 14, 2022
MemberAuthor
I succeeded buildling BasicTests and FrameworkTests with |
BrianBohe
commented
Nov 16, 2022
MemberAuthor
All errors are known errors so I will continue and merge this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing with @cshungcomment.
There shouldn't be variable debug information reported with an empty range. This PR adds the validation check to existent function validation taken place when dumping R2R images. Check is not applied by default, and a command line argument of R2RDump is added to run it. The argument is added to existent projects running tests with R2RDump.