Uh oh!
There was an error while loading. Please reload this page.
Remove invalidation of whitespace in TryGetNextExtendedAttribute - #78465
Conversation
ghost
commented
Nov 16, 2022
Tagging subscribers to this area: @dotnet/area-system-io |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
carlossanlop
left a comment
There was a problem hiding this comment.
Aside from the extra test request, LGTM.
stephentoub
commented
Nov 18, 2022
I've added the test @carlossanlop requested. I have not changed the existing starting whitespace trimming behavior. @carlossanlop, can you please follow-up on that if it should be revisited? Also, should we be looking at backporting this to release/7.0? |
It's not explicitly mentioned in the spec, so I agree that we should remove the trim call, especially since Yes, we can backport it all together, especially if we include the removal of the trim call. |
…attributes (#78785) * Remove invalidation of whitespace in TryGetNextExtendedAttribute (#78465) * Remove invalidation of whitespace in TryGetNextExtendedAttribute * Add requested test * Remove TrimStart in PAX extended attributes (#78707) * Remove TrimStart in PAX extended attributes * Adjust existing tests with two extra inline datas. Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> * Tar: Extra tests to confirm extra long paths are not treated as duplicate entries when the full path is in the extended attributes. (#78744) Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
#78456