Use IndexOfAnyValues in System.Net.Http by MihaZupan · Pull Request #78660 · dotnet/runtime

MihaZupan · 2022-11-21T22:14:04Z

Contributes to #78204

Example performance numbers for HttpRuleParser.IsToken taken from #78093's description:

Method	Length	Mean	Error
IndexOfAnyValues_Char	1	2.683 ns	0.0108 ns
CurrentChar	1	1.655 ns	0.0046 ns
IndexOfAnyValues_Char	7	7.184 ns	0.0185 ns
CurrentChar	7	4.989 ns	0.1115 ns
IndexOfAnyValues_Char	8	2.402 ns	0.0025 ns
CurrentChar	8	4.787 ns	0.0155 ns
IndexOfAnyValues_Char	16	2.409 ns	0.0052 ns
CurrentChar	16	9.100 ns	0.0119 ns
IndexOfAnyValues_Char	32	3.306 ns	0.0078 ns
CurrentChar	32	19.486 ns	0.5098 ns
IndexOfAnyValues_Char	100000	6,004.741 ns	4.4187 ns
CurrentChar	100000	57,569.776 ns	49.4496 ns

IndexOfAnyValues_Byte	1	1.749 ns	0.0058 ns
CurrentByte	1	1.677 ns	0.0243 ns
IndexOfAnyValues_Byte	7	4.835 ns	0.0779 ns
CurrentByte	7	5.112 ns	0.0038 ns
IndexOfAnyValues_Byte	8	2.521 ns	0.0046 ns
CurrentByte	8	5.274 ns	0.0052 ns
IndexOfAnyValues_Byte	16	2.519 ns	0.0021 ns
CurrentByte	16	9.113 ns	0.0166 ns
IndexOfAnyValues_Byte	32	3.141 ns	0.0023 ns
CurrentByte	32	19.417 ns	1.0021 ns
IndexOfAnyValues_Byte	100000	4,762.442 ns	21.2032 ns
CurrentByte	100000	57,967.138 ns	97.4594 ns

ghost · 2022-11-21T22:14:14Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #78204

Example performance numbers for HttpRuleParser.IsToken taken from #78093's description:

Method	Length	Mean	Error
IndexOfAnyValues_Char	1	2.683 ns	0.0108 ns
CurrentChar	1	1.655 ns	0.0046 ns
IndexOfAnyValues_Char	7	7.184 ns	0.0185 ns
CurrentChar	7	4.989 ns	0.1115 ns
IndexOfAnyValues_Char	8	2.402 ns	0.0025 ns
CurrentChar	8	4.787 ns	0.0155 ns
IndexOfAnyValues_Char	16	2.409 ns	0.0052 ns
CurrentChar	16	9.100 ns	0.0119 ns
IndexOfAnyValues_Char	32	3.306 ns	0.0078 ns
CurrentChar	32	19.486 ns	0.5098 ns
IndexOfAnyValues_Char	100000	6,004.741 ns	4.4187 ns
CurrentChar	100000	57,569.776 ns	49.4496 ns

IndexOfAnyValues_Byte	1	1.749 ns	0.0058 ns
CurrentByte	1	1.677 ns	0.0243 ns
IndexOfAnyValues_Byte	7	4.835 ns	0.0779 ns
CurrentByte	7	5.112 ns	0.0038 ns
IndexOfAnyValues_Byte	8	2.521 ns	0.0046 ns
CurrentByte	8	5.274 ns	0.0052 ns
IndexOfAnyValues_Byte	16	2.519 ns	0.0021 ns
CurrentByte	16	9.113 ns	0.0166 ns
IndexOfAnyValues_Byte	32	3.141 ns	0.0023 ns
CurrentByte	32	19.417 ns	1.0021 ns
IndexOfAnyValues_Byte	100000	4,762.442 ns	21.2032 ns
CurrentByte	100000	57,967.138 ns	97.4594 ns

Author:	MihaZupan
Assignees:	-
Labels:	`area-System.Net.Http`
Milestone:	8.0.0

stephentoub

Nice.

MihaZupan · 2022-11-22T14:33:13Z

I'm seeing failures on checked builds on ARM64 machines in #78678 that are likely related to changes to Encode5987 in this PR.

System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly [FAIL]
Assert.Equal() Failure
↓ (pos 4)
Expected: FileÃName.bat
Actual: File?�Name.bat
↑ (pos 4)
Stack Trace:
/_/src/libraries/System.Net.Http/tests/UnitTests/Headers/ContentDispositionHeaderValueTest.cs(211,0): at System.Net.Http.Tests.ContentDispositionHeaderValueTest.FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly()

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-78678-merge-3f1a8789e4f74bd6ac/System.Net.Http.Unit.Tests/3/console.0d41b14c.log?helixlogtype=result

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-78678-merge-7f5df04042ea41ae83/System.Net.Http.Unit.Tests/3/console.17646da3.log?helixlogtype=result

cc: @EgorBo @tannergooding - this looks like different runtime behavior for Encode5987 on checked vs non-checked ARM64 builds (likely related to the new IndexOfAnyValues APIs added in #78093).

stephentoub · 2022-11-22T14:36:00Z

It's showing up on other PRs as well.

EgorBo · 2022-11-22T14:59:31Z

I'll see if it's due to #78630 (via #78700)

jakobbotsch · 2022-11-22T15:33:34Z

+ length = utf8.Length;
+ }
+
+ Encoding.ASCII.GetChars(utf8.Slice(0, length), builder.AppendSpan(length));


Should this really be Encoding.ASCII?
Given that the failure is on alpine I wonder if it could be some locale issue?

It shouldn't be affected by locale. The input here will always be these bytes (all in the [0, 127] range).
runtime/src/libraries/System.Net.Http/src/System/Net/Http/Headers/HeaderUtilities.cs
Lines 24 to 27 in 2ae7f5d
// attr-char = ALPHA / DIGIT / "!" / "#" / "$" / "&" / "+" / "-" / "." / "^" / "_" / "`" / "|" / "~"
// ; token except ( "*" / "'" / "%" )
privatestaticreadonlyIndexOfAnyValues<byte>s_rfc5987AttrBytes=
IndexOfAnyValues.Create("!#$&+-.0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ^_`abcdefghijklmnopqrstuvwxyz|~"u8);

Makes sense, thanks. I also just noticed that there are non-alpine failures too.

https://runfo.azurewebsites.net/search/tests/?q=started%3A%7E7+definition%3Aruntime+name%3A%22FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly%22
Alpine and Ubuntu (both arm64)

EgorBo · 2022-11-22T16:27:08Z

@MihaZupan no, it's not #78630 since revert still fails 🤔

MihaZupan · 2022-11-22T17:30:12Z

Doing some tests in #78709 to try and narrow it down

Use IndexOfAnyValues in System.Net.Http
358062b

MihaZupan added the area-System.Net.Http label Nov 21, 2022

MihaZupan added this to the 8.0.0 milestone Nov 21, 2022

MihaZupan requested a review from a teamNovember 21, 2022 22:14

ghost assigned MihaZupan Nov 21, 2022

MihaZupan marked this pull request as ready for review November 21, 2022 22:14

stephentoub approved these changes Nov 21, 2022
View reviewed changes

stephentoub merged commit aa91451 into dotnet:mainNov 22, 2022

jakobbotsch reviewed Nov 22, 2022
View reviewed changes

MihaZupan mentioned this pull request Nov 22, 2022
Use IndexOfAnyValues in CoreLib #78678
Merged

MihaZupan mentioned this pull request Nov 22, 2022
CI Test #78709
Closed

MihaZupan mentioned this pull request Nov 22, 2022
FileNameStar_NeedsEncoding_EncodedAndDecodedCorrectly test is failing in CI #78718
Closed

ghost locked as resolved and limited conversation to collaborators Dec 22, 2022

Navigation Menu

Uh oh!

Use IndexOfAnyValues in System.Net.Http - #78660

Use IndexOfAnyValues in System.Net.Http#78660
stephentoub merged 1 commit into
dotnet:mainfrom
MihaZupan:indexofanyvalues-http

MihaZupan commented Nov 21, 2022

Uh oh!

ghost commented Nov 21, 2022

Uh oh!

stephentoub left a comment

Uh oh!

MihaZupan commented Nov 22, 2022•
edited
Loading

Uh oh!

stephentoub commented Nov 22, 2022

Uh oh!

EgorBo commented Nov 22, 2022

Uh oh!

jakobbotschNov 22, 2022

Uh oh!

MihaZupanNov 22, 2022

Uh oh!

jakobbotschNov 22, 2022

Uh oh!

EgorBoNov 22, 2022

Uh oh!

EgorBo commented Nov 22, 2022

Uh oh!

MihaZupan commented Nov 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	// attr-char = ALPHA / DIGIT / "!" / "#" / "$" / "&" / "+" / "-" / "." / "^" / "_" / "`" / "\|" / "~"
	// ; token except ( "*" / "'" / "%" )
	privatestaticreadonlyIndexOfAnyValues<byte>s_rfc5987AttrBytes=
	IndexOfAnyValues.Create("!#$&+-.0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ^_`abcdefghijklmnopqrstuvwxyz\|~"u8);

Uh oh!

Conversation

MihaZupan commented Nov 21, 2022

Uh oh!

ghost commented Nov 21, 2022

Uh oh!

stephentoub left a comment

Choose a reason for hiding this comment

Uh oh!

MihaZupan commented Nov 22, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stephentoub commented Nov 22, 2022

Uh oh!

EgorBo commented Nov 22, 2022

Uh oh!

jakobbotschNov 22, 2022

Choose a reason for hiding this comment

Uh oh!

MihaZupanNov 22, 2022

Choose a reason for hiding this comment

Uh oh!

jakobbotschNov 22, 2022

Choose a reason for hiding this comment

Uh oh!

EgorBoNov 22, 2022

Choose a reason for hiding this comment

Uh oh!

EgorBo commented Nov 22, 2022

Uh oh!

MihaZupan commented Nov 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MihaZupan commented Nov 22, 2022•
edited
Loading