') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [release/7.0] Fix netfx build for S.S.C.Xml nuget package by github-actions[bot] · Pull Request #78734 · dotnet/runtime · GitHub
Skip to content

[release/7.0] Fix netfx build for S.S.C.Xml nuget package - #78734

Merged
carlossanlop merged 3 commits into
release/7.0from
backport/pr-78665-to-release/7.0
Nov 23, 2022
Merged

[release/7.0] Fix netfx build for S.S.C.Xml nuget package#78734
carlossanlop merged 3 commits into
release/7.0from
backport/pr-78665-to-release/7.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Nov 22, 2022•
edited by bartonjs
Loading

Copy link
Copy Markdown
Contributor

Backport of #78665 to release/7.0

/cc @bartonjs

Customer Impact

Customers upgrading NuGet package references from 6.0.x to 7.0.0 find that the System.Security.Cryptography.Xml and System.Threading.AccessControl packages no longer work on .NET Framework, generally manifesting as a TypeLoadException when used by an intermediate library built targeting .NET Standard 2.0

Testing

Built the release/7.0 branch with this change applied, extracted the lib/net462 DLL for each package, and verified all of the typeforwards are present in the updated versions.

Risk

Low.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost

ghost commented Nov 22, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #78665 to release/7.0

/cc @bartonjs

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-Infrastructure-libraries

Milestone:-

carlossanlop
carlossanlop approved these changes Nov 22, 2022
View reviewed changes

@carlossanlopcarlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. This is tell-mode, no need to send email to Tactics.

@ViktorHofer do we need any special additional changes for the servicing on these two packages?

@carlossanlopcarlossanlop added this to the 7.0.x milestone Nov 22, 2022
@bartonjsbartonjs added the Servicing-consider Issue for next servicing release review label Nov 22, 2022
@bartonjs

bartonjs commented Nov 22, 2022

Copy link
Copy Markdown
Member

This is tell-mode, no need to send email to Tactics.

If that means I should have picked a label other than servicing-consider, then please fix my metadata 😄.

@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 23, 2022
@carlossanlop
carlossanlop merged commit 12cf8b0 into release/7.0Nov 23, 2022
@carlossanlop
carlossanlop deleted the backport/pr-78665-to-release/7.0 branch November 23, 2022 20:39
@ViktorHofer

ViktorHofer commented Nov 24, 2022

Copy link
Copy Markdown
Member

It's a regression in product code from a previous release which doesn't sound like a tell-mode change. Anyways, I see that the servicing-approved label got added so I assume Tactics already approved it.

@carlossanlopcarlossanlop removed the Servicing-approved Approved for servicing release label Nov 28, 2022
@mmitche

mmitche commented Nov 28, 2022

Copy link
Copy Markdown
Member

This isn't making December, it will make Jan.

@carlossanlop

carlossanlop commented Nov 28, 2022

Copy link
Copy Markdown
Contributor

Yes, that's alright. I just merged it in advance.

@carlossanlopcarlossanlop modified the milestones: 7.0.x, 7.0.2Nov 28, 2022
@ghostghost locked as resolved and limited conversation to collaborators Dec 28, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

7.0.2

Development

Successfully merging this pull request may close these issues.

4 participants

@bartonjs@ViktorHofer@mmitche@carlossanlop