Skip to content

[release/7.0] Explicitly omit RID from crossgen2 binary path - #78735

Merged
carlossanlop merged 1 commit into
release/7.0from
backport/pr-78733-to-release/7.0
Nov 23, 2022
Merged

[release/7.0] Explicitly omit RID from crossgen2 binary path#78735
carlossanlop merged 1 commit into
release/7.0from
backport/pr-78733-to-release/7.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

Backport of #78733 to release/7.0

/cc @jkotas

Customer Impact

Fix source-build build break. Compensate for breaking change in .NET SDK 7.0.200.

Infrastructure only fix.

Testing

Verified locally that the build break is fixed

Risk

Low

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghostghost added the area-ReadyToRun label Nov 22, 2022
@jkotasjkotas added the Servicing-consider Issue for next servicing release review label Nov 22, 2022

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nagilsonnagilson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with stipulations of #78733.

@jkotas

Copy link
Copy Markdown
Member

@carlossanlop Can this be merged?

@carlossanlop

Copy link
Copy Markdown
Contributor

Assuming this change does not need OOB package authoring changes, then it's ready, but I'll merge it when the branch reopens.
I'll mark it as servicing-approved since it's infra only.

@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 23, 2022
@carlossanlopcarlossanlop added this to the 7.0.x milestone Nov 23, 2022
@carlossanlop

Copy link
Copy Markdown
Contributor

Actually, it's blocking the build and it's only infra. I should merge.

@carlossanlop
carlossanlop merged commit de84cf9 into release/7.0Nov 23, 2022
@carlossanlop
carlossanlop deleted the backport/pr-78733-to-release/7.0 branch November 23, 2022 20:42
@ghostghost locked as resolved and limited conversation to collaborators Dec 24, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ReadyToRunServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas@carlossanlop@jeffschwMSFT@nagilson