Uh oh!
There was an error while loading. Please reload this page.
Fix configuration binding with types implementing IDictionary<,> - #78946
Conversation
ghost
commented
Nov 29, 2022
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsThe configuration binder already working with the types which implement
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Steve Dunn <steve@dunnhq.com>
https://github.com/tarekgh/runtime into FixConfigurationBindingWithTypesImplmentingDictionary
eerhardt
left a comment
There was a problem hiding this comment.
This LGTM.
I just have some nits on existing code now that this has been tweaked.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
halter73
commented
Nov 29, 2022
Can we add a test case to ensure a non-settable custom |
tarekgh
commented
Nov 30, 2022
CI failure is unrelated. merging it. |
tarekgh
commented
Nov 30, 2022
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3579305346 |
@tarekgh backporting to release/7.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix configuration binding with types implementing IDictionary
Applying: Apply suggestions from code review
Applying: Address the feedback
Applying: more feedback
error: sha1 information is lacking or useless (src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 more feedback
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
@tarekgh an error occurred while backporting to release/7.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
The configuration binder already working with the types which implement
IDictionary<,>. The problem happens when such types include members with the same names as the members ofIDictionary<,>. At that time will throwAmbiguousMatchException.#78938