Skip to content

Delete DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER workarounds - #79035

Merged
jkotas merged 1 commit into
dotnet:mainfrom
jkotas:msbuild-server
Nov 30, 2022
Merged

Delete DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER workarounds#79035
jkotas merged 1 commit into
dotnet:mainfrom
jkotas:msbuild-server

Conversation

@jkotas

Copy link
Copy Markdown
Member

This workaround is no longer needed with .NET SDK 7 GA

This workaround is no longer needed with .NET SDK 7 GA
@jkotas
jkotas requested a review from radical as a code ownerNovember 30, 2022 13:56
@ghost

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This workaround is no longer needed with .NET SDK 7 GA

Author:jkotas
Assignees:jkotas
Labels:

area-Infrastructure

Milestone:-

@ViktorHoferViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the one file under eng/common. Please also submit a patch in arcade for that.

@jkotas

Copy link
Copy Markdown
MemberAuthor

Arcade PR: dotnet/arcade#11766

@radical

Copy link
Copy Markdown
Member

IIUC, this can't be merged till we move to building with 7.0.

@jkotas

Copy link
Copy Markdown
MemberAuthor

#78034 moved us to building with .NET 7 GA. @radical Are there any other places where we still depend on .NET 7 previews?

@radical

Copy link
Copy Markdown
Member

#78034 moved us to building with .NET 7 GA. @radical Are there any other places where we still depend on .NET 7 previews?

oops, no, I'm slow!

@radical

Copy link
Copy Markdown
Member

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas

Copy link
Copy Markdown
MemberAuthor

Known failures according to the build analysis

@jkotas
jkotas merged commit 8cc8392 into dotnet:mainNov 30, 2022
@jkotas
jkotas deleted the msbuild-server branch November 30, 2022 20:56
@ghostghost locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jkotas@radical@akoeplinger@ViktorHofer