Skip to content

[wasi] compile with libs.native - #79046

Merged
pavelsavara merged 56 commits into
dotnet:mainfrom
pavelsavara:wasi_native_prep
Jan 7, 2023
Merged

[wasi] compile with libs.native#79046
pavelsavara merged 56 commits into
dotnet:mainfrom
pavelsavara:wasi_native_prep

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Nov 30, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Contributes to #65895

  • can compile mono+libs with WASI SDK
  • can run hello world sample with wasmtime
  • lot of cmake configuration and msbuild conditions
  • lot of conditional code in src/native/libs/System.Native/*
    • because WASI doesn't have nmap, threads, termio, process, signals, uuid, random, most of sockets ...
    • the changes are not trying to be perfect, this is to make it compile
  • minor changes to mono
  • moving files in src/mono/wasi folder and src/mono/samples/wasi
  • WASI SDK & wasmtime provisioning
  • compile only CI lane

out of scope, next PRs

  • any unit tests
  • trying to polyfill the gaps in POSIX layer
  • managed libraries correct annotation and PNSE

@pavelsavarapavelsavara added arch-wasm WebAssembly architecture area-Build-mono labels Nov 30, 2022
@pavelsavarapavelsavara added this to the 8.0.0 milestone Nov 30, 2022
@pavelsavarapavelsavara self-assigned this Nov 30, 2022
@ghost

ghost commented Nov 30, 2022

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #65895

  • can compile mono+libs with WASI SDK
  • can run hello world sample with wasmtime
  • log of cmake configuration and msbuild conditions
  • lot of conditional code in src/native/libs/System.Native/*
    • because WASI doesn't have nmap, threads, termio, process, signals, uuid, random, most of sockets ...
  • minor changes to mono
  • moving files in src/mono/wasi folder and src/mono/samples/wasi
  • WASI SDK & wasmtime provisioning
  • compile only CI lane

out of scope, next PRs

  • any unit tests
  • trying to polyfill the gaps in POSIX layer
  • managed libraries correct annotation and PNSE
Author:pavelsavara
Assignees:pavelsavara
Labels:

arch-wasm, area-Build-mono

Milestone:8.0.0

@pavelsavara

pavelsavara commented Nov 30, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Nov 30, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Nov 30, 2022
Closed
@build-analysisbuild-analysisBot mentioned this pull request Dec 1, 2022
Closed
marek-safar
marek-safar reviewed Dec 1, 2022
View reviewed changes
Comment threadsrc/libraries/System.Console/src/System/ConsolePal.Unix.cs Outdated
Comment threadsrc/mono/mono.proj Outdated
Comment threadsrc/mono/mono.proj
Comment threadsrc/mono/wasi/runtime/driver.c Outdated
Comment threadsrc/native/libs/System.Native/pal_threading.c Outdated
jkotas
jkotas reviewed Dec 1, 2022
View reviewed changes
Comment threadsrc/native/libs/System.Native/pal_threading.c
@pavelsavara
Merge branch 'main' into wasi_native_prep
dd71877
# Conflicts:
#	eng/targetingpacks.targets
#	src/libraries/System.IO.Compression/src/CompatibilitySuppressions.xml
#	src/libraries/System.Net.Http/src/System.Net.Http.csproj
#	src/libraries/System.Net.Primitives/src/CompatibilitySuppressions.xml
#	src/mono/wasi/sample/Directory.Build.props
#	src/mono/wasi/sample/console/Makefile
#	src/mono/wasi/sample/console/WasiConsoleApp/WasiConsoleApp.csproj
#	src/mono/wasi/sample/console/main.c
@pavelsavara
fix after merge
9b36c3b
@build-analysisbuild-analysisBot mentioned this pull request Dec 5, 2022
Open
2 tasks
@build-analysisbuild-analysisBot mentioned this pull request Dec 20, 2022
Closed
am11
am11 reviewed Dec 20, 2022
View reviewed changes
Comment threadsrc/native/libs/configure.cmake Outdated
@build-analysisbuild-analysisBot mentioned this pull request Dec 21, 2022
Closed
@pavelsavara

pavelsavara commented Dec 21, 2022

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Dec 21, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@runfoapprunfoappBot mentioned this pull request Dec 27, 2022
Closed
kg
kg reviewed Jan 2, 2023
View reviewed changes
Comment threadeng/native/gen-buildsys.cmd
@pavelsavara
Merge branch 'main' into wasi_native_prep
b172a04
# Conflicts:
#	src/libraries/System.Console/src/System.Console.csproj
#	src/libraries/System.IO.Compression/src/System.IO.Compression.csproj
#	src/libraries/System.Net.Http/src/System.Net.Http.csproj
#	src/libraries/System.Net.Primitives/src/System.Net.Primitives.csproj
@pavelsavara
feedback
edfe354
@build-analysisbuild-analysisBot mentioned this pull request Jan 3, 2023
Closed
@radical

radical commented Jan 3, 2023

Copy link
Copy Markdown
Member

Any remaining feedback here?

@pavelsavarapavelsavara changed the title [draft][wasi] compile with libs.native[wasi] compile with libs.nativeJan 3, 2023
@vargaz

vargaz commented Jan 3, 2023

Copy link
Copy Markdown
Contributor

The mono changes look ok to me.

@radical

radical commented Jan 3, 2023

Copy link
Copy Markdown
Member

The WASI changes are WIP right now, and there is follow up work for that. As long as the non-wasi-specific changes are fine, we should merge this.

@pavelsavara
Merge branch 'main' into wasi_native_prep
f7f8cb9
# Conflicts:
#	src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj
#	src/mono/mono.proj
@pavelsavara
fix merge
3a273db
@pavelsavara
fix
c1b834d
@pavelsavara

pavelsavara commented Jan 6, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jan 6, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
pavelsavara merged commit f08d13f into dotnet:mainJan 7, 2023
@SingleAccretionSingleAccretion mentioned this pull request Jan 13, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Feb 6, 2023
@pavelsavara
pavelsavara deleted the wasi_native_prep branch September 2, 2024 15:29
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safarmarek-safarmarek-safar left review comments
@akoeplingerakoeplingerakoeplinger left review comments
@jkotasjkotasjkotas left review comments
@radicalradicalradical approved these changes
@thaystgthaystgthaystg approved these changes
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@vargazvargazAwaiting requested review from vargaz
@lambdageeklambdageekAwaiting requested review from lambdageek
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
+2 more reviewers
@kgkgkg left review comments
@am11am11am11 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@pavelsavara@radical@vargaz@kg@marek-safar@akoeplinger@am11@thaystg@jkotas