Skip to content

[Android] Fix path to ping on Android API 21-27 - #79076

Merged
simonrozsival merged 1 commit into
dotnet:mainfrom
simonrozsival:fix-android-ping-path
Dec 7, 2022
Merged

[Android] Fix path to ping on Android API 21-27#79076
simonrozsival merged 1 commit into
dotnet:mainfrom
simonrozsival:fix-android-ping-path

Conversation

@simonrozsival

Copy link
Copy Markdown
Member

The path to the ping binary on Android is /system/bin/ping. Newer Androids (API 28+) have a symlink for /bin -> /system/bin, so our CI that runs tests on API 29 didn't catch it.

Ref #78990

/cc @wfurt@steveisok

@ghost

ghost commented Dec 1, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

The path to the ping binary on Android is /system/bin/ping. Newer Androids (API 28+) have a symlink for /bin -> /system/bin, so our CI that runs tests on API 29 didn't catch it.

Ref #78990

/cc @wfurt@steveisok

Author:simonrozsival
Assignees:-
Labels:

area-System.Net, os-android

Milestone:-

@simonrozsival
simonrozsival merged commit 59d56cc into dotnet:mainDec 7, 2022
@simonrozsival
simonrozsival deleted the fix-android-ping-path branch December 7, 2022 12:36
@akoeplinger

Copy link
Copy Markdown
Member

@simonrozsival should we backport this?

@simonrozsival

Copy link
Copy Markdown
MemberAuthor

I didn't think it's worth backporting but now that I've given it another thought I think we should backport it to both .NET 6 and 7.

@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3830538576

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3830541489

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@simonrozsival@akoeplinger@steveisok@karelz