Skip to content

[release/7.0][workloads] Automatically calculate the net6 patch version - #79299

Merged
carlossanlop merged 1 commit into
dotnet:release/7.0from
steveisok:calc-net6-ver
Jan 5, 2023
Merged

[release/7.0][workloads] Automatically calculate the net6 patch version#79299
carlossanlop merged 1 commit into
dotnet:release/7.0from
steveisok:calc-net6-ver

Conversation

@steveisok

Copy link
Copy Markdown
Member

Automatically calculate the net6 patch version based on the net7 patch version. This is to prevent any instance where we forget to bump it manually.

Automatically calculate the net6 patch version based on the net7 patch version. This is to prevent any instance where we forget to bump it manually.
@steveisok
steveisok requested a review from lewingDecember 6, 2022 19:05
@ghost

ghost commented Dec 6, 2022

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost assigned steveisokDec 6, 2022
@lewing

Copy link
Copy Markdown
Member

main (net8) will need to know the matching downlevel net6 and net7 versions once we start inserting it as well.

cc @marcpopMSFT

@lewinglewing added this to the 7.0.x milestone Dec 6, 2022
@lewinglewing changed the title [workloads] Automatically calculate the net6 patch version[release/7.0][workloads] Automatically calculate the net6 patch versionDec 6, 2022
@marcpopMSFT

Copy link
Copy Markdown
Member

As mentioned offline, the installer repo main branch is maintained manually unfortunately, and we haven't found a solution for that. The risk of being off on the downlevel runtimes is less though for the main branch at least.

@carlossanlop

Copy link
Copy Markdown
Contributor

@steveisok@lewing@mmitche should we get Tactics approval for this, or can we treat it as tell-mode?

BTW CI failure is known/unrelated/already fixed: #78778

@steveisok

Copy link
Copy Markdown
MemberAuthor

I think it's tell mode and should go in.

@carlossanlop

Copy link
Copy Markdown
Contributor

CI failure is known/unrelated/already fixed: #78778
Signed off.
Merging now. :shipit:

@carlossanlopcarlossanlop modified the milestones: 7.0.x, 7.0.3Jan 5, 2023
@carlossanlop
carlossanlop merged commit a947c6d into dotnet:release/7.0Jan 5, 2023
@ghostghost locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@steveisok@lewing@marcpopMSFT@carlossanlop@mmitche