Uh oh!
There was an error while loading. Please reload this page.
[wasm] fix marshaling Error to C# as JSType.Any - #79340
Merged
Merged
Conversation
ghost
commented
Dec 7, 2022
pavelsavara
commented
Dec 7, 2022
MemberAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kg
approved these changes
Dec 7, 2022
pavelsavara
commented
Dec 7, 2022
MemberAuthor
/backport to release/7.0 |
Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3641280687 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#78972
_marshal_cs_object_to_csis dynamic marshaling by type of JavaScript object.It used incomplete implementation of
Errormarshaling and created managed string reference to random pointer as result.This fix is using common method for marshaling Error, instead of the broken duplicate.