Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Fix dump creation on MacOS Ventura - #79360
Conversation
Use the task_info(TASK_DYLD_INFO) API to get the dylinker info instead of enumerating all the memory regions. This works on Ventura and simplifies the module enumeration quite a bit.
ghost
commented
Dec 7, 2022
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #79356 to release/7.0 Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
tommcdon
commented
Dec 7, 2022
Issue tracked on #79355 |
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 7.0.x
jeffschwMSFT
commented
Dec 8, 2022
cc @mmitche |
mikem8361
commented
Dec 8, 2022
I need to cherry pick my changes to this back port branch before you'all re-review. |
module is part of the core dump for the dump readers. They still need to look up the "dyld_all_image_infos" symbol.
carlossanlop
commented
Jan 4, 2023
@jeffschwMSFT@janvorli@hoyosjs@tommcdon can we get a fresh sign-off? There was a newer commit. |
carlossanlop
commented
Jan 4, 2023
Approved by Tactics (7.0.3). |
hoyosjs
commented
Jan 4, 2023
@carlossanlop all good, signed off again |
Backport of #79356 to release/7.0
Use the task_info(TASK_DYLD_INFO) API to get the dylinker info instead of enumerating all the memory regions. This now works on the new MacOS version (Ventura) and simplifies the module enumeration quite a bit.
Issue: #79355
Customer Impact
The new MacOS version, Ventura, broke core dump generation. This greatly affects VS4Mac Watson triage.
Testing
The VS4Mac team has verified fix on both x64/arm64 Ventura.
Risk
Low risk. Affects only MacOS createdump.