Fix startingStackpos tracking for loop in loop by stephentoub · Pull Request #79382 · dotnet/runtime

stephentoub · 2022-12-08T05:24:09Z

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iteration's startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

This extends the fix made earlier around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore its value.

ghost · 2022-12-08T05:24:20Z

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

Author:	stephentoub
Assignees:	-
Labels:	`area-System.Text.RegularExpressions`
Milestone:	-

…egularExpressions/RegexCompiler.cs

stephentoub · 2022-12-08T05:24:09Z

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iteration's startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

This extends the fix made earlier around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore its value.

ghost · 2022-12-08T05:24:20Z

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

Author:	stephentoub
Assignees:	-
Labels:	`area-System.Text.RegularExpressions`
Milestone:	-

…egularExpressions/RegexCompiler.cs

stephentoub · 2022-12-08T05:24:09Z

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iteration's startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

This extends the fix made earlier around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore its value.

ghost · 2022-12-08T05:24:20Z

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

Author:	stephentoub
Assignees:	-
Labels:	`area-System.Text.RegularExpressions`
Milestone:	-

…egularExpressions/RegexCompiler.cs

stephentoub · 2022-12-08T05:24:09Z

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iteration's startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

This extends the fix made earlier around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore its value.

ghost · 2022-12-08T05:24:20Z

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

Author:	stephentoub
Assignees:	-
Labels:	`area-System.Text.RegularExpressions`
Milestone:	-

…egularExpressions/RegexCompiler.cs

stephentoub · 2022-12-08T05:24:09Z

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iteration's startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

This extends the fix made earlier around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore its value.

ghost · 2022-12-08T05:24:20Z

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

Author:	stephentoub
Assignees:	-
Labels:	`area-System.Text.RegularExpressions`
Milestone:	-

…egularExpressions/RegexCompiler.cs

stephentoub · 2022-12-08T05:24:09Z

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iteration's startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

This extends the fix made earlier around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore its value.

ghost · 2022-12-08T05:24:20Z

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

Author:	stephentoub
Assignees:	-
Labels:	`area-System.Text.RegularExpressions`
Milestone:	-

…egularExpressions/RegexCompiler.cs

stephentoub · 2022-12-08T05:24:09Z

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iteration's startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

This extends the fix made earlier around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore its value.

ghost · 2022-12-08T05:24:20Z

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

Author:	stephentoub
Assignees:	-
Labels:	`area-System.Text.RegularExpressions`
Milestone:	-

…egularExpressions/RegexCompiler.cs

stephentoub · 2022-12-08T05:24:09Z

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iteration's startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

This extends the fix made earlier around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore its value.

ghost · 2022-12-08T05:24:20Z

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

This extends the fix made earlier in #79353 around proper handling of the backtracking stack in EmitLoop. If this loop is inside of another loop, then we need to preserve the startingStackpos on the backtracking stack upon successfully completing the loop, as the outer loop might iterate and cause another occurrence of this loop to run, which will then overwrite our single startingStackpos local. If that iteration backtracks, we then need to be able to pop the previous iterations startingStackpos and restore the local's value. We already do this for the other locals that impact iterations, but we should also be doing so for startingStackpos.

Author:	stephentoub
Assignees:	-
Labels:	`area-System.Text.RegularExpressions`
Milestone:	-

…egularExpressions/RegexCompiler.cs

stephentoub requested a review from joperezr December 8, 2022 05:24

ghost added the area-System.Text.RegularExpressions label Dec 8, 2022

ghost assigned stephentoub Dec 8, 2022

joperezr reviewed Dec 8, 2022
View reviewed changes

Comment thread...libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCompiler.cs

joperezr approved these changes Dec 8, 2022
View reviewed changes

stephentoub commented Dec 8, 2022
View reviewed changes

Comment thread...libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCompiler.cs

Update src/libraries/System.Text.RegularExpressions/src/System/Text/R…
ee68d5e
…egularExpressions/RegexCompiler.cs

stephentoub merged commit 41eab87 into dotnet:mainDec 8, 2022

stephentoub deleted the fixemitloopinloop branch December 8, 2022 18:54

build-analysisBot mentioned this pull request Dec 8, 2022
System.Tests.ArrayTests.CreateInstance test failing in NativeAOT #79403
Closed

ghost locked as resolved and limited conversation to collaborators Jan 7, 2023