Skip to content

Fix compression - #79412

Merged
CarnaViire merged 5 commits into
dotnet:mainfrom
greenEkatherine:fix-compress-ws-issue
Dec 12, 2022
Merged

Fix compression#79412
CarnaViire merged 5 commits into
dotnet:mainfrom
greenEkatherine:fix-compress-ws-issue

Conversation

@greenEkatherine

@greenEkatherinegreenEkatherine commented Dec 8, 2022

Copy link
Copy Markdown
Contributor

Fixes#77783

@ghostghost added the area-System.Net label Dec 8, 2022
@ghost

ghost commented Dec 8, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #77783

Author:greenEkatherine
Assignees:-
Labels:

area-System.Net

Milestone:-

MihaZupan
MihaZupan approved these changes Dec 8, 2022
View reviewed changes

@MihaZupanMihaZupan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few style nits, otherwise LGTM

Comment threadsrc/libraries/System.Net.WebSockets.Client/tests/DeflateTests.cs Outdated
Comment threadsrc/libraries/System.Net.WebSockets.Client/tests/DeflateTests.cs Outdated
Comment threadsrc/libraries/System.Net.WebSockets.Client/tests/DeflateTests.cs Outdated
Comment threadsrc/libraries/System.Net.WebSockets.Client/tests/DeflateTests.cs Outdated
Comment threadsrc/libraries/System.Net.WebSockets.Client/tests/DeflateTests.cs Outdated
Katya Sokolovaand others added 2 commits December 9, 2022 13:21
Katya Sokolova@MihaZupan
Apply suggestions from code review
f40af7f
Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Katya Sokolova
Adding SendAsync to ref
95e8abd
CarnaViire
CarnaViire reviewed Dec 9, 2022
View reviewed changes
Comment threadsrc/libraries/System.Net.WebSockets.Client/tests/DeflateTests.cs Outdated
CarnaViire
CarnaViire reviewed Dec 9, 2022
View reviewed changes
Comment threadsrc/libraries/System.Net.WebSockets.Client/tests/DeflateTests.cs Outdated
@CarnaViire
CarnaViire merged commit cab72d3 into dotnet:mainDec 12, 2022
@CarnaViire

CarnaViire commented Dec 12, 2022

Copy link
Copy Markdown
Member

/backport to release/7.0

@github-actions

github-actionsBot commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3677977293

@github-actionsgithub-actionsBot mentioned this pull request Dec 12, 2022
Merged
@CarnaViire

CarnaViire commented Dec 12, 2022

Copy link
Copy Markdown
Member

/backport to release/6.0

@github-actions

github-actionsBot commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3678041224

@github-actionsgithub-actionsBot mentioned this pull request Dec 12, 2022
Merged
@karelzkarelz mentioned this pull request Jan 6, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Jan 11, 2023
@karelzkarelz added this to the 8.0.0 milestone Mar 22, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub left review comments
@CarnaViireCarnaViireCarnaViire approved these changes
@MihaZupanMihaZupanMihaZupan approved these changes

Assignees

@greenEkatherinegreenEkatherine

Labels

area-System.Net

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Expose WebSocketMessageFlags in ClientWebSocket

5 participants

@greenEkatherine@CarnaViire@stephentoub@MihaZupan@karelz