Uh oh!
There was an error while loading. Please reload this page.
[mono][llvm] Added a null-check for 2-dim array access - #79450
Merged
Conversation
jandupej
marked this pull request as ready for review
December 12, 2022 10:59
jandupej
requested review from
SamMonoRT, lambdageek and vargaz
as code ownersDecember 12, 2022 10:59
vargaz
reviewed
Dec 16, 2022
Uh oh!
There was an error while loading. Please reload this page.
vargaz
approved these changes
Dec 16, 2022
vargaz
reviewed
Dec 19, 2022
Uh oh!
There was an error while loading. Please reload this page.
vargaz
approved these changes
Dec 20, 2022
jandupej
commented
Dec 20, 2022
ContributorAuthor
Some build failures due to 79843. |
This was referenced Dec 20, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #79022 by adding a null-check to 2-dim array accessors. This ensures that a managed exception is generated in the right place. Otherwise a native exception may be generated instead when reading inaccessible memory. This would not be caught correctly in LLVM AOT.