Skip to content

Rangelistmap with native eh free il throw on Linux - #79471

Closed
davidwrighton wants to merge 26 commits into
dotnet:mainfrom
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw
Closed

Rangelistmap with native eh free il throw on Linux#79471
davidwrighton wants to merge 26 commits into
dotnet:mainfrom
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw

Conversation

@davidwrighton

@davidwrightondavidwrighton commented Dec 9, 2022

Copy link
Copy Markdown
Member

Variation on my range map changes #79021 which show really great scaling.

  • This isn't intended for merging as @janvorli is working on a change which should be even better, but it does have the following improvement...

/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 single same
14008
/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same
30763
30828
30864
30808
30786
30842
30810
30828
30837
30852
30779
30740
/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/
david/ehperf.dll sw sync 10 single same
20314
/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same
196476
196324
196150
196011
196244
195697
196478
196497
196287
196402
196489
196419

@davidwrighton
Experimental
982daf3
@davidwrighton
Experiment
f443bfa
@davidwrighton
More progress
2fa62aa
@davidwrighton
Increase accuracy of comments around range section locking
55a5bb6
- This is improving docs on the old scheme
- Also remove the ngen specific logic
@davidwrighton
Changes to RangeListMap to make it work
f5357bb
- still with the wrong locking though...
@davidwrighton
Add low bit check indirection
1abc9c6
@davidwrighton
Rework to passing down the current locking status
5eee830
@davidwrighton
Allocation of RangeSection and freeing added, as well as testing for …
e4fb4db
…the collectible handling characteristics
@davidwrighton
Fix some naming
6505eb5
@davidwrighton
Miraculously it builds!
62b0376
@davidwrighton
May actually work. DAC access known to be broken.
ebadf2a
@davidwrighton
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto rangeli…
c6fb27c
…stmap
@davidwrighton
Fix handling of unwind table
3ecfff8
@davidwrighton
Seems to work well on WinX64
209877b
Now that it is profileable, there are tweaks to be made
@davidwrighton
Fix performance of the DelegateConstruct method
50712b7
- Implement a fast path for determining that an instruction pointer is a FixupPrecode/StubPrecode. It turns out those are more likely, than actual jitted code (as we typically have wrapper stubs of some form at this point).
- Implement a fast path for computing the number of arguments to a method instead of using MetaSig.
- Remove fancy locking scheme from RangeSectionMap. The existing fancy locking scheme works fine.
- Fix bug in ExecutionManager::IsReadyToRun and ExecutionManager::FindReadyToRunModule where locks were not used
@davidwrighton
It should build everywhere now
38acd5c
@davidwrighton
Delete temporary bits
9148e31
@davidwrighton
Fix Windows builds
dce4bb1
@davidwrighton
Fix contract issues
518011c
@davidwrighton
Fix CodeRangeMapRangeList to handle interval correctly
6db0e70
@davidwrighton
It builds on Linux!
c8a74e2
@davidwrighton
Make it even more lock free
2a012b2
@davidwrighton
Remove confusion around Range interval specification Some uses were r…
de97c17
…elying on [,) semantics and some were [,]
@davidwrighton
Attempt to appease the GCC build
a493cde
@davidwrighton
Fix the math around fragment handling and index calculations
1507207
@davidwrighton
Remove use of native EH from the IL_Throw exception path, in combinat…
8d0f9bf
…ion with the other work in this branch, produces much more scalable EH performance
@ghostghost added the area-VM-coreclr label Dec 9, 2022
@davidwrightondavidwrighton mentioned this pull request Dec 10, 2022
Merged
@ghost

ghost commented Jan 8, 2023

Copy link
Copy Markdown

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghostghost closed this Jan 8, 2023
@ghostghost locked as resolved and limited conversation to collaborators Feb 8, 2023
This pull request was closed.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky will be requested when the pull request is marked ready for reviewMichalStrehovsky is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@davidwrightondavidwrighton

Labels

area-VM-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@davidwrighton
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Rangelistmap with native eh free il throw on Linux by davidwrighton · Pull Request #79471 · dotnet/runtime · GitHub
Skip to content
Rangelistmap with native eh free il throw on Linux - #79471
Closed
davidwrighton wants to merge 26 commits into
dotnet:mainfrom 
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw
Closed
Rangelistmap with native eh free il throw on Linux#79471
davidwrighton wants to merge 26 commits into
dotnet:mainfrom 
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw
Conversation
@davidwrighton
@davidwrightondavidwrighton
commented
Dec 9, 2022

Copy link


Copy Markdown

Member
Variation on my range map changes #79021 which show really great scaling.
  • This isn't intended for merging as @janvorli is working on a change which should be even better, but it does have the following improvement...
/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 single same

14008

/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same

30763

30828

30864

30808

30786

30842

30810

30828

30837

30852

30779

30740

/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/

david/ehperf.dll sw sync 10 single same

20314

/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same

196476

196324

196150

196011

196244

195697

196478

196497

196287

196402

196489

196419
@davidwrighton
Experimental
982daf3
@davidwrighton
Experiment
f443bfa
@davidwrighton
More progress
2fa62aa
@davidwrighton
Increase accuracy of comments around range section locking
55a5bb6
- This is improving docs on the old scheme
- Also remove the ngen specific logic
@davidwrighton
Changes to RangeListMap to make it work
f5357bb
- still with the wrong locking though...
@davidwrighton
Add low bit check indirection
1abc9c6
@davidwrighton
Rework to passing down the current locking status
5eee830
@davidwrighton
Allocation of RangeSection and freeing added, as well as testing for …
e4fb4db
…the collectible handling characteristics
@davidwrighton
Fix some naming
6505eb5
@davidwrighton
Miraculously it builds!
62b0376
@davidwrighton
May actually work. DAC access known to be broken.
ebadf2a
@davidwrighton
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto rangeli…
c6fb27c
…stmap
@davidwrighton
Fix handling of unwind table
3ecfff8
@davidwrighton
Seems to work well on WinX64
209877b
Now that it is profileable, there are tweaks to be made
@davidwrighton
Fix performance of the DelegateConstruct method
50712b7
- Implement a fast path for determining that an instruction pointer is a FixupPrecode/StubPrecode. It turns out those are more likely, than actual jitted code (as we typically have wrapper stubs of some form at this point).
- Implement a fast path for computing the number of arguments to a method instead of using MetaSig.
- Remove fancy locking scheme from RangeSectionMap. The existing fancy locking scheme works fine.
- Fix bug in ExecutionManager::IsReadyToRun and ExecutionManager::FindReadyToRunModule where locks were not used
@davidwrighton
It should build everywhere now
38acd5c
@davidwrighton
Delete temporary bits
9148e31
@davidwrighton
Fix Windows builds
dce4bb1
@davidwrighton
Fix contract issues
518011c
@davidwrighton
Fix CodeRangeMapRangeList to handle interval correctly
6db0e70
@davidwrighton
It builds on Linux!
c8a74e2
@davidwrighton
Make it even more lock free
2a012b2
@davidwrighton
Remove confusion around Range interval specification Some uses were r…
de97c17
…elying on [,) semantics and some were [,]
@davidwrighton
Attempt to appease the GCC build
a493cde
@davidwrighton
Fix the math around fragment handling and index calculations
1507207
@davidwrighton
Remove use of native EH from the IL_Throw exception path, in combinat…
8d0f9bf
…ion with the other work in this branch, produces much more scalable EH performance
@ghostghost
added
the 
area-VM-coreclr

label
Dec 9, 2022
@davidwrightondavidwrighton
mentioned this pull request
Dec 10, 2022
 Merged

@ghost
ghost
commented
Jan 8, 2023

Copy link


Copy Markdown

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.
@ghostghost
closed this
Jan 8, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Feb 8, 2023

This pull request was closed.

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky will be requested when the pull request is marked ready for reviewMichalStrehovsky is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@davidwrightondavidwrighton

Labels

area-VM-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@davidwrighton

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rangelistmap with native eh free il throw on Linux by davidwrighton · Pull Request #79471 · dotnet/runtime · GitHub
Skip to content
Rangelistmap with native eh free il throw on Linux - #79471
Closed
davidwrighton wants to merge 26 commits into
dotnet:mainfrom 
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw
Closed
Rangelistmap with native eh free il throw on Linux#79471
davidwrighton wants to merge 26 commits into
dotnet:mainfrom 
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw
Conversation
@davidwrighton
@davidwrightondavidwrighton
commented
Dec 9, 2022

Copy link


Copy Markdown

Member
Variation on my range map changes #79021 which show really great scaling.
  • This isn't intended for merging as @janvorli is working on a change which should be even better, but it does have the following improvement...
/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 single same

14008

/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same

30763

30828

30864

30808

30786

30842

30810

30828

30837

30852

30779

30740

/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/

david/ehperf.dll sw sync 10 single same

20314

/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same

196476

196324

196150

196011

196244

195697

196478

196497

196287

196402

196489

196419
@davidwrighton
Experimental
982daf3
@davidwrighton
Experiment
f443bfa
@davidwrighton
More progress
2fa62aa
@davidwrighton
Increase accuracy of comments around range section locking
55a5bb6
- This is improving docs on the old scheme
- Also remove the ngen specific logic
@davidwrighton
Changes to RangeListMap to make it work
f5357bb
- still with the wrong locking though...
@davidwrighton
Add low bit check indirection
1abc9c6
@davidwrighton
Rework to passing down the current locking status
5eee830
@davidwrighton
Allocation of RangeSection and freeing added, as well as testing for …
e4fb4db
…the collectible handling characteristics
@davidwrighton
Fix some naming
6505eb5
@davidwrighton
Miraculously it builds!
62b0376
@davidwrighton
May actually work. DAC access known to be broken.
ebadf2a
@davidwrighton
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto rangeli…
c6fb27c
…stmap
@davidwrighton
Fix handling of unwind table
3ecfff8
@davidwrighton
Seems to work well on WinX64
209877b
Now that it is profileable, there are tweaks to be made
@davidwrighton
Fix performance of the DelegateConstruct method
50712b7
- Implement a fast path for determining that an instruction pointer is a FixupPrecode/StubPrecode. It turns out those are more likely, than actual jitted code (as we typically have wrapper stubs of some form at this point).
- Implement a fast path for computing the number of arguments to a method instead of using MetaSig.
- Remove fancy locking scheme from RangeSectionMap. The existing fancy locking scheme works fine.
- Fix bug in ExecutionManager::IsReadyToRun and ExecutionManager::FindReadyToRunModule where locks were not used
@davidwrighton
It should build everywhere now
38acd5c
@davidwrighton
Delete temporary bits
9148e31
@davidwrighton
Fix Windows builds
dce4bb1
@davidwrighton
Fix contract issues
518011c
@davidwrighton
Fix CodeRangeMapRangeList to handle interval correctly
6db0e70
@davidwrighton
It builds on Linux!
c8a74e2
@davidwrighton
Make it even more lock free
2a012b2
@davidwrighton
Remove confusion around Range interval specification Some uses were r…
de97c17
…elying on [,) semantics and some were [,]
@davidwrighton
Attempt to appease the GCC build
a493cde
@davidwrighton
Fix the math around fragment handling and index calculations
1507207
@davidwrighton
Remove use of native EH from the IL_Throw exception path, in combinat…
8d0f9bf
…ion with the other work in this branch, produces much more scalable EH performance
@ghostghost
added
the 
area-VM-coreclr

label
Dec 9, 2022
@davidwrightondavidwrighton
mentioned this pull request
Dec 10, 2022
 Merged

@ghost
ghost
commented
Jan 8, 2023

Copy link


Copy Markdown

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.
@ghostghost
closed this
Jan 8, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Feb 8, 2023

This pull request was closed.

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky will be requested when the pull request is marked ready for reviewMichalStrehovsky is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@davidwrightondavidwrighton

Labels

area-VM-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@davidwrighton

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rangelistmap with native eh free il throw on Linux by davidwrighton · Pull Request #79471 · dotnet/runtime · GitHub
Skip to content
Rangelistmap with native eh free il throw on Linux - #79471
Closed
davidwrighton wants to merge 26 commits into
dotnet:mainfrom 
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw
Closed
Rangelistmap with native eh free il throw on Linux#79471
davidwrighton wants to merge 26 commits into
dotnet:mainfrom 
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw
Conversation
@davidwrighton
@davidwrightondavidwrighton
commented
Dec 9, 2022

Copy link


Copy Markdown

Member
Variation on my range map changes #79021 which show really great scaling.
  • This isn't intended for merging as @janvorli is working on a change which should be even better, but it does have the following improvement...
/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 single same

14008

/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same

30763

30828

30864

30808

30786

30842

30810

30828

30837

30852

30779

30740

/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/

david/ehperf.dll sw sync 10 single same

20314

/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same

196476

196324

196150

196011

196244

195697

196478

196497

196287

196402

196489

196419
@davidwrighton
Experimental
982daf3
@davidwrighton
Experiment
f443bfa
@davidwrighton
More progress
2fa62aa
@davidwrighton
Increase accuracy of comments around range section locking
55a5bb6
- This is improving docs on the old scheme
- Also remove the ngen specific logic
@davidwrighton
Changes to RangeListMap to make it work
f5357bb
- still with the wrong locking though...
@davidwrighton
Add low bit check indirection
1abc9c6
@davidwrighton
Rework to passing down the current locking status
5eee830
@davidwrighton
Allocation of RangeSection and freeing added, as well as testing for …
e4fb4db
…the collectible handling characteristics
@davidwrighton
Fix some naming
6505eb5
@davidwrighton
Miraculously it builds!
62b0376
@davidwrighton
May actually work. DAC access known to be broken.
ebadf2a
@davidwrighton
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto rangeli…
c6fb27c
…stmap
@davidwrighton
Fix handling of unwind table
3ecfff8
@davidwrighton
Seems to work well on WinX64
209877b
Now that it is profileable, there are tweaks to be made
@davidwrighton
Fix performance of the DelegateConstruct method
50712b7
- Implement a fast path for determining that an instruction pointer is a FixupPrecode/StubPrecode. It turns out those are more likely, than actual jitted code (as we typically have wrapper stubs of some form at this point).
- Implement a fast path for computing the number of arguments to a method instead of using MetaSig.
- Remove fancy locking scheme from RangeSectionMap. The existing fancy locking scheme works fine.
- Fix bug in ExecutionManager::IsReadyToRun and ExecutionManager::FindReadyToRunModule where locks were not used
@davidwrighton
It should build everywhere now
38acd5c
@davidwrighton
Delete temporary bits
9148e31
@davidwrighton
Fix Windows builds
dce4bb1
@davidwrighton
Fix contract issues
518011c
@davidwrighton
Fix CodeRangeMapRangeList to handle interval correctly
6db0e70
@davidwrighton
It builds on Linux!
c8a74e2
@davidwrighton
Make it even more lock free
2a012b2
@davidwrighton
Remove confusion around Range interval specification Some uses were r…
de97c17
…elying on [,) semantics and some were [,]
@davidwrighton
Attempt to appease the GCC build
a493cde
@davidwrighton
Fix the math around fragment handling and index calculations
1507207
@davidwrighton
Remove use of native EH from the IL_Throw exception path, in combinat…
8d0f9bf
…ion with the other work in this branch, produces much more scalable EH performance
@ghostghost
added
the 
area-VM-coreclr

label
Dec 9, 2022
@davidwrightondavidwrighton
mentioned this pull request
Dec 10, 2022
 Merged

@ghost
ghost
commented
Jan 8, 2023

Copy link


Copy Markdown

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.
@ghostghost
closed this
Jan 8, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Feb 8, 2023

This pull request was closed.

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky will be requested when the pull request is marked ready for reviewMichalStrehovsky is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@davidwrightondavidwrighton

Labels

area-VM-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@davidwrighton

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Rangelistmap with native eh free il throw on Linux by davidwrighton · Pull Request #79471 · dotnet/runtime · GitHub
Skip to content
Rangelistmap with native eh free il throw on Linux - #79471
Closed
davidwrighton wants to merge 26 commits into
dotnet:mainfrom 
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw
Closed
Rangelistmap with native eh free il throw on Linux#79471
davidwrighton wants to merge 26 commits into
dotnet:mainfrom 
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw
Conversation
@davidwrighton
@davidwrightondavidwrighton
commented
Dec 9, 2022

Copy link


Copy Markdown

Member
Variation on my range map changes #79021 which show really great scaling.
  • This isn't intended for merging as @janvorli is working on a change which should be even better, but it does have the following improvement...
/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 single same

14008

/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same

30763

30828

30864

30808

30786

30842

30810

30828

30837

30852

30779

30740

/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/

david/ehperf.dll sw sync 10 single same

20314

/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same

196476

196324

196150

196011

196244

195697

196478

196497

196287

196402

196489

196419
@davidwrighton
Experimental
982daf3
@davidwrighton
Experiment
f443bfa
@davidwrighton
More progress
2fa62aa
@davidwrighton
Increase accuracy of comments around range section locking
55a5bb6
- This is improving docs on the old scheme
- Also remove the ngen specific logic
@davidwrighton
Changes to RangeListMap to make it work
f5357bb
- still with the wrong locking though...
@davidwrighton
Add low bit check indirection
1abc9c6
@davidwrighton
Rework to passing down the current locking status
5eee830
@davidwrighton
Allocation of RangeSection and freeing added, as well as testing for …
e4fb4db
…the collectible handling characteristics
@davidwrighton
Fix some naming
6505eb5
@davidwrighton
Miraculously it builds!
62b0376
@davidwrighton
May actually work. DAC access known to be broken.
ebadf2a
@davidwrighton
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto rangeli…
c6fb27c
…stmap
@davidwrighton
Fix handling of unwind table
3ecfff8
@davidwrighton
Seems to work well on WinX64
209877b
Now that it is profileable, there are tweaks to be made
@davidwrighton
Fix performance of the DelegateConstruct method
50712b7
- Implement a fast path for determining that an instruction pointer is a FixupPrecode/StubPrecode. It turns out those are more likely, than actual jitted code (as we typically have wrapper stubs of some form at this point).
- Implement a fast path for computing the number of arguments to a method instead of using MetaSig.
- Remove fancy locking scheme from RangeSectionMap. The existing fancy locking scheme works fine.
- Fix bug in ExecutionManager::IsReadyToRun and ExecutionManager::FindReadyToRunModule where locks were not used
@davidwrighton
It should build everywhere now
38acd5c
@davidwrighton
Delete temporary bits
9148e31
@davidwrighton
Fix Windows builds
dce4bb1
@davidwrighton
Fix contract issues
518011c
@davidwrighton
Fix CodeRangeMapRangeList to handle interval correctly
6db0e70
@davidwrighton
It builds on Linux!
c8a74e2
@davidwrighton
Make it even more lock free
2a012b2
@davidwrighton
Remove confusion around Range interval specification Some uses were r…
de97c17
…elying on [,) semantics and some were [,]
@davidwrighton
Attempt to appease the GCC build
a493cde
@davidwrighton
Fix the math around fragment handling and index calculations
1507207
@davidwrighton
Remove use of native EH from the IL_Throw exception path, in combinat…
8d0f9bf
…ion with the other work in this branch, produces much more scalable EH performance
@ghostghost
added
the 
area-VM-coreclr

label
Dec 9, 2022
@davidwrightondavidwrighton
mentioned this pull request
Dec 10, 2022
 Merged

@ghost
ghost
commented
Jan 8, 2023

Copy link


Copy Markdown

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.
@ghostghost
closed this
Jan 8, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Feb 8, 2023

This pull request was closed.

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky will be requested when the pull request is marked ready for reviewMichalStrehovsky is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@davidwrightondavidwrighton

Labels

area-VM-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@davidwrighton

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rangelistmap with native eh free il throw on Linux by davidwrighton · Pull Request #79471 · dotnet/runtime · GitHub
Skip to content
Rangelistmap with native eh free il throw on Linux - #79471
Closed
davidwrighton wants to merge 26 commits into
dotnet:mainfrom 
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw
Closed
Rangelistmap with native eh free il throw on Linux#79471
davidwrighton wants to merge 26 commits into
dotnet:mainfrom 
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw
Conversation
@davidwrighton
@davidwrightondavidwrighton
commented
Dec 9, 2022

Copy link


Copy Markdown

Member
Variation on my range map changes #79021 which show really great scaling.
  • This isn't intended for merging as @janvorli is working on a change which should be even better, but it does have the following improvement...
/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 single same

14008

/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same

30763

30828

30864

30808

30786

30842

30810

30828

30837

30852

30779

30740

/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/

david/ehperf.dll sw sync 10 single same

20314

/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same

196476

196324

196150

196011

196244

195697

196478

196497

196287

196402

196489

196419
@davidwrighton
Experimental
982daf3
@davidwrighton
Experiment
f443bfa
@davidwrighton
More progress
2fa62aa
@davidwrighton
Increase accuracy of comments around range section locking
55a5bb6
- This is improving docs on the old scheme
- Also remove the ngen specific logic
@davidwrighton
Changes to RangeListMap to make it work
f5357bb
- still with the wrong locking though...
@davidwrighton
Add low bit check indirection
1abc9c6
@davidwrighton
Rework to passing down the current locking status
5eee830
@davidwrighton
Allocation of RangeSection and freeing added, as well as testing for …
e4fb4db
…the collectible handling characteristics
@davidwrighton
Fix some naming
6505eb5
@davidwrighton
Miraculously it builds!
62b0376
@davidwrighton
May actually work. DAC access known to be broken.
ebadf2a
@davidwrighton
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto rangeli…
c6fb27c
…stmap
@davidwrighton
Fix handling of unwind table
3ecfff8
@davidwrighton
Seems to work well on WinX64
209877b
Now that it is profileable, there are tweaks to be made
@davidwrighton
Fix performance of the DelegateConstruct method
50712b7
- Implement a fast path for determining that an instruction pointer is a FixupPrecode/StubPrecode. It turns out those are more likely, than actual jitted code (as we typically have wrapper stubs of some form at this point).
- Implement a fast path for computing the number of arguments to a method instead of using MetaSig.
- Remove fancy locking scheme from RangeSectionMap. The existing fancy locking scheme works fine.
- Fix bug in ExecutionManager::IsReadyToRun and ExecutionManager::FindReadyToRunModule where locks were not used
@davidwrighton
It should build everywhere now
38acd5c
@davidwrighton
Delete temporary bits
9148e31
@davidwrighton
Fix Windows builds
dce4bb1
@davidwrighton
Fix contract issues
518011c
@davidwrighton
Fix CodeRangeMapRangeList to handle interval correctly
6db0e70
@davidwrighton
It builds on Linux!
c8a74e2
@davidwrighton
Make it even more lock free
2a012b2
@davidwrighton
Remove confusion around Range interval specification Some uses were r…
de97c17
…elying on [,) semantics and some were [,]
@davidwrighton
Attempt to appease the GCC build
a493cde
@davidwrighton
Fix the math around fragment handling and index calculations
1507207
@davidwrighton
Remove use of native EH from the IL_Throw exception path, in combinat…
8d0f9bf
…ion with the other work in this branch, produces much more scalable EH performance
@ghostghost
added
the 
area-VM-coreclr

label
Dec 9, 2022
@davidwrightondavidwrighton
mentioned this pull request
Dec 10, 2022
 Merged

@ghost
ghost
commented
Jan 8, 2023

Copy link


Copy Markdown

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.
@ghostghost
closed this
Jan 8, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Feb 8, 2023

This pull request was closed.

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky will be requested when the pull request is marked ready for reviewMichalStrehovsky is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@davidwrightondavidwrighton

Labels

area-VM-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@davidwrighton

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rangelistmap with native eh free il throw on Linux by davidwrighton · Pull Request #79471 · dotnet/runtime · GitHub
Skip to content
Rangelistmap with native eh free il throw on Linux - #79471
Closed
davidwrighton wants to merge 26 commits into
dotnet:mainfrom 
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw
Closed
Rangelistmap with native eh free il throw on Linux#79471
davidwrighton wants to merge 26 commits into
dotnet:mainfrom 
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw
Conversation
@davidwrighton
@davidwrightondavidwrighton
commented
Dec 9, 2022

Copy link


Copy Markdown

Member
Variation on my range map changes #79021 which show really great scaling.
  • This isn't intended for merging as @janvorli is working on a change which should be even better, but it does have the following improvement...
/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 single same

14008

/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same

30763

30828

30864

30808

30786

30842

30810

30828

30837

30852

30779

30740

/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/

david/ehperf.dll sw sync 10 single same

20314

/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same

196476

196324

196150

196011

196244

195697

196478

196497

196287

196402

196489

196419
@davidwrighton
Experimental
982daf3
@davidwrighton
Experiment
f443bfa
@davidwrighton
More progress
2fa62aa
@davidwrighton
Increase accuracy of comments around range section locking
55a5bb6
- This is improving docs on the old scheme
- Also remove the ngen specific logic
@davidwrighton
Changes to RangeListMap to make it work
f5357bb
- still with the wrong locking though...
@davidwrighton
Add low bit check indirection
1abc9c6
@davidwrighton
Rework to passing down the current locking status
5eee830
@davidwrighton
Allocation of RangeSection and freeing added, as well as testing for …
e4fb4db
…the collectible handling characteristics
@davidwrighton
Fix some naming
6505eb5
@davidwrighton
Miraculously it builds!
62b0376
@davidwrighton
May actually work. DAC access known to be broken.
ebadf2a
@davidwrighton
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto rangeli…
c6fb27c
…stmap
@davidwrighton
Fix handling of unwind table
3ecfff8
@davidwrighton
Seems to work well on WinX64
209877b
Now that it is profileable, there are tweaks to be made
@davidwrighton
Fix performance of the DelegateConstruct method
50712b7
- Implement a fast path for determining that an instruction pointer is a FixupPrecode/StubPrecode. It turns out those are more likely, than actual jitted code (as we typically have wrapper stubs of some form at this point).
- Implement a fast path for computing the number of arguments to a method instead of using MetaSig.
- Remove fancy locking scheme from RangeSectionMap. The existing fancy locking scheme works fine.
- Fix bug in ExecutionManager::IsReadyToRun and ExecutionManager::FindReadyToRunModule where locks were not used
@davidwrighton
It should build everywhere now
38acd5c
@davidwrighton
Delete temporary bits
9148e31
@davidwrighton
Fix Windows builds
dce4bb1
@davidwrighton
Fix contract issues
518011c
@davidwrighton
Fix CodeRangeMapRangeList to handle interval correctly
6db0e70
@davidwrighton
It builds on Linux!
c8a74e2
@davidwrighton
Make it even more lock free
2a012b2
@davidwrighton
Remove confusion around Range interval specification Some uses were r…
de97c17
…elying on [,) semantics and some were [,]
@davidwrighton
Attempt to appease the GCC build
a493cde
@davidwrighton
Fix the math around fragment handling and index calculations
1507207
@davidwrighton
Remove use of native EH from the IL_Throw exception path, in combinat…
8d0f9bf
…ion with the other work in this branch, produces much more scalable EH performance
@ghostghost
added
the 
area-VM-coreclr

label
Dec 9, 2022
@davidwrightondavidwrighton
mentioned this pull request
Dec 10, 2022
 Merged

@ghost
ghost
commented
Jan 8, 2023

Copy link


Copy Markdown

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.
@ghostghost
closed this
Jan 8, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Feb 8, 2023

This pull request was closed.

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky will be requested when the pull request is marked ready for reviewMichalStrehovsky is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@davidwrightondavidwrighton

Labels

area-VM-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@davidwrighton

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Rangelistmap with native eh free il throw on Linux by davidwrighton · Pull Request #79471 · dotnet/runtime · GitHub
Skip to content
Rangelistmap with native eh free il throw on Linux - #79471
Closed
davidwrighton wants to merge 26 commits into
dotnet:mainfrom 
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw
Closed
Rangelistmap with native eh free il throw on Linux#79471
davidwrighton wants to merge 26 commits into
dotnet:mainfrom 
davidwrighton:rangelistmap_with_nativeEHFree_IL_Throw
Conversation
@davidwrighton
@davidwrightondavidwrighton
commented
Dec 9, 2022

Copy link


Copy Markdown

Member
Variation on my range map changes #79021 which show really great scaling.
  • This isn't intended for merging as @janvorli is working on a change which should be even better, but it does have the following improvement...
/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 single same

14008

/home/david/git/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same

30763

30828

30864

30808

30786

30842

30810

30828

30837

30852

30779

30740

/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/

david/ehperf.dll sw sync 10 single same

20314

/home/david/git2/runtime/artifacts/tests/coreclr/Linux.x64.Release/Tests/Core_Root/corerun /home/david/ehperf.dll sw sync 10 multi same

196476

196324

196150

196011

196244

195697

196478

196497

196287

196402

196489

196419
@davidwrighton
Experimental
982daf3
@davidwrighton
Experiment
f443bfa
@davidwrighton
More progress
2fa62aa
@davidwrighton
Increase accuracy of comments around range section locking
55a5bb6
- This is improving docs on the old scheme
- Also remove the ngen specific logic
@davidwrighton
Changes to RangeListMap to make it work
f5357bb
- still with the wrong locking though...
@davidwrighton
Add low bit check indirection
1abc9c6
@davidwrighton
Rework to passing down the current locking status
5eee830
@davidwrighton
Allocation of RangeSection and freeing added, as well as testing for …
e4fb4db
…the collectible handling characteristics
@davidwrighton
Fix some naming
6505eb5
@davidwrighton
Miraculously it builds!
62b0376
@davidwrighton
May actually work. DAC access known to be broken.
ebadf2a
@davidwrighton
Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto rangeli…
c6fb27c
…stmap
@davidwrighton
Fix handling of unwind table
3ecfff8
@davidwrighton
Seems to work well on WinX64
209877b
Now that it is profileable, there are tweaks to be made
@davidwrighton
Fix performance of the DelegateConstruct method
50712b7
- Implement a fast path for determining that an instruction pointer is a FixupPrecode/StubPrecode. It turns out those are more likely, than actual jitted code (as we typically have wrapper stubs of some form at this point).
- Implement a fast path for computing the number of arguments to a method instead of using MetaSig.
- Remove fancy locking scheme from RangeSectionMap. The existing fancy locking scheme works fine.
- Fix bug in ExecutionManager::IsReadyToRun and ExecutionManager::FindReadyToRunModule where locks were not used
@davidwrighton
It should build everywhere now
38acd5c
@davidwrighton
Delete temporary bits
9148e31
@davidwrighton
Fix Windows builds
dce4bb1
@davidwrighton
Fix contract issues
518011c
@davidwrighton
Fix CodeRangeMapRangeList to handle interval correctly
6db0e70
@davidwrighton
It builds on Linux!
c8a74e2
@davidwrighton
Make it even more lock free
2a012b2
@davidwrighton
Remove confusion around Range interval specification Some uses were r…
de97c17
…elying on [,) semantics and some were [,]
@davidwrighton
Attempt to appease the GCC build
a493cde
@davidwrighton
Fix the math around fragment handling and index calculations
1507207
@davidwrighton
Remove use of native EH from the IL_Throw exception path, in combinat…
8d0f9bf
…ion with the other work in this branch, produces much more scalable EH performance
@ghostghost
added
the 
area-VM-coreclr

label
Dec 9, 2022
@davidwrightondavidwrighton
mentioned this pull request
Dec 10, 2022
 Merged

@ghost
ghost
commented
Jan 8, 2023

Copy link


Copy Markdown

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.
@ghostghost
closed this
Jan 8, 2023
@ghostghost
locked as resolved and limited conversation to collaborators
Feb 8, 2023

This pull request was closed.

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky will be requested when the pull request is marked ready for reviewMichalStrehovsky is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@davidwrightondavidwrighton

Labels

area-VM-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@davidwrighton