Skip to content

Emit mneg for mul+neg on Arm64 - #79550

Merged
kunalspathak merged 1 commit into
dotnet:mainfrom
SwapnilGaikwad:github-emit-mneg
Jan 13, 2023
Merged

Emit mneg for mul+neg on Arm64#79550
kunalspathak merged 1 commit into
dotnet:mainfrom
SwapnilGaikwad:github-emit-mneg

Conversation

@SwapnilGaikwad

@SwapnilGaikwadSwapnilGaikwad commented Dec 12, 2022

Copy link
Copy Markdown
Contributor

Contribute towards #68028

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Dec 12, 2022
@ghost

ghost commented Dec 12, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Contribute towards #68028

Author:SwapnilGaikwad
Assignees:-
Labels:

area-CodeGen-coreclr, community-contribution

Milestone:-

@SwapnilGaikwad

SwapnilGaikwad commented Dec 12, 2022

Copy link
Copy Markdown
ContributorAuthor

Unfortunately, it didn't make the expected impact on code size.

Output from spmidiff:

Overall (-680 bytes)
CollectionBase size (bytes)Diff size (bytes)
libraries.pmi.Linux.arm64.checked.mch63,841,844-28
benchmarks.run.Linux.arm64.checked.mch29,197,468-12
coreclr_tests.run.Linux.arm64.checked.mch550,350,008-612
libraries.crossgen2.Linux.arm64.checked.mch45,202,820-28

@build-analysisbuild-analysisBot mentioned this pull request Dec 12, 2022
Closed
@a74nh

a74nh commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

Looks like the failure is a known issue.

Also: adding @kunalspathak

@a74nha74nh mentioned this pull request Dec 19, 2022
Closed
29 tasks
@JulieLeeMSFT

JulieLeeMSFT commented Jan 9, 2023

Copy link
Copy Markdown
Member

@kunalspathak, PTAL.

@kunalspathak

kunalspathak commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

/azp run runtime-coreclr superpmi-diffs

@azure-pipelines

azure-pipelinesBot commented Jan 11, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

kunalspathak
kunalspathak reviewed Jan 11, 2023
View reviewed changes
Comment threadsrc/tests/JIT/opt/InstructionCombining/NegMulOrDivToConst.cs
kunalspathak
kunalspathak reviewed Jan 11, 2023
View reviewed changes
Comment threadsrc/tests/JIT/opt/InstructionCombining/NegMulOrDivToConst.cs
kunalspathak
kunalspathak reviewed Jan 11, 2023
View reviewed changes
Comment threadsrc/tests/JIT/opt/InstructionCombining/NegMulOrDivToConst.cs
kunalspathak
kunalspathak suggested changes Jan 11, 2023
View reviewed changes

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for superpmi-diff fresh result and to add couple of more test cases.

@ghostghost added needs-author-action An issue or pull request that requires more info or actions from the author. and removed needs-author-action An issue or pull request that requires more info or actions from the author. labels Jan 11, 2023
@kunalspathak
kunalspathak merged commit 8a5b42f into dotnet:mainJan 13, 2023
@SwapnilGaikwad
SwapnilGaikwad deleted the github-emit-mneg branch January 13, 2023 15:58
@JulieLeeMSFTJulieLeeMSFT mentioned this pull request Feb 8, 2023
Closed
3 tasks
@ghostghost locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@SwapnilGaikwadSwapnilGaikwad

@kunalspathakkunalspathak

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SwapnilGaikwad@a74nh@JulieLeeMSFT@kunalspathak