') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [release/6.0] Upgrade .NET Framework queue by ViktorHofer · Pull Request #79665 · dotnet/runtime · GitHub
Skip to content

[release/6.0] Upgrade .NET Framework queue - #79665

Merged
ViktorHofer merged 2 commits into
release/6.0from
60QueueService
Jan 4, 2023
Merged

[release/6.0] Upgrade .NET Framework queue#79665
ViktorHofer merged 2 commits into
release/6.0from
60QueueService

Conversation

@ViktorHofer

@ViktorHoferViktorHofer commented Dec 14, 2022•
edited by akoeplinger
Loading

Copy link
Copy Markdown
Member

Fixes#79646
Fixes#79858

@ViktorHoferViktorHofer added this to the 6.0.x milestone Dec 14, 2022
@ghost

ghost commented Dec 14, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #79646

Author:ViktorHofer
Assignees:-
Labels:

area-Infrastructure-libraries

Milestone:-

@ViktorHofer

ViktorHofer commented Dec 14, 2022

Copy link
Copy Markdown
MemberAuthor

@mmitche do you know if the 6.0 branch is open right now? This is causing issues in the 6.0 PRs.

This was referenced Dec 14, 2022
Merged
Merged
@mmitche

mmitche commented Dec 14, 2022

Copy link
Copy Markdown
Member

Not really open right now....but runtime could update their branding for Feb and check this in.

@runfoapprunfoappBot mentioned this pull request Dec 14, 2022
Open
@akoeplingerakoeplinger mentioned this pull request Dec 20, 2022
Closed
@ViktorHoferViktorHofer mentioned this pull request Dec 29, 2022
Merged
@ViktorHofer

ViktorHofer commented Jan 4, 2023

Copy link
Copy Markdown
MemberAuthor

@akoeplinger@steveisok there are two MacCatalyst failures and one Browser failure in the PR:

src/libraries/tests.proj(416,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "XcodeBuildApp" task failed unexpectedly.
System.IO.DirectoryNotFoundException: Could not find a part of the path '/Users/runner/work/1/s/artifacts/bundles/tests.all/NormalTestAppBundles/System.Diagnostics.Process.Tests/AppBundle/Release-maccatalyst/System.Diagnostics.Process.Tests.app'.
at System.IO.Directory.Move(String sourceDirName, String destDirName)
at Xcode.BuildAppBundle(String xcodePrjPath, Boolean optimized, String devTeamProvisioning, String destination) in /_/src/tasks/AppleAppBuilder/Xcode.cs:line 529
at XcodeBuildApp.Execute() in /_/src/tasks/AppleAppBuilder/Xcode.cs:line 108
at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)

.dotnet/sdk/6.0.111/NuGet.RestoreEx.targets(19,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) The result "" of evaluating the value "$(WasmAppBuilderTasksAssemblyPath)" of the "AssemblyFile" attribute in element <UsingTask> is not valid. /__w/1/s/src/mono/wasm/wasm.proj
at Microsoft.Build.Shared.ProjectErrorUtilities.ThrowInvalidProject(String errorSubCategoryResourceName, IElementLocation elementLocation, String resourceName, Object[] args)
at Microsoft.Build.Shared.ProjectErrorUtilities.VerifyThrowInvalidProject[T1,T2,T3,T4](Boolean condition, String errorSubCategoryResourceName, IElementLocation elementLocation, String resourceName, T1 arg0, T2 arg1, T3 arg2, T4 arg3)
at Microsoft.Build.Execution.TaskRegistry.RegisterTasksFromUsingTaskElement[P,I](ILoggingService loggingService, BuildEventContext buildEventContext, String directoryOfImportingFile, ProjectUsingTaskElement projectUsingTaskXml, TaskRegistry taskRegistry, Expander`2 expander, ExpanderOptions expanderOptions, IFileSystem fileSystem)
at Microsoft.Build.Evaluation.Evaluator`4.EvaluateUsingTaskElement(String directoryOfImportingFile, ProjectUsingTaskElement projectUsingTaskElement)
at Microsoft.Build.Evaluation.Evaluator`4.Evaluate()
at Microsoft.Build.Evaluation.Evaluator`4.Evaluate(IEvaluatorData`4 data, ProjectRootElement root, ProjectLoadSettings loadSettings, Int32 maxNodeCount, PropertyDictionary`1 environmentProperties, ILoggingService loggingService, IItemFactory`2 itemFactory, IToolsetProvider toolsetProvider, ProjectRootElementCacheBase projectRootElementCache, BuildEventContext buildEventContext, ISdkResolverService sdkResolverService, Int32 submissionId, EvaluationContext evaluationContext, Boolean interactive)
at Microsoft.Build.Evaluation.Project.ProjectImpl.Reevaluate(ILoggingService loggingServiceForEvaluation, ProjectLoadSettings loadSettings, EvaluationContext evaluationContext)
at Microsoft.Build.Evaluation.Project.ProjectImpl.ReevaluateIfNecessary(ILoggingService loggingServiceForEvaluation, ProjectLoadSettings loadSettings, EvaluationContext evaluationContext)
at Microsoft.Build.Evaluation.Project.ProjectImpl.ReevaluateIfNecessary(EvaluationContext evaluationContext)
at Microsoft.Build.Evaluation.Project.ProjectImpl.Initialize(IDictionary`2 globalProperties, String toolsVersion, String subToolsetVersion, ProjectLoadSettings loadSettings, EvaluationContext evaluationContext)
at Microsoft.Build.Evaluation.Project..ctor(String projectFile, IDictionary`2 globalProperties, String toolsVersion, String subToolsetVersion, ProjectCollection projectCollection, ProjectLoadSettings loadSettings, EvaluationContext evaluationContext)
at Microsoft.Build.Evaluation.Project.FromFile(String file, ProjectOptions options)
at NuGet.Build.Tasks.Console.MSBuildStaticGraphRestore.<>c__DisplayClass38_1.<LoadProjects>b__0(String path, Dictionary`2 properties, ProjectCollection collection)
at Microsoft.Build.Graph.GraphBuilder.ParseProject(ConfigurationMetadata configurationMetadata)
at Microsoft.Build.Graph.GraphBuilder.<>c__DisplayClass35_0.<SubmitProjectForParsing>b__0()
at System.Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
at System.Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
at System.Lazy`1.CreateValue()
at System.Lazy`1.get_Value()
at Microsoft.Build.Graph.ParallelWorkSet`2.ExecuteWorkItem()
at Microsoft.Build.Graph.ParallelWorkSet`2.WaitForAllWorkAndComplete()
at Microsoft.Build.Graph.GraphBuilder.FindGraphNodes()
at Microsoft.Build.Graph.GraphBuilder.BuildGraph()
at Microsoft.Build.Graph.ProjectGraph..ctor(IEnumerable`1 entryPoints, ProjectCollection projectCollection, ProjectInstanceFactoryFunc projectInstanceFactory, Int32 degreeOfParallelism, CancellationToken cancellationToken)
at Microsoft.Build.Graph.ProjectGraph..ctor(IEnumerable`1 entryPoints, ProjectCollection projectCollection, ProjectInstanceFactoryFunc projectInstanceFactory)
at NuGet.Build.Tasks.Console.MSBuildStaticGraphRestore.LoadProjects(IEnumerable`1 entryProjects)

The second one is pretty severe as it implies that the leg is completely broken (as restore is failing). Still, as this is most likely unrelated (this PR only updates a .NET Framework queue I'm going to merge this in). Can you please take a look?

@ViktorHoferViktorHofer mentioned this pull request Jan 4, 2023
Merged
@ViktorHofer
ViktorHofer merged commit 805baca into release/6.0Jan 4, 2023
@ViktorHofer
ViktorHofer deleted the 60QueueService branch January 4, 2023 07:38
@akoeplingerakoeplinger mentioned this pull request Jan 11, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@MattGalMattGalMattGal approved these changes

Assignees

@ViktorHoferViktorHofer

Labels

area-Infrastructure

Projects

None yet

Milestone

6.0.x

Development

Successfully merging this pull request may close these issues.

4 participants

@ViktorHofer@mmitche@akoeplinger@MattGal