Uh oh!
There was an error while loading. Please reload this page.
Decommit memory as needed - #79912
Conversation
ghost
commented
Dec 22, 2022
Tagging subscribers to this area: @dotnet/gc Issue Detailsnull
|
101c2a0 to
697d713CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Maoni0
left a comment
There was a problem hiding this comment.
also it would be nice to add a comment to delete_region to specify the invariant which is when you return a region to the global region allocator, memory should be decommitted (unless it's large pages) and mark array (if committed).
2d2cea0 to
44450f1ComparePeterSolMS
commented
Jan 10, 2023
Looks good to me. Regarding Maoni's comment, I wonder if we can add an assert to |
44450f1 to
3497400Comparesebastienros
commented
Jan 13, 2023
With these commits (2ca7cf7...6aaaaaa) aspnet apps crash at runtime in the benchmarks CI. I am flagging the PR which had the potential to explain it. Crank command if you can run with and without this PR changes: |
This reverts commit 6da8e2a.
This reverts commit 6da8e2a.
This change makes sure:
Fixes#79882