Skip to content

Add support for JsonUnmappedMemberHandling - #79945

Merged
eiriktsarpalis merged 5 commits into
dotnet:mainfrom
eiriktsarpalis:feature/missing-member-handling
Jan 12, 2023
Merged

Add support for JsonUnmappedMemberHandling#79945
eiriktsarpalis merged 5 commits into
dotnet:mainfrom
eiriktsarpalis:feature/missing-member-handling

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Dec 24, 2022

Copy link
Copy Markdown
Member

Fix#37483.

@ghost

ghost commented Dec 24, 2022

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost

ghost commented Dec 24, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #37483.

Author:eiriktsarpalis
Assignees:-
Labels:

area-System.Text.Json, new-api-needs-documentation

Milestone:-

@eiriktsarpaliseiriktsarpalis added this to the 8.0.0 milestone Dec 24, 2022
eiriktsarpalis
eiriktsarpalis commented Dec 24, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerContext.cs Outdated

@eiriktsarpaliseiriktsarpalisDec 24, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here and in JsonSerializerWrapper have been picked up from #79828 (comment), since these tests also depend on them.

@build-analysisbuild-analysisBot mentioned this pull request Dec 24, 2022
Closed
pinkfloydx33
pinkfloydx33 reviewed Dec 27, 2022
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/src/Resources/Strings.resx Outdated
@eiriktsarpalis
eiriktsarpalisforce-pushed the feature/missing-member-handling branch from 442229e to 0413ffcCompareJanuary 9, 2023 15:21
@build-analysisbuild-analysisBot mentioned this pull request Jan 9, 2023
Closed
layomia
layomia reviewed Jan 9, 2023
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/gen/JsonSourceGenerator.Parser.cs Outdated
Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs Outdated
Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs Outdated
Comment thread...System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfoOfT.WriteHelpers.cs Outdated
Comment thread...es/System.Text.Json/src/System/Text/Json/Serialization/Metadata/ReflectionJsonTypeInfoOfT.cs Outdated
@eiriktsarpalis
eiriktsarpalisforce-pushed the feature/missing-member-handling branch from 0413ffc to f1647eeCompareJanuary 10, 2023 11:55
This was referenced Jan 10, 2023
Closed
Closed
Open
@eiriktsarpalis
eiriktsarpalisforce-pushed the feature/missing-member-handling branch from 31cef39 to 25844c7CompareJanuary 11, 2023 18:30
krwq
krwq reviewed Jan 12, 2023
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs Outdated
krwq
krwq reviewed Jan 12, 2023
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs Outdated
krwq
krwq approved these changes Jan 12, 2023
View reviewed changes

@krwqkrwq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some comments

@eiriktsarpalis@krwq
Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…
82068ce
…ion/Metadata/JsonTypeInfo.cs
Co-authored-by: Krzysztof Wicher <mordotymoja@gmail.com>
@eiriktsarpalis
eiriktsarpalis merged commit 870825a into dotnet:mainJan 12, 2023
@eiriktsarpalis
eiriktsarpalis deleted the feature/missing-member-handling branch January 12, 2023 22:41
@eiriktsarpaliseiriktsarpalis mentioned this pull request Feb 6, 2023
Closed
3 tasks
@ghostghost locked as resolved and limited conversation to collaborators Feb 12, 2023
@jeffhandleyjeffhandley added the blog-candidate Completed PRs that are candidate topics for blog post coverage label Mar 14, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krwqkrwqkrwq approved these changes
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
+2 more reviewers
@pinkfloydx33pinkfloydx33pinkfloydx33 left review comments
@layomialayomialayomia left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Text.Jsonblog-candidateCompleted PRs that are candidate topics for blog post coveragenew-api-needs-documentation

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Add support for MissingMemberHandling to System.Text.Json

5 participants

@eiriktsarpalis@pinkfloydx33@krwq@layomia@jeffhandley