Uh oh!
There was an error while loading. Please reload this page.
Report FOH segments - #79985
Closed
cshung wants to merge 1 commit into
Closed
Conversation
ghost
commented
Dec 27, 2022
Tagging subscribers to this area: @tommcdon Issue Detailsnull
|
cshung
marked this pull request as draft
December 27, 2022 04:18
cshungforce-pushed
the
public/report-foh-segments
branch
from
December 27, 2022 07:17
bf1f93c to
f363fb9Comparehoyosjs
reviewed
Dec 28, 2022
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue that
!dumpheapfailed on a heap dump (captured usingcreatedump --type heap) because the FOH segments are not enumerated during the dump capture.It was working before we moved the underlying storage from
ClrVirtualAlloctoExecutableAllocatorin #78292.This change makes sure they are enumerated.