') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [release/6.0] CreateDump: Only add pages with committed memory by hoyosjs · Pull Request #80005 · dotnet/runtime · GitHub
Skip to content

[release/6.0] CreateDump: Only add pages with committed memory - #80005

Closed
hoyosjs wants to merge 3 commits into
dotnet:release/6.0from
hoyosjs:juhoyosa/backport-dump-memory-6
Closed

[release/6.0] CreateDump: Only add pages with committed memory#80005
hoyosjs wants to merge 3 commits into
dotnet:release/6.0from
hoyosjs:juhoyosa/backport-dump-memory-6

Conversation

@hoyosjs

@hoyosjshoyosjs commented Dec 27, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Backport of #79853 to release/7.0, issue #71472

Creating a dump against some kernel implementations is committing empty pages with the page probing technique we currently use during memory enumeration. This change uses the pagemap API's in the /proc system if available - both regarding existence and permissions - along with the maps api to decide what pages contain relevant information. This results in smaller dumps and no increase in resident memory usage when collecting a dump.

Customer Impact

Customers have reported memory doubling in processes they dump. This is fatal environments such as K8s and cgroups hosting, where the process of collecting a dump often results of a OOM kill. This makes crash and ad-hoc diagnostics harder than needs be.

Testing

TBD

Risk

Low - fallback to prior code paths is enabled. Also, it's possible to explicitly disable the new behavior by setting the env var DbgDisablePagemapUse.

@hoyosjs@ezsilmar
CreateDump: Only add pages with committed memory
c507795
Creating a dump against some kernel implementations is committing empty pages with the page probing technique we currently use during memory enumeration. This change uses the `pagemap` API's in the `/proc` system if available - both regarding existence and permissions - along with the `maps` api to decide what pages contain relevant information. This results in smaller dumps and no increase in resident memory usage when collecting a dump.
Co-authored-by: Eugene Zhirov <e.zhirov@criteo.com>
@hoyosjshoyosjs added the Servicing-consider Issue for next servicing release review label Dec 27, 2022
@hoyosjshoyosjs added this to the 6.0.x milestone Dec 27, 2022
@hoyosjshoyosjs self-assigned this Dec 27, 2022
@ghost

ghost commented Dec 27, 2022

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #79853 to release/7.0, issue #71472

Creating a dump against some kernel implementations is committing empty pages with the page probing technique we currently use during memory enumeration. This change uses the pagemap API's in the /proc system if available - both regarding existence and permissions - along with the maps api to decide what pages contain relevant information. This results in smaller dumps and no increase in resident memory usage when collecting a dump.

Customer Impact

Customers have reported memory doubling in processes they dump. This is fatal environments such as K8s and cgroups hosting, where the process of collecting a dump often results of a OOM kill. This makes crash and ad-hoc diagnostics harder than needs be.

Testing

TBD

Risk

Low - fallback to prior code paths is enabled.

Author:hoyosjs
Assignees:hoyosjs
Labels:

Servicing-consider, area-Diagnostics-coreclr

Milestone:6.0.x

@mikem8361

mikem8361 commented Dec 27, 2022

Copy link
Copy Markdown
Contributor

We may want a opt-in/out env variable to control using the page map code. Tom and I briefly talked about this before vacation.

/cc: @tommcdon

@hoyosjs

hoyosjs commented Dec 28, 2022

Copy link
Copy Markdown
MemberAuthor

Happy to add that as long as it is opt out.

@hoyosjshoyosjs mentioned this pull request Dec 29, 2022
Closed
@jeffschwMSFTjeffschwMSFT removed the Servicing-consider Issue for next servicing release review label Jan 3, 2023
@mikem8361mikem8361 self-assigned this Jan 3, 2023
@jeffschwMSFTjeffschwMSFT added the Servicing-consider Issue for next servicing release review label Jan 3, 2023
jeffschwMSFT
jeffschwMSFT approved these changes Jan 3, 2023
View reviewed changes

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 6.0.x

@hoyosjshoyosjs added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 5, 2023
@jeffschwMSFTjeffschwMSFT removed the Servicing-consider Issue for next servicing release review label Jan 10, 2023
@hoyosjs
hoyosjs marked this pull request as draft January 12, 2023 23:27
@ghostghost closed this Mar 12, 2023
@ghost

ghost commented Mar 12, 2023

Copy link
Copy Markdown

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghostghost locked as resolved and limited conversation to collaborators Apr 12, 2023
This pull request was closed.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review
+1 more reviewer
@mikem8361mikem8361mikem8361 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mikem8361mikem8361

@hoyosjshoyosjs

Labels

area-Diagnostics-coreclrNO-MERGEThe PR is not ready for merge yet (see discussion for detailed reasons)

Projects

None yet

Milestone

6.0.x

Development

Successfully merging this pull request may close these issues.

4 participants

@hoyosjs@mikem8361@jeffschwMSFT@carlossanlop