Uh oh!
There was an error while loading. Please reload this page.
Enable CoreCLR init failure logging in single exe host - #80104
Merged
janvorli merged 2 commits intoJan 4, 2023
Merged
Conversation
When adding the CoreCLR initialization failure logging recently, I have missed the fact that there are two versions of the coreclr_resolver.cpp. One for standalone host that I have added support for, but also for linking into single exe. This change adds the missing support to the single exe host.
ghost
commented
Jan 2, 2023
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsWhen adding the CoreCLR initialization failure logging recently, I have missed the fact that there are two versions of the coreclr_resolver.cpp. One for standalone host that I have added support for, but also for linking into single exe. This change adds the missing support to the single exe host.
|
Closed
vitek-karas
approved these changes
Jan 3, 2023
vitek-karas
left a comment
Member
There was a problem hiding this comment.
Looks good - I would only remove the unnecessary typedef.
| #include <pal.h> | ||
| #include <trace.h> | ||
| typedef void (*coreclr_error_writer_callback_fn) (const char *message); |
Member
There was a problem hiding this comment.
I don't think this is necessary - the same typedef already exists in coreclr_resolver.h which is included.
janvorli
commented
Jan 4, 2023
MemberAuthor
The CI failure is a known issue unrelated to this change. |
janvorli
deleted the
add-coreclr-initialization-failure-logging-to-single-exe
branch
January 4, 2023 13:36
janvorli added a commit
to janvorli/runtime
that referenced
this pull request
Jan 6, 2023
Port of dotnet#78484, dotnet#78790, dotnet#80104 and dotnet#80294 This change adds detecting and logging of failures during coreclr initialization. For logging, it uses a new host API `coreclr_set_error_writer` to register a callback to report the errors to the host. The hosts have support for optional usage of this API so that they can work with older runtime versions as well. The logging checks and reports failures with: * System.Private.CoreLib.dll * GC initialization * JIT initialization * libSystem.Native.so/dylib on Unix The logging messages should allow customers to self-diagnose the issues causing the failures. This change also adds backport of support for standalone GC back compatibility that is a prerequisite for it.
janvorli added a commit
to janvorli/runtime
that referenced
this pull request
Jan 17, 2023
Port of dotnet#78484, dotnet#78790, dotnet#80104 and dotnet#80294 This change adds detecting and logging of failures during coreclr initialization. For logging, it uses a new host API `coreclr_set_error_writer` to register a callback to report the errors to the host. The hosts have support for optional usage of this API so that they can work with older runtime versions as well. The logging checks and reports failures with: * System.Private.CoreLib.dll * GC initialization * JIT initialization * libSystem.Native.so/dylib on Unix The logging messages should allow customers to self-diagnose the issues causing the failures. This change also adds backport of support for standalone GC back compatibility that is a prerequisite for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding the CoreCLR initialization failure logging recently, I have missed the fact that there are two versions of the coreclr_resolver.cpp. One for standalone host that I have added support for, but also for linking into single exe.
This change adds the missing support to the single exe host.