Uh oh!
There was an error while loading. Please reload this page.
Remove page map from PAL virtual memory allocator - #80105
Merged
Conversation
janvorli
commented
Jan 2, 2023
MemberAuthor
cc: @mangod9 |
mangod9
approved these changes
Jan 2, 2023
mangod9
left a comment
Member
There was a problem hiding this comment.
Thanks, certainly feels less risky than the full GC PAL change.
jkotas
commented
Jan 2, 2023
Member
Is |
janvorli
commented
Jan 2, 2023
MemberAuthor
Yes, that's the only one. |
jkotas
approved these changes
Jan 2, 2023
janvorli
commented
Jan 4, 2023
MemberAuthor
/backport to release/7.0 |
Contributor
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3838505566 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the page map from the PAL virtual memory allocator. This map is only used for the
VirtualQueryAPI implementation and the usage of that API in the runtime actually only care about whether a virtual memory range is free or not (it doesn't care about whether the memory is reserved or committed, and it doesn't care about the actual protection).